mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 04:43:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Remove unnecessary var re-assignment

Browse source
This commit is contained in:
misaochan 2016-10-28 16:56:14 +13:00
parent 70c439417f
commit 8c6046feda
1 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
app/src/main/java/fr/free/nrw/commons/category/CategorizationFragment.java
View file

@ -584,7 +584,7 @@ public class CategorizationFragment extends Fragment {
public boolean onOptionsItemSelected(MenuItem menuItem) { public boolean onOptionsItemSelected(MenuItem menuItem) {
switch(menuItem.getItemId()) { switch(menuItem.getItemId()) {
case R.id.menu_save_categories: case R.id.menu_save_categories:
ArrayList<String> selectedCategories = new ArrayList<String>(); final ArrayList<String> selectedCategories = new ArrayList<String>();
int numberSelected = 0; int numberSelected = 0;
for(CategoryItem item: categoriesAdapter.getItems()) { for(CategoryItem item: categoriesAdapter.getItems()) {
@ -594,9 +594,6 @@ public class CategorizationFragment extends Fragment {
} }
} }
//Need to reassign to a final variable to use in inner class
final ArrayList<String> finalCategories = selectedCategories;
//If no categories selected, display warning to user //If no categories selected, display warning to user
if (numberSelected == 0) { if (numberSelected == 0) {
AlertDialog.Builder builder = new AlertDialog.Builder(getActivity()); AlertDialog.Builder builder = new AlertDialog.Builder(getActivity());
@ -612,7 +609,7 @@ public class CategorizationFragment extends Fragment {
builder.setNegativeButton("Yes, submit", new DialogInterface.OnClickListener() { builder.setNegativeButton("Yes, submit", new DialogInterface.OnClickListener() {
public void onClick(DialogInterface dialog, int id) { public void onClick(DialogInterface dialog, int id) {
//Proceed to submission //Proceed to submission
onCategoriesSaveHandler.onCategoriesSave(finalCategories); onCategoriesSaveHandler.onCategoriesSave(selectedCategories);
return; return;
} }
}); });
@ -621,7 +618,7 @@ public class CategorizationFragment extends Fragment {
dialog.show(); dialog.show();
} else { } else {
//Proceed to submission //Proceed to submission
onCategoriesSaveHandler.onCategoriesSave(finalCategories); onCategoriesSaveHandler.onCategoriesSave(selectedCategories);
return true; return true;
} }
} }