mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 12:53:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use resultCode == RESULT_OK instead of null check

Browse source 
See https://developer.android.com/training/camera/photobasics.html#TaskPhotoView
and 12564910 (12564910)

Follows up 2f95a79abd and fa5b6c0869
This commit is contained in:
Yusuke Matsubara 2016-09-28 22:13:54 +09:00
parent 1927dfb1b9
commit 8bc47bf62a
2 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java
View file

@ -67,12 +67,13 @@ public class ContributionController {
fragment.startActivityForResult(pickImageIntent, SELECT_FROM_GALLERY);
}
public void handleImagePicked(int requestCode, Uri imageData) {
public void handleImagePicked(int requestCode, Intent data) {
Intent shareIntent = new Intent(activity, ShareActivity.class);
shareIntent.setAction(Intent.ACTION_SEND);
switch(requestCode) {
case SELECT_FROM_GALLERY:
//FIXME: Handles image picked from gallery (from Google Photos)
Uri imageData = data.getData();
shareIntent.setType(activity.getContentResolver().getType(imageData));
shareIntent.putExtra(Intent.EXTRA_STREAM, imageData);
shareIntent.putExtra(UploadService.EXTRA_SOURCE, fr.free.nrw.commons.contributions.Contribution.SOURCE_GALLERY);

11
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java
View file

@ -33,6 +33,8 @@ import fr.free.nrw.commons.SettingsActivity;
import fr.free.nrw.commons.nearby.NearbyActivity;
import fr.free.nrw.commons.upload.UploadService;
import static android.app.Activity.RESULT_OK;
public class ContributionsListFragment extends Fragment {
public interface SourceRefresher {
@ -98,12 +100,11 @@ public class ContributionsListFragment extends Fragment {
//FIXME: must get the file data for Google Photos when receive the intent answer, in the onActivityResult method
super.onActivityResult(requestCode, resultCode, data);
if (data != null) {
Log.d("Contributions", "OnActivityResult() parameters: Result code: " + resultCode + " Data: " + data.toString());
Uri imageData = data.getData();
controller.handleImagePicked(requestCode, imageData);
if ( resultCode == RESULT_OK ) {
Log.d("Contributions", "OnActivityResult() parameters: Req code: " + requestCode + " Result code: " + resultCode + " Data: " + data);
controller.handleImagePicked(requestCode, data);
} else {
Log.e("Contributions", "OnActivityResult() parameters: Result code: " + resultCode + " Data: null");
Log.e("Contributions", "OnActivityResult() parameters: Req code: " + requestCode + " Result code: " + resultCode + " Data: " + data);
}
}