mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 12:53:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixes #3389 - Show User profiles (#4678)

Browse source 
* Fixes #3389 - Show  User profiles

* Don't show dummy achievements data - show data only when loaded
This commit is contained in:
Ashish 2021-10-26 02:10:08 +05:30 • committed by GitHub
parent 7ce80aa804
commit 88b21a678e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
20 changed files with 358 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

3
app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionBoundaryCallbackTest.kt
View file

@ -49,7 +49,8 @@ class ContributionBoundaryCallbackTest {
MockitoAnnotations.initMocks(this)
scheduler = Schedulers.trampoline()
contributionBoundaryCallback =
ContributionBoundaryCallback(repository, sessionManager, mediaClient, scheduler);
ContributionBoundaryCallback(repository, sessionManager, mediaClient, scheduler)
contributionBoundaryCallback.userName = "test"
}
@Test

10
app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionsListPresenterTest.kt
View file

@ -32,6 +32,9 @@ class ContributionsListPresenterTest {
@Mock
internal lateinit var repository: ContributionsRepository
@Mock
internal lateinit var remoteDataSource: ContributionsRemoteDataSource
@Rule
@JvmField
var instantTaskExecutorRule = InstantTaskExecutorRule()
@ -49,7 +52,12 @@ class ContributionsListPresenterTest {
MockitoAnnotations.initMocks(this)
scheduler = Schedulers.trampoline()
contributionsListPresenter =
ContributionsListPresenter(contributionBoundaryCallback, repository, scheduler);
ContributionsListPresenter(
contributionBoundaryCallback,
remoteDataSource,
repository,
scheduler
);
}
@Test

2
app/src/test/kotlin/fr/free/nrw/commons/profile/ProfileActivityTest.kt
View file

@ -80,7 +80,7 @@ class ProfileActivityTest {
@Test
@Throws(Exception::class)
fun testStartYourself() {
ProfileActivity.startYourself(activity)
ProfileActivity.startYourself(activity, "test", false)
}
@Test

9
app/src/test/kotlin/fr/free/nrw/commons/profile/achievements/AchievementsFragmentUnitTests.kt
View file

@ -11,12 +11,14 @@ import androidx.fragment.app.FragmentTransaction
import com.dinuscxj.progressbar.CircleProgressBar
import fr.free.nrw.commons.TestAppAdapter
import fr.free.nrw.commons.TestCommonsApplication
import fr.free.nrw.commons.auth.SessionManager
import fr.free.nrw.commons.profile.ProfileActivity
import org.junit.Assert
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.mockito.Mock
import org.mockito.Mockito
import org.mockito.MockitoAnnotations
import org.powermock.reflect.Whitebox
import org.robolectric.Robolectric
@ -85,6 +87,9 @@ class AchievementsFragmentUnitTests {
@Mock
private lateinit var progressBar: ProgressBar
@Mock
private lateinit var sessionManager: SessionManager
@Before
fun setUp() {
MockitoAnnotations.initMocks(this)
@ -131,6 +136,10 @@ class AchievementsFragmentUnitTests {
Whitebox.setInternalState(fragment, "progressBar", progressBar)
Whitebox.setInternalState(fragment, "imagesRevertLimitText", imagesRevertLimitText)
Whitebox.setInternalState(fragment, "item", menuItem)
Whitebox.setInternalState(fragment, "sessionManager", sessionManager)
Mockito.`when`(sessionManager.userName).thenReturn("Test")
}
@Test