From 8783138e9e22f63f5075bb44190a5e618fd726fe Mon Sep 17 00:00:00 2001 From: Christo Joby Antony Date: Sat, 19 Oct 2024 01:26:07 +1100 Subject: [PATCH] Set name of the place to avoid race condition with NearbyParentFragment. Update Success Notification to show only after the pin has been updated. --- .../java/fr/free/nrw/commons/upload/worker/UploadWorker.kt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt b/app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt index c3350ab03..fb2ca7b3a 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt +++ b/app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt @@ -477,9 +477,9 @@ class UploadWorker( contribution.media.captions, ) if (null != revisionID) { - showSuccessNotification(contribution) withContext(Dispatchers.IO) { val place = placesRepository.fetchPlace(wikiDataPlace.id); + place.name = wikiDataPlace.name; place.pic = HOME_URL + uploadResult.createCanonicalFileName() placesRepository .save(place) @@ -487,6 +487,7 @@ class UploadWorker( .blockingAwait() Timber.d("Updated WikiItem place ${place.name} with image ${place.pic}") } + showSuccessNotification(contribution) } } catch (exception: Exception) { Timber.e(exception)