mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Better rounding for width, avoids pixelation in large displays

Browse source 
Bug: 49718

Change-Id: I67541852b9bcb20fbb4b0af4b3900f2af4ace7bc
GitHub: https://github.com/wikimedia/apps-android-commons/pull/15
This commit is contained in:
YuviPanda 2013-06-18 14:32:57 +00:00 • committed by Brion Vibber
parent e05053933d
commit 86a39e9d13
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
commons/src/main/java/org/wikimedia/commons/MediaWikiImageView.java
View file

@ -88,18 +88,18 @@ public class MediaWikiImageView extends ImageView {
if(tryOriginal) { if(tryOriginal) {
mUrl = mMedia.getImageUrl(); mUrl = mMedia.getImageUrl();
} else { } else {
// Round it down to the nearest 320 // Round it to the nearest 320
// Possible a similar size image has already been generated. // Possible a similar size image has already been generated.
// Reduces Server cache fragmentation, also increases chance of cache hit // Reduces Server cache fragmentation, also increases chance of cache hit
// If width is less than 320, we just use that directly, to avoid a case of the Maths // If width is less than 320, we round up to 320
int bucketedWidth = width <= 320 ? width: (width / 320) * 320; int bucketedWidth = width <= 320 ? 320 : Math.round((float)width / 320.0f) * 320;
if(mMedia.getWidth() != 0 && mMedia.getWidth() < bucketedWidth) { if(mMedia.getWidth() != 0 && mMedia.getWidth() < bucketedWidth) {
// If we know that the width of the image is lesser than the required width // If we know that the width of the image is lesser than the required width
// We don't even try to load the thumbnai, go directly to the source // We don't even try to load the thumbnai, go directly to the source
loadImageIfNecessary(isInLayoutPass, true); loadImageIfNecessary(isInLayoutPass, true);
return; return;
} else { } else {
mUrl = mMedia.getThumbnailUrl(width <= 320 ? width : (width / 320) * 320); mUrl = mMedia.getThumbnailUrl(bucketedWidth);
} }
} }