mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge pull request #166 from whym/authactivity-abstract

Browse source 
Make AuthenticatedActivity abstract (per lint)
This commit is contained in:
Nicolas Raoul 2016-07-11 12:17:21 +09:00 • committed by GitHub
commit 86950cedfc
4 changed files with 3 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

10
app/src/main/java/fr/free/nrw/commons/auth/AuthenticatedActivity.java
View file

@ -11,7 +11,7 @@ import android.support.v7.app.AppCompatActivity;
import fr.free.nrw.commons.CommonsApplication; import fr.free.nrw.commons.CommonsApplication;
import fr.free.nrw.commons.Utils; import fr.free.nrw.commons.Utils;
public class AuthenticatedActivity extends AppCompatActivity { public abstract class AuthenticatedActivity extends AppCompatActivity {
String accountType; String accountType;
@ -143,10 +143,6 @@ public class AuthenticatedActivity extends AppCompatActivity {
outState.putString("authCookie", authCookie); outState.putString("authCookie", authCookie);
} }
protected void onAuthCookieAcquired(String authCookie) { protected abstract void onAuthCookieAcquired(String authCookie);
protected abstract void onAuthFailure();
}
protected void onAuthFailure() {
}
} }

1
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java
View file

@ -188,7 +188,6 @@ public class ContributionsActivity
@Override @Override
protected void onAuthFailure() { protected void onAuthFailure() {
super.onAuthFailure();
finish(); // If authentication failed, we just exit finish(); // If authentication failed, we just exit
} }

1
app/src/main/java/fr/free/nrw/commons/upload/MultipleShareActivity.java
View file

@ -236,7 +236,6 @@ public class MultipleShareActivity
@Override @Override
protected void onAuthFailure() { protected void onAuthFailure() {
super.onAuthFailure();
Toast failureToast = Toast.makeText(this, R.string.authentication_failed, Toast.LENGTH_LONG); Toast failureToast = Toast.makeText(this, R.string.authentication_failed, Toast.LENGTH_LONG);
failureToast.show(); failureToast.show();
finish(); finish();

2
app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java
View file

@ -158,7 +158,6 @@ public class ShareActivity
@Override @Override
protected void onAuthCookieAcquired(String authCookie) { protected void onAuthCookieAcquired(String authCookie) {
super.onAuthCookieAcquired(authCookie);
app.getApi().setAuthCookie(authCookie); app.getApi().setAuthCookie(authCookie);
@ -176,7 +175,6 @@ public class ShareActivity
@Override @Override
protected void onAuthFailure() { protected void onAuthFailure() {
super.onAuthFailure();
Toast failureToast = Toast.makeText(this, R.string.authentication_failed, Toast.LENGTH_LONG); Toast failureToast = Toast.makeText(this, R.string.authentication_failed, Toast.LENGTH_LONG);
failureToast.show(); failureToast.show();
finish(); finish();