Limit view of recent cats to 20

This commit is contained in:
Brion Vibber 2013-04-24 08:55:24 -07:00
parent 308b28dd23
commit 84c2054fb0

View file

@ -50,6 +50,8 @@ public class CategorizationFragment extends SherlockFragment{
private ContentProviderClient client; private ContentProviderClient client;
private final int RECENT_CATS_LIMIT = 20;
public static class CategoryItem implements Parcelable { public static class CategoryItem implements Parcelable {
public String name; public String name;
public boolean selected; public boolean selected;
@ -129,8 +131,6 @@ public class CategorizationFragment extends SherlockFragment{
protected ArrayList<String> doInBackground(Void... voids) { protected ArrayList<String> doInBackground(Void... voids) {
if(TextUtils.isEmpty(filter)) { if(TextUtils.isEmpty(filter)) {
ArrayList<String> items = new ArrayList<String>(); ArrayList<String> items = new ArrayList<String>();
// fixme add a limit?
// fixme sort by last_used descending?
try { try {
Cursor cursor = client.query( Cursor cursor = client.query(
CategoryContentProvider.BASE_URI, CategoryContentProvider.BASE_URI,
@ -138,7 +138,8 @@ public class CategorizationFragment extends SherlockFragment{
null, null,
new String[]{}, new String[]{},
Category.Table.COLUMN_LAST_USED + " DESC"); Category.Table.COLUMN_LAST_USED + " DESC");
while (cursor.moveToNext()) { // fixme add a limit on the original query instead of falling out of the loop?
while (cursor.moveToNext() && cursor.getPosition() < RECENT_CATS_LIMIT) {
Category cat = Category.fromCursor(cursor); Category cat = Category.fromCursor(cursor);
items.add(cat.getName()); items.add(cat.getName());
} }