mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Bugfix/null revision in review (#3309)

Browse source 
* Fixes #3305
 * Handle null firstRevision

* initialise explanation
This commit is contained in:
Ashish Kumar 2019-12-24 14:02:56 +05:30 • committed by Vivek Maskara
parent 959b3afd4c
commit 824d6ac05e
1 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.java
View file

@ -76,7 +76,7 @@ public class ReviewImageFragment extends CommonsDaggerSupportFragment {
false); false);
ButterKnife.bind(this, layoutView); ButterKnife.bind(this, layoutView);
String question, explanation, yesButtonText, noButtonText; String question, explanation=null, yesButtonText, noButtonText;
switch (position) { switch (position) {
case SPAM: case SPAM:
question = getString(R.string.review_spam); question = getString(R.string.review_spam);
@ -115,12 +115,17 @@ public class ReviewImageFragment extends CommonsDaggerSupportFragment {
//Get existing user name if it is already saved using savedInstanceState else get from reviewController //Get existing user name if it is already saved using savedInstanceState else get from reviewController
if (savedInstanceState == null) { if (savedInstanceState == null) {
user = getReviewActivity().reviewController.firstRevision.getUser(); if (getReviewActivity().reviewController != null) {
user = getReviewActivity().reviewController.firstRevision.getUser();
}
} else { } else {
user = savedInstanceState.getString(SAVED_USER); user = savedInstanceState.getString(SAVED_USER);
} }
explanation = getString(R.string.review_thanks_explanation, user); //if the user is null because of whatsoever reason, review will not be sent anyways
if (!TextUtils.isEmpty(user)) {
explanation = getString(R.string.review_thanks_explanation, user);
}
yesButtonText = getString(R.string.review_thanks_yes_button_text); yesButtonText = getString(R.string.review_thanks_yes_button_text);
noButtonText = getString(R.string.review_thanks_no_button_text); noButtonText = getString(R.string.review_thanks_no_button_text);