mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixes #3436 and #2881: Media Detail design Overhaul (#3505)

Browse source 
* ic_map_dark_24dp: map icon for white background

* ic_info_outline_dark_24dp: info icon for dark background

* MediaDetailFragment: update the spacer as per image aspect ratio

* fragment_media_detail: design overhaul

* fragment_media_detail: remove redundant background color statements

* make requested changes

* add dark mode support

* minor ui tweak

* white map icon in dark mode

* make rquested changes

* make requested changes to layout

* fix misalignment of category list

* subtle amendments

* convert comments to javadocs

* minor amendments

* minor changes

* add styles for media detail

* Media detail fragment refactored

* make suggested changes

* minor name fix

* fix the delete button border
This commit is contained in:
Kshitij Bhardwaj 2020-04-19 18:24:17 -04:00 • committed by GitHub
parent fcd2867d26
commit 81e12a9e1f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 194 additions and 178 deletions
Download patch file Download diff file Expand all files Collapse all files

43
app/src/main/res/values/styles.xml
View file

@ -34,6 +34,12 @@
<item name="textEnabled">@color/enabled_button_text_color_dark</item>
<item name="mainCardBackground">@color/main_background_dark</item>
<item name="mainScreenNearbyPermissionbutton">@style/DarkFlatNearbyPermissionButton</item>
<item name="iconInfo24">@drawable/ic_info_outline_24dp</item>
<item name="iconMap24" >@drawable/ic_map_white_24dp</item>
<item name="mediaDetailsText" >@color/white</item>
<item name="mediaDetailsHeadingText">@color/layout_light_grey</item>
<item name="mediaDetailNominationBackground">@color/deleteRedDark</item>
<item name="mediaDetailSpacerColor">@color/browser_actions_divider_color</item>
</style>
<style name="LightAppTheme" parent="Theme.AppCompat.Light.NoActionBar">
@ -69,6 +75,12 @@
<item name="textEnabled">@color/enabled_button_text_color_light</item>
<item name="mainCardBackground">@color/primaryDarkColor</item>
<item name="mainScreenNearbyPermissionbutton">@style/LightFlatNearbyPermissionButton</item>
<item name="iconInfo24">@drawable/ic_info_outline_dark_24dp</item>
<item name="iconMap24">@drawable/ic_map_dark_24dp</item>
<item name="mediaDetailsText">@color/enabled_button_text_color_light</item>
<item name="mediaDetailsHeadingText">@color/primaryDarkColor</item>
<item name="mediaDetailNominationBackground">@color/deleteRed</item>
<item name="mediaDetailSpacerColor">@color/divider_grey</item>
</style>
<style name="WhiteSearchBarTheme" parent="DarkAppTheme">
@ -129,4 +141,35 @@
<item name="centerRegion">#906078</item>
</style>
<style name="MediaDetailContainer">
<item name="android:paddingLeft">@dimen/quarter_standard_height</item>
<item name="android:paddingRight">@dimen/quarter_standard_height</item>
<item name="android:paddingTop">@dimen/tiny_gap</item>
<item name="android:paddingBottom">@dimen/tiny_gap</item>
</style>
<style name="MediaDetailTextLabel">
<item name="android:layout_weight">30</item>
<item name="android:paddingTop">@dimen/dimen_6</item>
<item name="android:paddingLeft">@dimen/tiny_gap</item>
<item name="android:textSize">@dimen/normal_text</item>
<item name="android:textStyle">bold</item>
</style>
<style name="MediaDetailTextLabelTitle" parent="@style/MediaDetailTextLabel">
<item name="android:textColor">@android:color/white</item>
</style>
<style name="MediaDetailTextLabelGeneric" parent="@style/MediaDetailTextLabel">
<item name="android:textColor">?attr/mediaDetailsHeadingText</item>
</style>
<style name="MediaDetailTextBody">
<item name="android:layout_weight">70</item>
<item name="android:layout_gravity">start</item>
<item name="android:padding">@dimen/small_gap</item>
<item name="android:textColor">?attr/mediaDetailsText</item>
<item name="android:textSize">@dimen/description_text_size</item>
</style>
</resources>