From 7f720d1f3e3cab022f7b1b58a3d8e7e3469a219b Mon Sep 17 00:00:00 2001 From: YuviPanda Date: Thu, 28 Mar 2013 04:23:48 +0530 Subject: [PATCH] Handle menu enabling / disabling appropriately --- .../org/wikimedia/commons/SingleUploadFragment.java | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/commons/src/main/java/org/wikimedia/commons/SingleUploadFragment.java b/commons/src/main/java/org/wikimedia/commons/SingleUploadFragment.java index d4cd20be7..64007432c 100644 --- a/commons/src/main/java/org/wikimedia/commons/SingleUploadFragment.java +++ b/commons/src/main/java/org/wikimedia/commons/SingleUploadFragment.java @@ -29,12 +29,12 @@ public class SingleUploadFragment extends SherlockFragment { private OnUploadActionInitiated uploadActionInitiatedHandler; - private Menu actionMenu; - @Override public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) { inflater.inflate(R.menu.activity_share, menu); - actionMenu = menu; + if(titleEdit != null) { + menu.findItem(R.id.menu_upload_single).setEnabled(titleEdit.getText().length() != 0); + } } @Override @@ -61,10 +61,7 @@ public class SingleUploadFragment extends SherlockFragment { public void onTextChanged(CharSequence charSequence, int i, int i2, int i3) {} public void afterTextChanged(Editable editable) { - if(actionMenu == null) { - getSherlockActivity().invalidateOptionsMenu(); - } - actionMenu.findItem(R.id.menu_upload_single).setEnabled(titleEdit.getText().length() != 0); + getSherlockActivity().invalidateOptionsMenu(); } };