mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 12:53:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Resolve switching languages problem in settings fragment (#5560)

Browse source 
* SettingsFragment: add a method for creating locale

* SettingsFragmentUnitTests: fix failing tests for createLocale
This commit is contained in:
Rohit Verma 2024-03-22 19:42:45 +05:30 • committed by GitHub
parent 751bc6ce6b
commit 7e5789d539
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 55 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

32
app/src/test/kotlin/fr/free/nrw/commons/settings/SettingsFragmentUnitTests.kt
View file

@ -19,8 +19,10 @@ import fr.free.nrw.commons.TestCommonsApplication
import fr.free.nrw.commons.recentlanguages.Language
import fr.free.nrw.commons.recentlanguages.RecentLanguagesAdapter
import fr.free.nrw.commons.recentlanguages.RecentLanguagesDao
import fr.free.nrw.commons.upload.UploadMediaDetailAdapter
import fr.free.nrw.commons.settings.SettingsFragment.createLocale
import org.junit.Assert
import org.junit.Assert.assertEquals
import org.junit.Assert.assertNull
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
@ -34,6 +36,8 @@ import org.robolectric.Shadows
import org.robolectric.annotation.Config
import org.robolectric.annotation.LooperMode
import java.lang.reflect.Method
import java.util.Locale
@RunWith(RobolectricTestRunner::class)
@Config(sdk = [21], application = TestCommonsApplication::class)
@ -255,4 +259,30 @@ class SettingsFragmentUnitTests {
verify(recentLanguagesTextView, times(1)).visibility = View.VISIBLE
}
@Test
fun testCreateLocaleWithLanguageCode() {
val locale: Locale = createLocale("en")
assertEquals("en", locale.language)
assertEquals("",locale.country)
assertEquals("",locale.variant)
}
@Test
fun testCreateLocaleWithLanguageAndCountryCode() {
val locale: Locale = createLocale("zh-CN")
assertEquals("zh", locale.language)
assertEquals("CN",locale.country)
assertEquals("",locale.variant)
}
@Test
fun testCreateLocaleWithLanguageCountryAndVariantCode() {
val locale: Locale = createLocale("pt-BR-variant")
assertEquals("pt", locale.language)
assertEquals("BR",locale.country)
assertEquals("variant",locale.variant)
}
}