mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-29 05:43:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

5074: Fix cropped numbers in Leaderboard (#5143)

Browse source 
* fix cropped numbers in the Achievements fragment

* add null check in inflateAchievements method to fix NullPointerException in AchievementsFragmentUnitTests
This commit is contained in:
Ritika Pahwa 2023-02-26 10:54:55 +05:30 • committed by GitHub
parent 23ee2b60d8
commit 7d895c4379
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 89 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

14
app/src/main/java/fr/free/nrw/commons/profile/achievements/AchievementsFragment.java
View file

@ -77,9 +77,15 @@ public class AchievementsFragment extends CommonsDaggerSupportFragment {
@BindView(R.id.images_uploaded_progressbar)
CircleProgressBar imagesUploadedProgressbar;
@BindView(R.id.tv_uploaded_images)
AppCompatTextView uploadedImagesTextview;
@BindView(R.id.images_used_by_wiki_progress_bar)
CircleProgressBar imagesUsedByWikiProgressBar;
@BindView(R.id.tv_wiki_pb)
AppCompatTextView imagesUsedByWikiTextview;
@BindView(R.id.image_reverts_progressbar)
CircleProgressBar imageRevertsProgressbar;
@ -365,8 +371,8 @@ public class AchievementsFragment extends CommonsDaggerSupportFragment {
imagesUploadedProgressbar.setVisibility(View.VISIBLE);
imagesUploadedProgressbar.setProgress
(100*uploadCount/levelInfo.getMaxUploadCount());
imagesUploadedProgressbar.setProgressTextFormatPattern
(uploadCount +"/" + levelInfo.getMaxUploadCount() );
uploadedImagesTextview.setText
(uploadCount + "/" + levelInfo.getMaxUploadCount());
}
}
@ -413,8 +419,10 @@ public class AchievementsFragment extends CommonsDaggerSupportFragment {
thanksReceived.setText(String.valueOf(achievements.getThanksReceived()));
imagesUsedByWikiProgressBar.setProgress
(100 * achievements.getUniqueUsedImages() / levelInfo.getMaxUniqueImages());
imagesUsedByWikiProgressBar.setProgressTextFormatPattern
if(imagesUsedByWikiTextview != null) {
imagesUsedByWikiTextview.setText
(achievements.getUniqueUsedImages() + "/" + levelInfo.getMaxUniqueImages());
}
imagesFeatured.setText(String.valueOf(achievements.getFeaturedImages()));
tvQualityImages.setText(String.valueOf(achievements.getQualityImages()));
String levelUpInfoString = getString(R.string.level).toUpperCase();