From b0d6b5acb8ee82bcdccfa94c10f24f49b39c8e9b Mon Sep 17 00:00:00 2001 From: misaochan Date: Sat, 8 Oct 2016 20:22:54 +1300 Subject: [PATCH 1/3] Change Page class to public --- app/src/main/java/fr/free/nrw/commons/upload/MwVolleyApi.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/fr/free/nrw/commons/upload/MwVolleyApi.java b/app/src/main/java/fr/free/nrw/commons/upload/MwVolleyApi.java index 714931cff..5f0ed0bc8 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/MwVolleyApi.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/MwVolleyApi.java @@ -211,7 +211,7 @@ public class MwVolleyApi { } } - private static class Page { + public static class Page { private int pageid; private int ns; private String title; From 76c4b0ab322cb064d6f77d80d4ab07433a46d59a Mon Sep 17 00:00:00 2001 From: misaochan Date: Sat, 8 Oct 2016 20:33:55 +1300 Subject: [PATCH 2/3] Change log tags --- app/src/main/java/fr/free/nrw/commons/upload/MwVolleyApi.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/upload/MwVolleyApi.java b/app/src/main/java/fr/free/nrw/commons/upload/MwVolleyApi.java index 5f0ed0bc8..d88464cbc 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/MwVolleyApi.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/MwVolleyApi.java @@ -59,7 +59,7 @@ public class MwVolleyApi { public void request(String coords) { coordsLog = coords; String apiUrl = buildUrl(coords); - Log.d("Image", "URL: " + apiUrl); + Log.d(TAG, "URL: " + apiUrl); JsonRequest request = new QueryRequest(apiUrl, new LogResponseListener(), new LogResponseErrorListener()); @@ -108,7 +108,6 @@ public class MwVolleyApi { } private static class LogResponseListener implements Response.Listener { - private static final String TAG = LogResponseListener.class.getName(); @Override public void onResponse(T response) { @@ -117,7 +116,6 @@ public class MwVolleyApi { } private static class LogResponseErrorListener implements Response.ErrorListener { - private static final String TAG = LogResponseErrorListener.class.getName(); @Override public void onErrorResponse(VolleyError error) { From 14f2cb11aa9051c28f24ce81297c05d3244c05f5 Mon Sep 17 00:00:00 2001 From: misaochan Date: Sat, 8 Oct 2016 20:34:47 +1300 Subject: [PATCH 3/3] Change log tags 2 --- .../java/fr/free/nrw/commons/upload/GPSExtractor.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/upload/GPSExtractor.java b/app/src/main/java/fr/free/nrw/commons/upload/GPSExtractor.java index 209b3827f..e471e763a 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/GPSExtractor.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/GPSExtractor.java @@ -98,10 +98,10 @@ public class GPSExtractor { try { exif = new ExifInterface(filePath); } catch (IOException e) { - Log.w("Image", e); + Log.w(TAG, e); return null; } catch (IllegalArgumentException e) { - Log.w("Image", e); + Log.w(TAG, e); return null; } @@ -136,8 +136,8 @@ public class GPSExtractor { longitude_ref = exif.getAttribute(ExifInterface.TAG_GPS_LONGITUDE_REF); if (latitude!=null && latitude_ref!=null && longitude!=null && longitude_ref!=null) { - Log.d("Image", "Latitude: " + latitude + " " + latitude_ref); - Log.d("Image", "Longitude: " + longitude + " " + longitude_ref); + Log.d(TAG, "Latitude: " + latitude + " " + latitude_ref); + Log.d(TAG, "Longitude: " + longitude + " " + longitude_ref); decimalCoords = getDecimalCoords(latitude, latitude_ref, longitude, longitude_ref); return decimalCoords; @@ -201,7 +201,7 @@ public class GPSExtractor { } String decimalCoords = String.valueOf(decLatitude) + "|" + String.valueOf(decLongitude); - Log.d("Coords", "Latitude and Longitude are " + decimalCoords); + Log.d(TAG, "Latitude and Longitude are " + decimalCoords); return decimalCoords; }