From 7ad1cf294f6ab199bd7dbd2cdcae647e6387d947 Mon Sep 17 00:00:00 2001 From: Dinu Kumarasiri Date: Sat, 20 May 2017 11:37:04 +0200 Subject: [PATCH] [Lint] Remove class variables to local --- .../free/nrw/commons/MediaDataExtractor.java | 9 +++----- .../fr/free/nrw/commons/WelcomeActivity.java | 3 +-- .../nrw/commons/caching/CacheController.java | 2 +- .../commons/category/CategoriesAdapter.java | 4 ++-- .../nrw/commons/nearby/NearbyActivity.java | 23 +++++++------------ .../commons/nearby/NearbyListFragment.java | 22 +++++++----------- .../nrw/commons/nearby/NearbyMapFragment.java | 6 ++--- .../free/nrw/commons/upload/GPSExtractor.java | 7 +++--- .../free/nrw/commons/upload/MwVolleyApi.java | 3 +-- .../nrw/commons/upload/ShareActivity.java | 9 +++----- 10 files changed, 32 insertions(+), 56 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/MediaDataExtractor.java b/app/src/main/java/fr/free/nrw/commons/MediaDataExtractor.java index 344546c7a..86606f5b3 100644 --- a/app/src/main/java/fr/free/nrw/commons/MediaDataExtractor.java +++ b/app/src/main/java/fr/free/nrw/commons/MediaDataExtractor.java @@ -1,7 +1,5 @@ package fr.free.nrw.commons; -import fr.free.nrw.commons.location.LatLng; - import org.mediawiki.api.ApiResult; import org.w3c.dom.Document; import org.w3c.dom.Element; @@ -22,6 +20,7 @@ import javax.xml.parsers.DocumentBuilder; import javax.xml.parsers.DocumentBuilderFactory; import javax.xml.parsers.ParserConfigurationException; +import fr.free.nrw.commons.location.LatLng; import timber.log.Timber; /** @@ -32,12 +31,10 @@ import timber.log.Timber; */ public class MediaDataExtractor { private boolean fetched; - private boolean processed; private String filename; private ArrayList categories; private Map descriptions; - private String author; private Date date; private String license; private String coordinates; @@ -51,7 +48,7 @@ public class MediaDataExtractor { categories = new ArrayList<>(); descriptions = new HashMap<>(); fetched = false; - processed = false; + boolean processed = false; this.licenseList = licenseList; } @@ -122,7 +119,7 @@ public class MediaDataExtractor { descriptions = getMultilingualText(descriptionNode); Node authorNode = findTemplateParameter(templateNode, "author"); - author = getFlatText(authorNode); + String author = getFlatText(authorNode); } Node coordinateTemplateNode = findTemplate(doc.getDocumentElement(), "location"); diff --git a/app/src/main/java/fr/free/nrw/commons/WelcomeActivity.java b/app/src/main/java/fr/free/nrw/commons/WelcomeActivity.java index 30c8baf84..a71acec73 100644 --- a/app/src/main/java/fr/free/nrw/commons/WelcomeActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/WelcomeActivity.java @@ -10,7 +10,6 @@ import butterknife.ButterKnife; import fr.free.nrw.commons.theme.BaseActivity; public class WelcomeActivity extends BaseActivity { - private WelcomePagerAdapter adapter; @BindView(R.id.welcomePager) ViewPager pager; @BindView(R.id.welcomePagerIndicator) CirclePageIndicator indicator; @@ -27,7 +26,7 @@ public class WelcomeActivity extends BaseActivity { } private void setUpAdapter() { - adapter = new WelcomePagerAdapter(this); + WelcomePagerAdapter adapter = new WelcomePagerAdapter(this); pager.setAdapter(adapter); indicator.setViewPager(pager); } diff --git a/app/src/main/java/fr/free/nrw/commons/caching/CacheController.java b/app/src/main/java/fr/free/nrw/commons/caching/CacheController.java index 3cf61385d..49fec4c2e 100644 --- a/app/src/main/java/fr/free/nrw/commons/caching/CacheController.java +++ b/app/src/main/java/fr/free/nrw/commons/caching/CacheController.java @@ -14,7 +14,6 @@ public class CacheController { private double x, y; private QuadTree> quadTree; - private Point>[] pointsFound; private double xMinus, xPlus, yMinus, yPlus; private static final int EARTH_RADIUS = 6378137; @@ -42,6 +41,7 @@ public class CacheController { } public List findCategory() { + Point>[] pointsFound; //Convert decLatitude and decLongitude to a coordinate offset range convertCoordRange(); pointsFound = quadTree.searchWithin(xMinus, yMinus, xPlus, yPlus); diff --git a/app/src/main/java/fr/free/nrw/commons/category/CategoriesAdapter.java b/app/src/main/java/fr/free/nrw/commons/category/CategoriesAdapter.java index 3359150c5..5300b54ac 100644 --- a/app/src/main/java/fr/free/nrw/commons/category/CategoriesAdapter.java +++ b/app/src/main/java/fr/free/nrw/commons/category/CategoriesAdapter.java @@ -14,13 +14,13 @@ import fr.free.nrw.commons.R; public class CategoriesAdapter extends BaseAdapter { - private Context context; private LayoutInflater mInflater; private ArrayList items; public CategoriesAdapter(Context context, ArrayList items) { - this.context = context; + Context localcontext; + localcontext = context; this.items = items; mInflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE); } diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyActivity.java b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyActivity.java index 0782fc07b..346e22cc5 100644 --- a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyActivity.java @@ -2,11 +2,9 @@ package fr.free.nrw.commons.nearby; import android.content.Context; - import android.content.DialogInterface; import android.content.Intent; import android.location.LocationManager; - import android.net.Uri; import android.os.AsyncTask; import android.os.Bundle; @@ -20,22 +18,20 @@ import android.view.View; import android.widget.ProgressBar; import android.widget.Toast; -import butterknife.BindView; -import butterknife.ButterKnife; - import com.google.gson.Gson; import com.google.gson.GsonBuilder; +import java.util.List; + +import butterknife.BindView; +import butterknife.ButterKnife; +import fr.free.nrw.commons.R; import fr.free.nrw.commons.location.LatLng; import fr.free.nrw.commons.location.LocationServiceManager; import fr.free.nrw.commons.theme.BaseActivity; import fr.free.nrw.commons.utils.UriSerializer; - -import fr.free.nrw.commons.R; import timber.log.Timber; -import java.util.List; - public class NearbyActivity extends BaseActivity { @BindView(R.id.progressBar) ProgressBar progressBar; @@ -43,9 +39,6 @@ public class NearbyActivity extends BaseActivity { private LocationServiceManager locationManager; private LatLng curLatLang; - private Gson gson; - private String gsonPlaceList; - private String gsonCurLatLng; private Bundle bundle; private NearbyAsyncTask nearbyAsyncTask; @@ -201,11 +194,11 @@ public class NearbyActivity extends BaseActivity { return; } - gson = new GsonBuilder() + Gson gson = new GsonBuilder() .registerTypeAdapter(Uri.class, new UriSerializer()) .create(); - gsonPlaceList = gson.toJson(placeList); - gsonCurLatLng = gson.toJson(curLatLang); + String gsonPlaceList = gson.toJson(placeList); + String gsonCurLatLng = gson.toJson(curLatLang); if (placeList.size() == 0) { int duration = Toast.LENGTH_SHORT; diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyListFragment.java b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyListFragment.java index 048f1d450..bc9e22a3f 100644 --- a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyListFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyListFragment.java @@ -1,6 +1,5 @@ package fr.free.nrw.commons.nearby; -import android.content.Intent; import android.net.Uri; import android.os.Bundle; import android.support.v4.app.ListFragment; @@ -9,28 +8,23 @@ import android.view.View; import android.view.ViewGroup; import android.widget.ListView; -import butterknife.BindView; -import butterknife.ButterKnife; -import butterknife.OnItemClick; - import com.google.gson.Gson; import com.google.gson.GsonBuilder; import com.google.gson.reflect.TypeToken; -import fr.free.nrw.commons.R; -import fr.free.nrw.commons.location.LatLng; -import fr.free.nrw.commons.utils.UriDeserializer; - import java.lang.reflect.Type; import java.util.List; - +import butterknife.BindView; +import butterknife.ButterKnife; +import butterknife.OnItemClick; +import fr.free.nrw.commons.R; +import fr.free.nrw.commons.location.LatLng; +import fr.free.nrw.commons.utils.UriDeserializer; import timber.log.Timber; public class NearbyListFragment extends ListFragment { - private Gson gson; private List placeList; - private LatLng curLatLng; @BindView(R.id.listView) ListView listview; @@ -64,7 +58,7 @@ public class NearbyListFragment extends ListFragment { // Check that this is the first time view is created, // to avoid double list when screen orientation changed Bundle bundle = this.getArguments(); - gson = new GsonBuilder() + Gson gson = new GsonBuilder() .registerTypeAdapter(Uri.class, new UriDeserializer()) .create(); if (bundle != null) { @@ -73,7 +67,7 @@ public class NearbyListFragment extends ListFragment { Type listType = new TypeToken>() {}.getType(); placeList = gson.fromJson(gsonPlaceList, listType); Type curLatLngType = new TypeToken() {}.getType(); - curLatLng = gson.fromJson(gsonLatLng, curLatLngType); + LatLng curLatLng = gson.fromJson(gsonLatLng, curLatLngType); placeList = NearbyController.loadAttractionsFromLocationToPlaces(curLatLng, placeList); } if (savedInstanceState == null) { diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyMapFragment.java b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyMapFragment.java index b58fa8d5b..b80d16313 100644 --- a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyMapFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyMapFragment.java @@ -31,8 +31,6 @@ import fr.free.nrw.commons.utils.UriDeserializer; public class NearbyMapFragment extends android.support.v4.app.Fragment { private MapView mapView; - private Gson gson; - private List placeList; private List baseMarkerOptionses; private fr.free.nrw.commons.location.LatLng curLatLng; @@ -44,14 +42,14 @@ public class NearbyMapFragment extends android.support.v4.app.Fragment { public void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); Bundle bundle = this.getArguments(); - gson = new GsonBuilder() + Gson gson = new GsonBuilder() .registerTypeAdapter(Uri.class, new UriDeserializer()) .create(); if (bundle != null) { String gsonPlaceList = bundle.getString("PlaceList"); String gsonLatLng = bundle.getString("CurLatLng"); Type listType = new TypeToken>() {}.getType(); - placeList = gson.fromJson(gsonPlaceList, listType); + List placeList = gson.fromJson(gsonPlaceList, listType); Type curLatLngType = new TypeToken() {}.getType(); curLatLng = gson.fromJson(gsonLatLng, curLatLngType); baseMarkerOptionses = NearbyController diff --git a/app/src/main/java/fr/free/nrw/commons/upload/GPSExtractor.java b/app/src/main/java/fr/free/nrw/commons/upload/GPSExtractor.java index e861a1803..6d1a2ac95 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/GPSExtractor.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/GPSExtractor.java @@ -30,8 +30,7 @@ public class GPSExtractor { public boolean imageCoordsExists; private MyLocationListener myLocationListener; private LocationManager locationManager; - private String provider; - private Criteria criteria; + public GPSExtractor(String filePath, Context context){ this.filePath = filePath; @@ -54,8 +53,8 @@ public class GPSExtractor { */ protected void registerLocationManager() { locationManager = (LocationManager) context.getSystemService(Context.LOCATION_SERVICE); - criteria = new Criteria(); - provider = locationManager.getBestProvider(criteria, true); + Criteria criteria = new Criteria(); + String provider = locationManager.getBestProvider(criteria, true); myLocationListener = new MyLocationListener(); try { diff --git a/app/src/main/java/fr/free/nrw/commons/upload/MwVolleyApi.java b/app/src/main/java/fr/free/nrw/commons/upload/MwVolleyApi.java index 6544b4fff..c47c56805 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/MwVolleyApi.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/MwVolleyApi.java @@ -33,7 +33,6 @@ public class MwVolleyApi { private static RequestQueue REQUEST_QUEUE; private static final Gson GSON = new GsonBuilder().create(); private Context context; - private String coordsLog; protected static Set categorySet; private static List categoryList; @@ -56,7 +55,7 @@ public class MwVolleyApi { } public void request(String coords) { - coordsLog = coords; + String coordsLog = coords; String apiUrl = buildUrl(coords); Timber.d("URL: %s", apiUrl); diff --git a/app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java b/app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java index 8cc9246d2..dbf9b1013 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java @@ -47,7 +47,6 @@ public class ShareActivity implements SingleUploadFragment.OnUploadActionInitiated, CategorizationFragment.OnCategoriesSaveHandler { - private SingleUploadFragment shareView; private CategorizationFragment categorizationFragment; private CommonsApplication app; @@ -58,14 +57,12 @@ public class ShareActivity private Uri mediaUri; private Contribution contribution; - private ImageView backgroundImageView; private UploadController uploadController; private CommonsApplication cacheObj; private boolean cacheFound; private GPSExtractor imageObj; - private String filePath; private String decimalCoords; private boolean useNewPermissions = false; @@ -190,7 +187,7 @@ public class ShareActivity protected void onAuthCookieAcquired(String authCookie) { app.getApi().setAuthCookie(authCookie); - shareView = (SingleUploadFragment) getSupportFragmentManager().findFragmentByTag("shareView"); + SingleUploadFragment shareView = (SingleUploadFragment) getSupportFragmentManager().findFragmentByTag("shareView"); categorizationFragment = (CategorizationFragment) getSupportFragmentManager().findFragmentByTag("categorization"); if(shareView == null && categorizationFragment == null) { shareView = new SingleUploadFragment(); @@ -216,7 +213,7 @@ public class ShareActivity setContentView(R.layout.activity_share); app = (CommonsApplication)this.getApplicationContext(); - backgroundImageView = (ImageView)findViewById(R.id.backgroundImage); + ImageView backgroundImageView = (ImageView)findViewById(R.id.backgroundImage); //Receive intent from ContributionController.java when user selects picture to upload Intent intent = getIntent(); @@ -370,7 +367,7 @@ public class ShareActivity * @param gpsEnabled */ public void getFileMetadata(boolean gpsEnabled) { - filePath = FileUtils.getPath(this, mediaUri); + String filePath = FileUtils.getPath(this, mediaUri); Timber.d("Filepath: %s", filePath); Timber.d("Calling GPSExtractor"); if(imageObj == null) {