mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 21:03:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Simplify peer review button text (#3376) (#4303)

Browse source 
* Simplify peer review button text (#3376)

The lengthy button text was not showing correctly, discussions concluded
that the button texts could be simplified to just "yes" or "no". To ensure
code read-ability, the buttons were renamed. Also made slight code style
adjustments to ReviewImageFragment.java and fragment_review_image.md.

Bug: #3376

* Remove string translate file changes from patch
This commit is contained in:
Gabriel Lee 2021-03-24 09:38:53 +00:00 • committed by GitHub
parent 0857eae082
commit 7a04a2bf9c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 35 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

29
app/src/main/res/layout/fragment_review_image.xml
View file

@ -50,6 +50,20 @@
android:padding="@dimen/miniscule_margin"
android:weightSum="2">
<Button
android:id="@+id/button_no"
android:layout_width="@dimen/dimen_0"
android:layout_height="@dimen/fragment_height"
android:layout_weight="1"
android:layout_margin="@dimen/activity_margin_horizontal"
android:background="@android:color/transparent"
android:text="@string/no"
android:enabled="false"
android:alpha="0.5"
android:textAllCaps="true"
android:textAlignment="center"
android:textColor="@color/no_button_color"/>
<Button
android:id="@+id/button_yes"
android:layout_width="@dimen/dimen_0"
@ -64,21 +78,6 @@
android:textAlignment="center"
android:textColor="@color/yes_button_color"/>
<Button
android:textAllCaps="true"
android:id="@+id/button_no"
android:layout_width="@dimen/dimen_0"
android:layout_height="@dimen/fragment_height"
android:layout_weight="1"
android:enabled="false"
android:alpha="0.5"
android:layout_margin="@dimen/activity_margin_horizontal"
android:background="@android:color/transparent"
android:text="@string/no"
android:textAlignment="center"
android:textColor="@color/no_button_color"
/>
</LinearLayout>
</RelativeLayout>