From 78ba373c809cb4073a4ca8326389fd0301d27677 Mon Sep 17 00:00:00 2001 From: YuviPanda Date: Wed, 27 Feb 2013 05:43:06 +0530 Subject: [PATCH] Do not enable 'Login' button if either password or username is empty --- .../java/org/wikimedia/commons/auth/LoginActivity.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/commons/src/main/java/org/wikimedia/commons/auth/LoginActivity.java b/commons/src/main/java/org/wikimedia/commons/auth/LoginActivity.java index de176fc7f..e03e37132 100644 --- a/commons/src/main/java/org/wikimedia/commons/auth/LoginActivity.java +++ b/commons/src/main/java/org/wikimedia/commons/auth/LoginActivity.java @@ -140,19 +140,22 @@ public class LoginActivity extends AccountAuthenticatorActivity { passwordEdit = (EditText) findViewById(R.id.loginPassword); final Activity that = this; - usernameEdit.addTextChangedListener(new TextWatcher() { + TextWatcher loginEnabler = new TextWatcher() { public void beforeTextChanged(CharSequence charSequence, int start, int count, int after) { } public void onTextChanged(CharSequence charSequence, int start, int count, int after) { } public void afterTextChanged(Editable editable) { - if(usernameEdit.getText().length() != 0) { + if(usernameEdit.getText().length() != 0 && passwordEdit.getText().length() != 0) { loginButton.setEnabled(true); } else { loginButton.setEnabled(false); } } - }); + }; + + usernameEdit.addTextChangedListener(loginEnabler); + passwordEdit.addTextChangedListener(loginEnabler); loginButton.setOnClickListener(new View.OnClickListener() { @Override