mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 12:53:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

fixed the contribution crash on scroll (#4128)

Browse source 
* fixed the contribution crash on scroll

* Investigation

Just to get the Log of the issue

* fixed null data causing scroll to top

* Removed unneeded log import.
This commit is contained in:
Aditya-Srivastav 2021-01-01 20:40:10 +05:30 • committed by GitHub
parent e1be458821
commit 7730112807
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/src/main/java/fr/free/nrw/commons/contributions/ContributionViewHolder.java
View file

@ -64,6 +64,12 @@ public class ContributionViewHolder extends RecyclerView.ViewHolder {
} }
public void init(final int position, final Contribution contribution) { public void init(final int position, final Contribution contribution) {
//handling crashes when the contribution is null.
if( null == contribution) {
return;
}
this.contribution = contribution; this.contribution = contribution;
this.position = position; this.position = position;
titleView.setText(contribution.getMedia().getMostRelevantCaption()); titleView.setText(contribution.getMedia().getMostRelevantCaption());

2
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java
View file

@ -150,9 +150,11 @@ public class ContributionsListFragment extends CommonsDaggerSupportFragment impl
public void onItemRangeInserted(int positionStart, int itemCount) { public void onItemRangeInserted(int positionStart, int itemCount) {
super.onItemRangeInserted(positionStart, itemCount); super.onItemRangeInserted(positionStart, itemCount);
if (itemCount > 0 && positionStart == 0) { if (itemCount > 0 && positionStart == 0) {
if(adapter.getContributionForPosition(positionStart)!=null) {
rvContributionsList.scrollToPosition(0);//Newly upload items are always added to the top rvContributionsList.scrollToPosition(0);//Newly upload items are always added to the top
} }
} }
}
}); });
} }