mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 12:23:58 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix lint warning about Timber (#6521)

Browse source 
Change trivial string formatting and function calls
for Timber logging.

This resolves all the lint warnings in the
Android/Lint/Correctness/Messages group.
This commit is contained in:
Amir E. Aharoni 2025-10-18 00:45:35 -04:00 • committed by GitHub
parent 29b6d0f8fe
commit 717a855149
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.kt
View file

@ -324,7 +324,7 @@ after opening the app.
) )
.subscribeOn(Schedulers.io()) .subscribeOn(Schedulers.io())
.blockingGet() .blockingGet()
Timber.d("Resuming " + stuckUploads.size + " uploads...") Timber.d("Resuming %d uploads...", stuckUploads.size)
if (!stuckUploads.isEmpty()) { if (!stuckUploads.isEmpty()) {
for (contribution in stuckUploads) { for (contribution in stuckUploads) {
contribution.state = Contribution.STATE_QUEUED contribution.state = Contribution.STATE_QUEUED

3
app/src/main/java/fr/free/nrw/commons/profile/ProfileActivity.kt
View file

@ -27,6 +27,7 @@ import java.io.File
import java.io.FileOutputStream import java.io.FileOutputStream
import java.util.Locale import java.util.Locale
import javax.inject.Inject import javax.inject.Inject
import timber.log.Timber
/** /**
* This activity will set two tabs, achievements and * This activity will set two tabs, achievements and
@ -122,7 +123,7 @@ class ProfileActivity : BaseActivity() {
val rootView = window.decorView.findViewById<View>(android.R.id.content) val rootView = window.decorView.findViewById<View>(android.R.id.content)
val screenShot = getScreenShot(rootView) val screenShot = getScreenShot(rootView)
if (screenShot == null) { if (screenShot == null) {
Log.e("ERROR", "ScreenShot is null") Timber.e("ScreenShot is null")
return false return false
} }
showAlert(screenShot) showAlert(screenShot)

2
app/src/main/java/fr/free/nrw/commons/utils/LocationUtils.kt
View file

@ -37,7 +37,7 @@ object LocationUtils {
latLng = LatLng(latLngArray[1].trim().toDouble(), latLng = LatLng(latLngArray[1].trim().toDouble(),
latLngArray[0].trim().toDouble(), 1f) latLngArray[0].trim().toDouble(), 1f)
} catch (e: Exception) { } catch (e: Exception) {
Timber.e("Error while parsing user entered lat long: %s", e) Timber.e(e, "Error while parsing user entered lat long")
} }
return latLng return latLng