From 709a8209735581b30304eb529a17da225defa368 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Fri, 27 Sep 2013 15:17:00 -0700 Subject: [PATCH] Fix media URL generation for non-ASCII filenames Characters in the filename weren't being encoded when generating a URL, which seems to break something in the network fetching. Change-Id: I10a18d1e5e32a4806cdae03b4a510a18eba9802b --- commons/src/main/java/org/wikimedia/commons/Utils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/commons/src/main/java/org/wikimedia/commons/Utils.java b/commons/src/main/java/org/wikimedia/commons/Utils.java index f3bea5a54..49868d57d 100644 --- a/commons/src/main/java/org/wikimedia/commons/Utils.java +++ b/commons/src/main/java/org/wikimedia/commons/Utils.java @@ -38,7 +38,7 @@ public class Utils { public static String makeThumbBaseUrl(String filename) { String name = filename.replaceFirst("File:", "").replace(" ", "_"); String sha = new String(Hex.encodeHex(DigestUtils.md5(name))); - return String.format("%s/%s/%s/%s", CommonsApplication.IMAGE_URL_BASE, sha.substring(0, 1), sha.substring(0, 2), name); + return String.format("%s/%s/%s/%s", CommonsApplication.IMAGE_URL_BASE, sha.substring(0, 1), sha.substring(0, 2), urlEncode(name)); }