From 6f96e8959b38c47c4b542d4a7467fe49be932885 Mon Sep 17 00:00:00 2001 From: HNYDDDTONY-ANU <140160683+HNYDDDTONY-ANU@users.noreply.github.com> Date: Thu, 2 Nov 2023 00:25:07 +1100 Subject: [PATCH] Fixes #5344 Some categories hidden at top of Upload Wizard suggestions, need to manually scroll up (#5370) * Fix Issue #5344 * fix update Issue #5344 * Add Comment --- .../categories/UploadCategoriesFragment.java | 16 ++++++++++++++++ .../commons/upload/depicts/DepictsFragment.java | 16 +++++++++++++++- 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/fr/free/nrw/commons/upload/categories/UploadCategoriesFragment.java b/app/src/main/java/fr/free/nrw/commons/upload/categories/UploadCategoriesFragment.java index e378ef53b..f32fb286b 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/categories/UploadCategoriesFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/categories/UploadCategoriesFragment.java @@ -198,6 +198,22 @@ public class UploadCategoriesFragment extends UploadBaseFragment implements Cate } else { adapter.setItems(categories); } + adapter.notifyDataSetChanged(); + + // Nested waiting for search result data to load into the category + // list and smoothly scroll to the top of the search result list. + rvCategories.post(new Runnable() { + @Override + public void run() { + rvCategories.smoothScrollToPosition(0); + rvCategories.post(new Runnable() { + @Override + public void run() { + rvCategories.smoothScrollToPosition(0); + } + }); + } + }); } @Override diff --git a/app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsFragment.java b/app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsFragment.java index 3582f69c0..4450f67ef 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsFragment.java @@ -246,7 +246,21 @@ public class DepictsFragment extends UploadBaseFragment implements DepictsContra adapter.setItems(depictedItemList); } } - depictsRecyclerView.smoothScrollToPosition(0); + + // Nested waiting for search result data to load into the depicted item + // list and smoothly scroll to the top of the search result list. + depictsRecyclerView.post(new Runnable() { + @Override + public void run() { + depictsRecyclerView.smoothScrollToPosition(0); + depictsRecyclerView.post(new Runnable() { + @Override + public void run() { + depictsRecyclerView.smoothScrollToPosition(0); + } + }); + } + }); } /**