diff --git a/app/src/test/java/fr/free/nrw/commons/nearby/NearbyAdapterFactoryTest.java b/app/src/test/java/fr/free/nrw/commons/nearby/NearbyAdapterFactoryTest.java index 186644a26..e0c8de403 100644 --- a/app/src/test/java/fr/free/nrw/commons/nearby/NearbyAdapterFactoryTest.java +++ b/app/src/test/java/fr/free/nrw/commons/nearby/NearbyAdapterFactoryTest.java @@ -33,7 +33,8 @@ public class NearbyAdapterFactoryTest { private static final Place PLACE = new Place("name", Place.Label.AIRPORT, "desc", null, new LatLng(38.6270, -90.1994, 0), null); private static final Place UNKNOWN_PLACE = new Place("name", Place.Label.UNKNOWN, - "desc", null, new LatLng(39.7392, -104.9903, 0), null); + "?", null, new LatLng(39.7392, -104.9903, 0), null); + // ^ "?" is a special value for unknown class names from Wikidata query results private Place clickedPlace; @Test @@ -68,12 +69,13 @@ public class NearbyAdapterFactoryTest { RendererViewHolder viewHolder = renderComponent(result); + // test that the values we gave are actually rendered assertNotNull(viewHolder.itemView.findViewById(R.id.tvName)); - assertEquals("name", + assertEquals(PLACE.name, ((TextView) viewHolder.itemView.findViewById(R.id.tvName)).getText().toString()); assertNotNull(viewHolder.itemView.findViewById(R.id.tvDesc)); - assertEquals("airport", + assertEquals(PLACE.getLongDescription(), ((TextView) viewHolder.itemView.findViewById(R.id.tvDesc)).getText().toString()); assertNotNull(viewHolder.itemView.findViewById(R.id.distance)); @@ -94,7 +96,7 @@ public class NearbyAdapterFactoryTest { RendererViewHolder viewHolder = renderComponent(result); assertNotNull(viewHolder.itemView.findViewById(R.id.tvDesc)); - assertEquals("no description found", + assertEquals(RuntimeEnvironment.application.getString(R.string.no_description_found), ((TextView) viewHolder.itemView.findViewById(R.id.tvDesc)).getText().toString()); assertNotNull(viewHolder.itemView.findViewById(R.id.icon));