From 68e27d49e15630e55716758757b1e039adddb238 Mon Sep 17 00:00:00 2001
From: Ashish Kumar <ashishkumar468@gmail.com>
Date: Sun, 29 Sep 2019 15:08:46 +0530
Subject: [PATCH] Bugfix/fix upload presenter tests (#3158)

* Revert "Merge branch 'backend-overhaul' into master"

This reverts commit 0090f2425752f5f0347b658451c41223a94f697b, reversing
changes made to 9bccbfe4430d22da11e05abf0b448de5e20d070b.

* * Fixed upload presenter tests
* Deleted app/src/main/res/values-en-gb/error.xml
---
 app/src/main/res/values-en-gb/error.xml              | 10 ----------
 .../free/nrw/commons/upload/UploadPresenterTest.kt   | 12 ++++++++++++
 2 files changed, 12 insertions(+), 10 deletions(-)
 delete mode 100644 app/src/main/res/values-en-gb/error.xml

diff --git a/app/src/main/res/values-en-gb/error.xml b/app/src/main/res/values-en-gb/error.xml
deleted file mode 100644
index af6db412b..000000000
--- a/app/src/main/res/values-en-gb/error.xml
+++ /dev/null
@@ -1,10 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!-- Authors:
-* Cblair91
--->
-<resources>
-  <string name="crash_dialog_title">Commons has crashed</string>
-  <string name="crash_dialog_text">Oops. Something went wrong!</string>
-  <string name="crash_dialog_comment_prompt">Tell us what you were doing, then share it via email to us. Will help us fix it!</string>
-  <string name="crash_dialog_ok_toast">Thank you!</string>
-</resources>
diff --git a/app/src/test/kotlin/fr/free/nrw/commons/upload/UploadPresenterTest.kt b/app/src/test/kotlin/fr/free/nrw/commons/upload/UploadPresenterTest.kt
index 764181872..bef677fd5 100644
--- a/app/src/test/kotlin/fr/free/nrw/commons/upload/UploadPresenterTest.kt
+++ b/app/src/test/kotlin/fr/free/nrw/commons/upload/UploadPresenterTest.kt
@@ -50,6 +50,18 @@ class UploadPresenterTest {
         `when`(uploadableFile?.filePath).thenReturn("data://test")
     }
 
+    /**
+     * unit test case for method UploadPresenter.handleSubmit
+     */
+    @Test
+    fun handleSubmitTest() {
+        uploadPresenter?.handleSubmit()
+        verify(view)?.isLoggedIn
+        verify(view)?.showProgress(true)
+        verify(repository)?.buildContributions()
+        verify(repository)?.buildContributions()
+    }
+
     /**
      * unit test for UploadMediaPresenter.deletePictureAtIndex
      */