diff --git a/.travis.yml b/.travis.yml
index 20c5bfaee..5e76e09d9 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -19,12 +19,13 @@ android:
components:
- tools
- platform-tools
- - build-tools-26.0.2
+ - build-tools-27.0.0
- extra-google-m2repository
- extra-android-m2repository
- ${ANDROID_TARGET}
- android-25
- android-26
+ - android-27
- sys-img-${ANDROID_ABI}-${ANDROID_TARGET}
licenses:
- 'android-sdk-license-.+'
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7c77174cf..1688b3b02 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,8 @@
# Wikimedia Commons for Android
+## v2.7.2
+- Modified subtext for "automatically get current location" setting to emphasize that it will reveal user's location
+
## v2.7.1
- Fixed UI and permission issues with Nearby
- Fixed issue with My Recent Uploads being empty
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index caa02a103..37ecfca1f 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -32,3 +32,7 @@ The body should provide a meaningful commit message.
1. Write tests for your code (if possible)
1. Make sure the Wiki pages don't become stale by updating them (if needed)
+
+### Further reading
+
+* [Importance of good commit messages](https://blog.oozou.com/commit-messages-matter-60309983c227?gi=c550a10d0f67)
diff --git a/ISSUE_TEMPLATE.md b/ISSUE_TEMPLATE.md
index 691562b04..8feca4268 100644
--- a/ISSUE_TEMPLATE.md
+++ b/ISSUE_TEMPLATE.md
@@ -1,25 +1,18 @@
-_Before creating an issue, please search the existing issues to see if a similar one has already been created. You can search issues by specific labels (e.g. `label:nearby `) or just by typing keywords into the search filter._
-
**Summary:**
Summarize your issue in one sentence (what goes wrong, what did you expect to happen)
+_Before creating an issue, please search the existing issues to see if a similar one has already been created. You can search issues by specific labels (e.g. `label:nearby `) or just by typing keywords into the search filter._
+
**Steps to reproduce:**
-How can we reproduce the issue?
+How can we reproduce the issue?
+What did you expect the app to do, and what did you see instead?
**Add System logs:**
Add logcat files here (if possible).
-**Expected behavior:**
-
-What did you expect the App to do?
-
-**Observed behavior:**
-
-What did you see instead? Describe your issue in detail here.
-
**Device and Android version:**
What make and model device (e.g., Samsung J7) did you encounter this on? What Android
@@ -28,7 +21,7 @@ version (e.g., Android 4.0 Ice Cream Sandwich or Android 6.0 Marshmallow) are yo
**Commons app version:**
-You can find this information by going to the navigation drawer in the app and tapping 'About'
+You can find this information by going to the navigation drawer in the app and tapping 'About'. If you are building from our codebase instead of downloading the app, please also mention the branch and build variant (e.g. master and prodDebug).
**Screen-shots:**
diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md
index 9d7150008..37e104d14 100644
--- a/PULL_REQUEST_TEMPLATE.md
+++ b/PULL_REQUEST_TEMPLATE.md
@@ -1,3 +1,7 @@
+## Title (required)
+
+Fixes #{GitHub issue number and title (Please do not forget adding title) }
+
## Description (required)
Fixes #{GitHub issue number and title}
@@ -12,4 +16,4 @@ Tested on {API level & name of device/emulator}, with {build variant, e.g. ProdD
{Only for user interface changes, otherwise remove this section. See [how to take a screenshot](https://android.stackexchange.com/questions/1759/how-to-take-a-screenshot-with-an-android-device)}
-_Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request._
+_Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request._
\ No newline at end of file
diff --git a/app/build.gradle b/app/build.gradle
index 5d37f8f54..ea06c5c43 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -7,11 +7,12 @@ apply from: 'quality.gradle'
apply plugin: 'com.getkeepsafe.dexcount'
dependencies {
+ implementation 'com.squareup.picasso:picasso:2.71828'
+ implementation 'com.prof.rssparser:rssparser:1.1'
implementation 'com.github.nicolas-raoul:Quadtree:ac16ea8035bf07'
implementation 'fr.avianey.com.viewpagerindicator:library:2.4.1.1@aar'
implementation 'in.yuvi:http.fluent:1.3'
implementation 'com.github.chrisbanes:PhotoView:2.0.0'
- implementation 'com.android.volley:volley:1.0.0'
implementation 'ch.acra:acra:4.9.2'
implementation 'org.mediawiki:api:1.3'
implementation 'commons-codec:commons-codec:1.10'
@@ -20,59 +21,57 @@ dependencies {
implementation 'com.jakewharton.timber:timber:4.5.1'
implementation 'info.debatty:java-string-similarity:0.24'
implementation 'com.borjabravo:readmoretextview:2.1.0'
- implementation 'com.android.support.constraint:constraint-layout:1.0.2'
- implementation ('com.mapbox.mapboxsdk:mapbox-android-sdk:5.4.1@aar'){
- transitive=true
+
+ implementation 'com.android.support.constraint:constraint-layout:1.1.0'
+ implementation('com.mapbox.mapboxsdk:mapbox-android-sdk:5.5.0@aar') {
+ transitive = true
}
-
- implementation "com.github.deano2390:MaterialShowcaseView:1.2.0"
-
+ implementation 'com.github.deano2390:MaterialShowcaseView:1.2.0'
+ //noinspection GradleCompatible
implementation "com.android.support:support-v4:$SUPPORT_LIB_VERSION"
implementation "com.android.support:appcompat-v7:$SUPPORT_LIB_VERSION"
implementation "com.android.support:design:$SUPPORT_LIB_VERSION"
implementation "com.android.support:customtabs:$SUPPORT_LIB_VERSION"
-
implementation "com.android.support:cardview-v7:$SUPPORT_LIB_VERSION"
-
implementation "com.jakewharton:butterknife:$BUTTERKNIFE_VERSION"
kapt "com.jakewharton:butterknife-compiler:$BUTTERKNIFE_VERSION"
-
implementation 'com.squareup.okhttp3:okhttp:3.9.1'
implementation 'com.squareup.okio:okio:1.13.0'
-
implementation 'io.reactivex.rxjava2:rxandroid:2.0.1'
// Because RxAndroid releases are few and far between, it is recommended you also
// explicitly depend on RxJava's latest version for bug fixes and new features.
implementation 'com.android.support:multidex:1.0.3'
-
implementation 'io.reactivex.rxjava2:rxjava:2.1.2'
implementation 'com.jakewharton.rxbinding2:rxbinding:2.0.0'
implementation 'com.jakewharton.rxbinding2:rxbinding-support-v4:2.0.0'
implementation 'com.jakewharton.rxbinding2:rxbinding-appcompat-v7:2.0.0'
implementation 'com.jakewharton.rxbinding2:rxbinding-design:2.0.0'
-
implementation 'org.jsoup:jsoup:1.11.3'
-
implementation 'com.facebook.fresco:fresco:1.5.0'
implementation 'com.facebook.stetho:stetho:1.5.0'
-
implementation "com.google.dagger:dagger:$DAGGER_VERSION"
implementation "com.google.dagger:dagger-android-support:$DAGGER_VERSION"
kapt "com.google.dagger:dagger-android-processor:$DAGGER_VERSION"
kapt "com.google.dagger:dagger-compiler:$DAGGER_VERSION"
-
- testImplementation "org.robolectric:multidex:3.4.2"
+ testImplementation 'org.robolectric:multidex:3.4.2'
testImplementation "org.jetbrains.kotlin:kotlin-stdlib-jre7:$kotlin_version"
testImplementation "org.jetbrains.kotlin:kotlin-reflect:$kotlin_version"
testImplementation 'junit:junit:4.12'
testImplementation 'org.robolectric:robolectric:3.7.1'
testImplementation 'com.nhaarman:mockito-kotlin:1.5.0'
testImplementation 'com.squareup.okhttp3:mockwebserver:3.8.1'
+ implementation 'com.dinuscxj:circleprogressbar:1.1.1'
+
+ implementation 'com.caverock:androidsvg:1.2.1'
+ implementation 'com.github.bumptech.glide:glide:4.7.1'
+ kapt 'com.github.bumptech.glide:compiler:4.7.1'
androidTestImplementation "org.jetbrains.kotlin:kotlin-stdlib-jre7:$kotlin_version"
androidTestImplementation 'com.squareup.okhttp3:mockwebserver:3.8.1'
androidTestImplementation "com.android.support:support-annotations:$SUPPORT_LIB_VERSION"
- androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2-alpha1'
+ androidTestImplementation 'com.android.support.test:rules:1.0.2'
+ androidTestImplementation 'com.android.support.test:runner:1.0.2'
+ androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'
debugImplementation "com.squareup.leakcanary:leakcanary-android:$LEAK_CANARY"
releaseImplementation "com.squareup.leakcanary:leakcanary-android-no-op:$LEAK_CANARY"
@@ -87,8 +86,8 @@ android {
defaultConfig {
applicationId 'fr.free.nrw.commons'
- versionCode 84
- versionName '2.7.1'
+ versionCode 85
+ versionName '2.7.2'
setProperty("archivesBaseName", "app-commons-v$versionName-" + getBranchName())
minSdkVersion project.minSdkVersion
@@ -117,7 +116,7 @@ android {
buildTypes {
release {
minifyEnabled false // See https://stackoverflow.com/questions/40232404/google-play-apk-and-android-studio-apk-usb-debug-behaving-differently - proguard.cfg modification alone insufficient.
- proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.txt'
+ proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.txt', 'proguard-glide.txt'
}
debug {
applicationIdSuffix ".debug"
@@ -129,7 +128,9 @@ android {
flavorDimensions 'tier'
productFlavors {
prod {
+ buildConfigField "String", "WIKIMEDIA_API_POTD", "\"https://commons.wikimedia.org/w/api.php?action=featuredfeed&feed=potd&feedformat=rss&language=en\""
buildConfigField "String", "WIKIMEDIA_API_HOST", "\"https://commons.wikimedia.org/w/api.php\""
+ buildConfigField "String", "WIKIDATA_API_HOST", "\"https://www.wikidata.org/w/api.php\""
buildConfigField "String", "WIKIMEDIA_FORGE_API_HOST", "\"https://tools.wmflabs.org/\""
buildConfigField "String", "IMAGE_URL_BASE", "\"https://upload.wikimedia.org/wikipedia/commons\""
buildConfigField "String", "HOME_URL", "\"https://commons.wikimedia.org/wiki/\""
@@ -145,7 +146,9 @@ android {
beta {
// What values do we need to hit the BETA versions of the site / api ?
+ buildConfigField "String", "WIKIMEDIA_API_POTD", "\"https://commons.wikimedia.org/w/api.php?action=featuredfeed&feed=potd&feedformat=rss&language=en\""
buildConfigField "String", "WIKIMEDIA_API_HOST", "\"https://commons.wikimedia.beta.wmflabs.org/w/api.php\""
+ buildConfigField "String", "WIKIDATA_API_HOST", "\"https://www.wikidata.org/w/api.php\""
buildConfigField "String", "WIKIMEDIA_FORGE_API_HOST", "\"https://tools.wmflabs.org/\""
buildConfigField "String", "IMAGE_URL_BASE", "\"https://upload.beta.wmflabs.org/wikipedia/commons\""
buildConfigField "String", "HOME_URL", "\"https://commons.wikimedia.beta.wmflabs.org/wiki/\""
diff --git a/app/libs/java-json.jar b/app/libs/java-json.jar
new file mode 100644
index 000000000..2f211e366
Binary files /dev/null and b/app/libs/java-json.jar differ
diff --git a/app/proguard-glide.txt b/app/proguard-glide.txt
new file mode 100644
index 000000000..ef3437660
--- /dev/null
+++ b/app/proguard-glide.txt
@@ -0,0 +1,9 @@
+-keep public class * implements com.bumptech.glide.module.GlideModule
+-keep public class * extends com.bumptech.glide.module.AppGlideModule
+-keep public enum com.bumptech.glide.load.ImageHeaderParser$** {
+ **[] $VALUES;
+ public *;
+}
+
+# for DexGuard only
+-keepresourcexmlelements manifest/application/meta-data@value=GlideModule
\ No newline at end of file
diff --git a/app/proguard-rules.txt b/app/proguard-rules.txt
index bbf3a3f0d..39b618718 100644
--- a/app/proguard-rules.txt
+++ b/app/proguard-rules.txt
@@ -1,5 +1,4 @@
-dontobfuscate
-keep class org.apache.http.** { *; }
-dontwarn org.apache.http.**
--keep class fr.free.nrw.commons.upload.MwVolleyApi$Page {*;}
-keep class android.support.v7.widget.ShareActionProvider { *; }
\ No newline at end of file
diff --git a/app/quality.gradle b/app/quality.gradle
index 7ea20916a..1afdf0d68 100644
--- a/app/quality.gradle
+++ b/app/quality.gradle
@@ -18,7 +18,7 @@ task checkstyle(type: Checkstyle) {
reports {
html {
enabled true
- destination "${project.buildDir}/reports/checkstyle/checkstyle.html"
+ destination file("${project.buildDir}/reports/checkstyle/checkstyle.html")
}
}
}
@@ -36,10 +36,10 @@ task pmd(type: Pmd) {
xml.enabled = false
html.enabled = true
xml {
- destination "${project.buildDir}/reports/pmd/pmd.xml"
+ destination file("${project.buildDir}/reports/pmd/pmd.xml")
}
html {
- destination "${project.buildDir}/reports/pmd/pmd.html"
+ destination file("${project.buildDir}/reports/pmd/pmd.html")
}
}
}
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 17f6770d2..3665042ac 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -1,3 +1,4 @@
+
@@ -15,6 +16,7 @@
+
@@ -26,10 +28,10 @@
android:theme="@style/LightAppTheme"
android:supportsRtl="true" >
+ android:theme="@android:style/Theme.Dialog"
+ android:launchMode="singleInstance"
+ android:excludeFromRecents="true"
+ android:finishOnTaskLaunch="true" />
@@ -44,7 +46,7 @@
android:name=".upload.ShareActivity"
android:icon="@drawable/ic_launcher"
android:label="@string/app_name">
-
+
@@ -56,7 +58,7 @@
android:name=".upload.MultipleShareActivity"
android:icon="@drawable/ic_launcher"
android:label="@string/app_name">
-
+
@@ -96,8 +98,22 @@
android:label="@string/title_activity_featured_images"
android:parentActivityName=".contributions.ContributionsActivity" />
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-
+
\ No newline at end of file
diff --git a/app/src/main/java/fr/free/nrw/commons/AboutActivity.java b/app/src/main/java/fr/free/nrw/commons/AboutActivity.java
index 65cba7531..c8941dcd8 100644
--- a/app/src/main/java/fr/free/nrw/commons/AboutActivity.java
+++ b/app/src/main/java/fr/free/nrw/commons/AboutActivity.java
@@ -9,9 +9,6 @@ import android.os.Bundle;
import android.text.Html;
import android.text.SpannableString;
import android.text.style.UnderlineSpan;
-import android.util.Log;
-import android.support.customtabs.CustomTabsIntent;
-import android.support.v4.content.ContextCompat;
import android.view.Menu;
import android.view.MenuInflater;
import android.view.MenuItem;
@@ -20,7 +17,6 @@ import android.widget.ArrayAdapter;
import android.widget.LinearLayout;
import android.widget.Spinner;
import android.widget.TextView;
-import android.widget.Toast;
import butterknife.BindView;
import butterknife.ButterKnife;
@@ -28,8 +24,6 @@ import butterknife.OnClick;
import fr.free.nrw.commons.theme.NavigationBaseActivity;
import fr.free.nrw.commons.ui.widget.HtmlTextView;
-import static android.widget.Toast.LENGTH_SHORT;
-
/**
* Represents about screen of this app
*/
diff --git a/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java b/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java
index 1b5a659c3..d29c22e76 100644
--- a/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java
+++ b/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java
@@ -1,6 +1,5 @@
package fr.free.nrw.commons;
-import android.app.Application;
import android.content.Context;
import android.content.SharedPreferences;
import android.database.sqlite.SQLiteDatabase;
@@ -27,7 +26,7 @@ import fr.free.nrw.commons.contributions.ContributionDao;
import fr.free.nrw.commons.data.DBOpenHelper;
import fr.free.nrw.commons.di.ApplicationlessInjection;
import fr.free.nrw.commons.modifications.ModifierSequenceDao;
-import fr.free.nrw.commons.utils.FileUtils;
+import fr.free.nrw.commons.upload.FileUtils;
import io.reactivex.android.schedulers.AndroidSchedulers;
import io.reactivex.schedulers.Schedulers;
import timber.log.Timber;
diff --git a/app/src/main/java/fr/free/nrw/commons/Media.java b/app/src/main/java/fr/free/nrw/commons/Media.java
index 5f6a498ea..04f097d08 100644
--- a/app/src/main/java/fr/free/nrw/commons/Media.java
+++ b/app/src/main/java/fr/free/nrw/commons/Media.java
@@ -3,13 +3,17 @@ package fr.free.nrw.commons;
import android.net.Uri;
import android.os.Parcel;
import android.os.Parcelable;
+import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import java.util.ArrayList;
+import java.util.Collection;
import java.util.Date;
import java.util.HashMap;
+import java.util.Iterator;
import java.util.List;
import java.util.Map;
+import java.util.Set;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
@@ -356,12 +360,8 @@ public class Media implements Parcelable {
* @param descriptions Media descriptions
*/
void setDescriptions(Map descriptions) {
- for (String key : this.descriptions.keySet()) {
- this.descriptions.remove(key);
- }
- for (String key : descriptions.keySet()) {
- this.descriptions.put(key, descriptions.get(key));
- }
+ this.descriptions.clear();
+ this.descriptions.putAll(descriptions);
}
/**
diff --git a/app/src/main/java/fr/free/nrw/commons/MediaWikiImageView.java b/app/src/main/java/fr/free/nrw/commons/MediaWikiImageView.java
index 35d197782..5e89e19a5 100644
--- a/app/src/main/java/fr/free/nrw/commons/MediaWikiImageView.java
+++ b/app/src/main/java/fr/free/nrw/commons/MediaWikiImageView.java
@@ -51,10 +51,16 @@ public class MediaWikiImageView extends SimpleDraweeView {
return;
}
- if (thumbnailUrlCache.get(media.getFilename()) != null) {
- setImageUrl(thumbnailUrlCache.get(media.getFilename()));
- } else {
- setImageUrl(null);
+ if(media.getFilename() != null) {
+ if (thumbnailUrlCache.get(media.getFilename()) != null) {
+ setImageUrl(thumbnailUrlCache.get(media.getFilename()));
+ } else {
+ setImageUrl(null);
+ currentThumbnailTask = new ThumbnailFetchTask(media, mwApi);
+ currentThumbnailTask.execute(media.getFilename());
+ }
+ } else { // local image
+ setImageUrl(media.getLocalUri().toString());
currentThumbnailTask = new ThumbnailFetchTask(media, mwApi);
currentThumbnailTask.execute(media.getFilename());
}
diff --git a/app/src/main/java/fr/free/nrw/commons/Utils.java b/app/src/main/java/fr/free/nrw/commons/Utils.java
index 91c23ce26..4e4b46b01 100644
--- a/app/src/main/java/fr/free/nrw/commons/Utils.java
+++ b/app/src/main/java/fr/free/nrw/commons/Utils.java
@@ -2,11 +2,13 @@ package fr.free.nrw.commons;
import android.content.Context;
import android.content.Intent;
+import android.graphics.Bitmap;
import android.net.Uri;
import android.preference.PreferenceManager;
import android.support.annotation.NonNull;
import android.support.customtabs.CustomTabsIntent;
import android.support.v4.content.ContextCompat;
+import android.view.View;
import android.widget.Toast;
import org.apache.commons.codec.binary.Hex;
@@ -76,7 +78,11 @@ public class Utils {
* @return string with capitalized first character
*/
public static String capitalize(String string) {
- return string.substring(0, 1).toUpperCase(Locale.getDefault()) + string.substring(1);
+ if(string.length() > 0) {
+ return string.substring(0, 1).toUpperCase(Locale.getDefault()) + string.substring(1);
+ } else {
+ return string;
+ }
}
/**
@@ -146,7 +152,7 @@ public class Utils {
StringBuilder stringBuilder = new StringBuilder();
try {
- String[] command = new String[] {"logcat","-d","-v","threadtime"};
+ String[] command = new String[]{"logcat","-d","-v","threadtime"};
Process process = Runtime.getRuntime().exec(command);
@@ -178,6 +184,7 @@ public class Utils {
}
public static void handleWebUrl(Context context, Uri url) {
+ Timber.d("Launching web url %s", url.toString());
Intent browserIntent = new Intent(Intent.ACTION_VIEW, url);
if (browserIntent.resolveActivity(context.getPackageManager()) == null) {
Toast toast = Toast.makeText(context, context.getString(R.string.no_web_browser), LENGTH_SHORT);
@@ -194,4 +201,18 @@ public class Utils {
customTabsIntent.launchUrl(context, url);
}
+ /**
+ * To take screenshot of the screen and return it in Bitmap format
+ *
+ * @param view
+ * @return
+ */
+ public static Bitmap getScreenShot(View view) {
+ View screenView = view.getRootView();
+ screenView.setDrawingCacheEnabled(true);
+ Bitmap bitmap = Bitmap.createBitmap(screenView.getDrawingCache());
+ screenView.setDrawingCacheEnabled(false);
+ return bitmap;
+ }
+
}
diff --git a/app/src/main/java/fr/free/nrw/commons/achievements/Achievements.java b/app/src/main/java/fr/free/nrw/commons/achievements/Achievements.java
new file mode 100644
index 000000000..5fac8da9a
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/achievements/Achievements.java
@@ -0,0 +1,205 @@
+package fr.free.nrw.commons.achievements;
+
+import android.util.Log;
+
+/**
+ * represnts Achievements class ans stores all the parameters
+ */
+public class Achievements {
+ private int uniqueUsedImages;
+ private int articlesUsingImages;
+ private int thanksReceived;
+ private int imagesEditedBySomeoneElse;
+ private int featuredImages;
+ private int imagesUploaded;
+ private int revertCount;
+
+ public Achievements(){
+
+ }
+
+ /**
+ * constructor for achievements class to set its data members
+ * @param uniqueUsedImages
+ * @param articlesUsingImages
+ * @param thanksReceived
+ * @param imagesEditedBySomeoneElse
+ * @param featuredImages
+ * @param imagesUploaded
+ * @param revertCount
+ */
+ public Achievements(int uniqueUsedImages,
+ int articlesUsingImages,
+ int thanksReceived,
+ int imagesEditedBySomeoneElse,
+ int featuredImages,
+ int imagesUploaded,
+ int revertCount) {
+ this.uniqueUsedImages = uniqueUsedImages;
+ this.articlesUsingImages = articlesUsingImages;
+ this.thanksReceived = thanksReceived;
+ this.imagesEditedBySomeoneElse = imagesEditedBySomeoneElse;
+ this.featuredImages = featuredImages;
+ this.imagesUploaded = imagesUploaded;
+ this.revertCount = revertCount;
+ }
+
+ /**
+ * Builder class for Achievements class
+ */
+ public class AchievementsBuilder {
+ private int nestedUniqueUsedImages;
+ private int nestedArticlesUsingImages;
+ private int nestedThanksReceived;
+ private int nestedImagesEditedBySomeoneElse;
+ private int nestedFeaturedImages;
+ private int nestedImagesUploaded;
+ private int nestedRevertCount;
+
+ public AchievementsBuilder setUniqueUsedImages(int uniqueUsedImages) {
+ this.nestedUniqueUsedImages = uniqueUsedImages;
+ return this;
+ }
+
+ public AchievementsBuilder setArticlesUsingImages(int articlesUsingImages) {
+ this.nestedArticlesUsingImages = articlesUsingImages;
+ return this;
+ }
+
+ public AchievementsBuilder setThanksReceived(int thanksReceived) {
+ this.nestedThanksReceived = thanksReceived;
+ return this;
+ }
+
+ public AchievementsBuilder setImagesEditedBySomeoneElse(int imagesEditedBySomeoneElse) {
+ this.nestedImagesEditedBySomeoneElse = imagesEditedBySomeoneElse;
+ return this;
+ }
+
+ public AchievementsBuilder setFeaturedImages(int featuredImages) {
+ this.nestedFeaturedImages = featuredImages;
+ return this;
+ }
+
+ public AchievementsBuilder setImagesUploaded(int imagesUploaded) {
+ this.nestedImagesUploaded = imagesUploaded;
+ return this;
+ }
+
+ public AchievementsBuilder setRevertCount( int revertCount){
+ this.nestedRevertCount = revertCount;
+ return this;
+ }
+
+ public Achievements createAchievements(){
+ return new Achievements(nestedUniqueUsedImages,
+ nestedArticlesUsingImages,
+ nestedThanksReceived,
+ nestedImagesEditedBySomeoneElse,
+ nestedFeaturedImages,
+ nestedImagesUploaded,
+ nestedRevertCount);
+ }
+
+ }
+
+ /**
+ * getter function to get count of images uploaded
+ * @return
+ */
+ public int getImagesUploaded() {
+ return imagesUploaded;
+ }
+
+ /**
+ * getter function to get count of featured images
+ * @return
+ */
+ public int getFeaturedImages() {
+ return featuredImages;
+ }
+
+ /**
+ * getter function to get count of thanks received
+ * @return
+ */
+ public int getThanksReceived() {
+ return thanksReceived;
+ }
+
+ /**
+ * getter function to get count of unique images used by wiki
+ * @return
+ */
+ public int getUniqueUsedImages() {
+ return uniqueUsedImages;
+ }
+
+ /**
+ * setter function to count of images uploaded
+ * @param imagesUploaded
+ */
+ public void setImagesUploaded(int imagesUploaded) {
+ this.imagesUploaded = imagesUploaded;
+ }
+
+ /**
+ * setter function to set count of featured images
+ * @param featuredImages
+ */
+ public void setFeaturedImages(int featuredImages) {
+ this.featuredImages = featuredImages;
+ }
+
+ /**
+ * setter function to set the count of images edited by someone
+ * @param imagesEditedBySomeoneElse
+ */
+ public void setImagesEditedBySomeoneElse(int imagesEditedBySomeoneElse) {
+ this.imagesEditedBySomeoneElse = imagesEditedBySomeoneElse;
+ }
+
+ /**
+ * setter function to set count of thanks received
+ * @param thanksReceived
+ */
+ public void setThanksReceived(int thanksReceived) {
+ this.thanksReceived = thanksReceived;
+ }
+
+ /**
+ * setter function to count of articles using images uploaded
+ * @param articlesUsingImages
+ */
+ public void setArticlesUsingImages(int articlesUsingImages) {
+ this.articlesUsingImages = articlesUsingImages;
+ }
+
+ /**
+ * setter function to set count of uniques images used by wiki
+ * @param uniqueUsedImages
+ */
+ public void setUniqueUsedImages(int uniqueUsedImages) {
+ this.uniqueUsedImages = uniqueUsedImages;
+ }
+
+ /**
+ * to set count of images reverted
+ * @param revertCount
+ */
+ public void setRevertCount(int revertCount) {
+ this.revertCount = revertCount;
+ }
+
+ /**
+ * used to calculate the percentages of images that haven't been reverted
+ * @return
+ */
+ public int getNotRevertPercentage(){
+ try {
+ return ((imagesUploaded - revertCount) * 100)/imagesUploaded;
+ } catch (ArithmeticException divideByZero ){
+ return 100;
+ }
+ }
+}
diff --git a/app/src/main/java/fr/free/nrw/commons/achievements/AchievementsActivity.java b/app/src/main/java/fr/free/nrw/commons/achievements/AchievementsActivity.java
new file mode 100644
index 000000000..905d0dfbd
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/achievements/AchievementsActivity.java
@@ -0,0 +1,458 @@
+package fr.free.nrw.commons.achievements;
+
+import android.accounts.Account;
+import android.annotation.SuppressLint;
+import android.annotation.TargetApi;
+import android.content.Context;
+import android.content.DialogInterface;
+import android.content.Intent;
+import android.graphics.Bitmap;
+import android.graphics.BitmapFactory;
+import android.graphics.Canvas;
+import android.graphics.Color;
+import android.graphics.Paint;
+import android.graphics.Rect;
+import android.graphics.drawable.BitmapDrawable;
+import android.graphics.drawable.Drawable;
+import android.net.Uri;
+import android.os.Bundle;
+import android.support.v4.content.res.ResourcesCompat;
+import android.support.v7.app.AlertDialog;
+import android.support.v7.widget.Toolbar;
+import android.util.DisplayMetrics;
+import android.util.Log;
+import android.view.ContextThemeWrapper;
+import android.view.LayoutInflater;
+import android.view.Menu;
+import android.view.MenuItem;
+import android.view.View;
+import android.widget.ImageView;
+import android.widget.LinearLayout;
+import android.widget.ProgressBar;
+import android.widget.RelativeLayout;
+import android.widget.TextView;
+
+import com.dinuscxj.progressbar.CircleProgressBar;
+
+import org.json.JSONException;
+import org.json.JSONObject;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.util.Optional;
+
+import javax.inject.Inject;
+
+import butterknife.BindView;
+import butterknife.ButterKnife;
+import butterknife.OnClick;
+import fr.free.nrw.commons.R;
+import fr.free.nrw.commons.Utils;
+import fr.free.nrw.commons.auth.SessionManager;
+import fr.free.nrw.commons.mwapi.MediaWikiApi;
+import fr.free.nrw.commons.theme.NavigationBaseActivity;
+import fr.free.nrw.commons.utils.ViewUtil;
+import io.reactivex.android.schedulers.AndroidSchedulers;
+import io.reactivex.disposables.CompositeDisposable;
+import io.reactivex.schedulers.Schedulers;
+import timber.log.Timber;
+
+/**
+ * activity for sharing feedback on uploaded activity
+ */
+public class AchievementsActivity extends NavigationBaseActivity {
+
+ private static final double BADGE_IMAGE_WIDTH_RATIO = 0.4;
+ private static final double BADGE_IMAGE_HEIGHT_RATIO = 0.3;
+ private Boolean isUploadFetched = false;
+ private Boolean isStatisticsFetched = false;
+ private Boolean isRevertFetched = false;
+ private Achievements achievements = new Achievements();
+ private LevelController.LevelInfo levelInfo;
+
+ @BindView(R.id.achievement_badge)
+ ImageView imageView;
+ @BindView(R.id.achievement_level)
+ TextView levelNumber;
+ @BindView(R.id.toolbar)
+ Toolbar toolbar;
+ @BindView(R.id.thanks_received)
+ TextView thanksReceived;
+ @BindView(R.id.images_uploaded_progressbar)
+ CircleProgressBar imagesUploadedProgressbar;
+ @BindView(R.id.images_used_by_wiki_progressbar)
+ CircleProgressBar imagesUsedByWikiProgessbar;
+ @BindView(R.id.image_reverts_progressbar)
+ CircleProgressBar imageRevertsProgressbar;
+ @BindView(R.id.image_featured)
+ TextView imagesFeatured;
+ @BindView(R.id.images_revert_limit_text)
+ TextView imagesRevertLimitText;
+ @BindView(R.id.progressBar)
+ ProgressBar progressBar;
+ @BindView(R.id.layout_image_uploaded)
+ RelativeLayout layoutImageUploaded;
+ @BindView(R.id.layout_image_reverts)
+ RelativeLayout layoutImageReverts;
+ @BindView(R.id.layout_image_used_by_wiki)
+ RelativeLayout layoutImageUsedByWiki;
+ @BindView(R.id.layout_statistics)
+ LinearLayout layoutStatistics;
+ @Inject
+ SessionManager sessionManager;
+ @Inject
+ MediaWikiApi mediaWikiApi;
+
+ private CompositeDisposable compositeDisposable = new CompositeDisposable();
+
+ /**
+ * This method helps in the creation Achievement screen and
+ * dynamically set the size of imageView
+ *
+ * @param savedInstanceState Data bundle
+ */
+ @Override
+ @SuppressLint("StringFormatInvalid")
+ protected void onCreate(Bundle savedInstanceState) {
+ super.onCreate(savedInstanceState);
+ setContentView(R.layout.activity_achievements);
+ ButterKnife.bind(this);
+ /**
+ * DisplayMetrics used to fetch the size of the screen
+ */
+ DisplayMetrics displayMetrics = new DisplayMetrics();
+ getWindowManager().getDefaultDisplay().getMetrics(displayMetrics);
+ int height = displayMetrics.heightPixels;
+ int width = displayMetrics.widthPixels;
+
+ /**
+ * Used for the setting the size of imageView at runtime
+ */
+ RelativeLayout.LayoutParams params = (RelativeLayout.LayoutParams)
+ imageView.getLayoutParams();
+ params.height = (int) (height * BADGE_IMAGE_HEIGHT_RATIO);
+ params.width = (int) (width * BADGE_IMAGE_WIDTH_RATIO);
+ imageView.setImageResource(R.drawable.badge);
+ imageView.requestLayout();
+
+ setSupportActionBar(toolbar);
+ progressBar.setVisibility(View.VISIBLE);
+ hideLayouts();
+ setAchievements();
+ setUploadCount();
+ setRevertCount();
+ initDrawer();
+ }
+
+ /**
+ * to invoke the AlertDialog on clicking info button
+ */
+ @OnClick(R.id.achievement_info)
+ public void showInfoDialog(){
+ launchAlert(getResources().getString(R.string.Achievements)
+ ,getResources().getString(R.string.achievements_info_message));
+ }
+
+ @Override
+ public boolean onCreateOptionsMenu(Menu menu) {
+ // Inflate the menu; this adds items to the action bar if it is present.
+ getMenuInflater().inflate(R.menu.menu_about, menu);
+ return true;
+ }
+
+ @Override
+ public boolean onOptionsItemSelected(MenuItem item) {
+ int id = item.getItemId();
+ if (id == R.id.share_app_icon) {
+ View rootView = getWindow().getDecorView().findViewById(android.R.id.content);
+ Bitmap screenShot = Utils.getScreenShot(rootView);
+ showAlert(screenShot);
+ }
+
+ return super.onOptionsItemSelected(item);
+ }
+
+ /**
+ * To take bitmap and store it temporary storage and share it
+ *
+ * @param bitmap
+ */
+ void shareScreen(Bitmap bitmap) {
+ try {
+ File file = new File(this.getExternalCacheDir(), "screen.png");
+ FileOutputStream fOut = new FileOutputStream(file);
+ bitmap.compress(Bitmap.CompressFormat.PNG, 100, fOut);
+ fOut.flush();
+ fOut.close();
+ file.setReadable(true, false);
+ final Intent intent = new Intent(android.content.Intent.ACTION_SEND);
+ intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
+ intent.putExtra(Intent.EXTRA_STREAM, Uri.fromFile(file));
+ intent.setType("image/png");
+ startActivity(Intent.createChooser(intent, "Share image via"));
+ } catch (IOException e) {
+ //Do Nothing
+ }
+ }
+
+ /**
+ * To call the API to get results in form Single
+ * which then calls parseJson when results are fetched
+ */
+ private void setAchievements() {
+ if(checkAccount()) {
+ compositeDisposable.add(mediaWikiApi
+ .getAchievements(sessionManager.getCurrentAccount().name)
+ .subscribeOn(Schedulers.io())
+ .observeOn(AndroidSchedulers.mainThread())
+ .subscribe(
+ jsonObject -> parseJson(jsonObject),
+ t -> Timber.e(t, "Fetching achievements statisticss failed")
+ ));
+ }
+ }
+
+ /**
+ * To call the API to get reverts count in form of JSONObject
+ *
+ */
+
+ private void setRevertCount(){
+ if(checkAccount()) {
+ compositeDisposable.add(mediaWikiApi
+ .getRevertCount(sessionManager.getCurrentAccount().name)
+ .subscribeOn(Schedulers.io())
+ .observeOn(AndroidSchedulers.mainThread())
+ .subscribe(
+ object -> parseJsonRevertCount(object),
+ t -> Timber.e(t, "Fetching revert count failed")
+ ));
+ }
+ }
+
+ /**
+ * used to set number of deleted images
+ * @param object
+ */
+ private void parseJsonRevertCount(JSONObject object){
+ try {
+ achievements.setRevertCount(object.getInt("deletedUploads"));
+ } catch (JSONException e) {
+ Timber.d( e, e.getMessage());
+ }
+ isRevertFetched = true;
+ hideProgressBar();
+ }
+
+ /**
+ * used to the count of images uploaded by user
+ */
+ private void setUploadCount() {
+ if(checkAccount()) {
+ compositeDisposable.add(mediaWikiApi
+ .getUploadCount(sessionManager.getCurrentAccount().name)
+ .subscribeOn(Schedulers.io())
+ .observeOn(AndroidSchedulers.mainThread())
+ .subscribe(
+ uploadCount -> setAchievementsUploadCount(uploadCount),
+ t -> Timber.e(t, "Fetching upload count failed")
+ ));
+ }
+ }
+
+ /**
+ * used to set achievements upload count and call hideProgressbar
+ * @param uploadCount
+ */
+ private void setAchievementsUploadCount(int uploadCount){
+ achievements.setImagesUploaded(uploadCount);
+ isUploadFetched = true;
+ hideProgressBar();
+ }
+
+ /**
+ * used to the uploaded images progressbar
+ * @param uploadCount
+ */
+ private void setUploadProgress(int uploadCount){
+ imagesUploadedProgressbar.setProgress
+ (100*uploadCount/levelInfo.getMaxUploadCount());
+ imagesUploadedProgressbar.setProgressTextFormatPattern
+ (uploadCount +"/" + levelInfo.getMaxUploadCount() );
+ }
+
+ /**
+ * used to set the non revert image percentage
+ * @param notRevertPercentage
+ */
+ private void setImageRevertPercentage(int notRevertPercentage){
+ imageRevertsProgressbar.setProgress(notRevertPercentage);
+ String revertPercentage = Integer.toString(notRevertPercentage);
+ imageRevertsProgressbar.setProgressTextFormatPattern(revertPercentage + "%%");
+ imagesRevertLimitText.setText(getResources().getString(R.string.achievements_revert_limit_message)+ levelInfo.getMinNonRevertPercentage() + "%");
+ }
+
+ /**
+ * used to parse the JSONObject containing results
+ * @param object
+ */
+ private void parseJson(JSONObject object) {
+ try {
+ achievements.setUniqueUsedImages(object.getInt("uniqueUsedImages"));
+ achievements.setArticlesUsingImages(object.getInt("articlesUsingImages"));
+ achievements.setThanksReceived(object.getInt("thanksReceived"));
+ achievements.setImagesEditedBySomeoneElse(object.getInt("imagesEditedBySomeoneElse"));
+ JSONObject featuredImages = object.getJSONObject("featuredImages");
+ achievements.setFeaturedImages
+ (featuredImages.getInt("Quality_images") +
+ featuredImages.getInt("Featured_pictures_on_Wikimedia_Commons"));
+ } catch (JSONException e) {
+ e.printStackTrace();
+ }
+ isStatisticsFetched = true;
+ hideProgressBar();
+ }
+
+ /**
+ * Used the inflate the fetched statistics of the images uploaded by user
+ * and assign badge and level
+ * @param achievements
+ */
+ private void inflateAchievements(Achievements achievements ){
+ thanksReceived.setText(Integer.toString(achievements.getThanksReceived()));
+ imagesUsedByWikiProgessbar.setProgress
+ (100*achievements.getUniqueUsedImages()/levelInfo.getMaxUniqueImages() );
+ imagesUsedByWikiProgessbar.setProgressTextFormatPattern
+ (achievements.getUniqueUsedImages() + "/" + levelInfo.getMaxUniqueImages());
+ imagesFeatured.setText(Integer.toString(achievements.getFeaturedImages()));
+ String levelUpInfoString = getString(R.string.level);
+ levelUpInfoString += " " + Integer.toString(levelInfo.getLevelNumber());
+ levelNumber.setText(levelUpInfoString);
+ final ContextThemeWrapper wrapper = new ContextThemeWrapper(this, levelInfo.getLevelStyle());
+ Drawable drawable = ResourcesCompat.getDrawable(getResources(), R.drawable.badge, wrapper.getTheme());
+ Bitmap bitmap = BitmapUtils.drawableToBitmap(drawable);
+ BitmapDrawable bitmapImage = BitmapUtils.writeOnDrawable(bitmap, Integer.toString(levelInfo.getLevelNumber()),this);
+ imageView.setImageDrawable(bitmapImage);
+ }
+
+ /**
+ * Creates a way to change current activity to AchievementActivity
+ * @param context
+ */
+ public static void startYourself(Context context) {
+ Intent intent = new Intent(context, AchievementsActivity.class);
+ intent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP);
+ intent.addFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP);
+ context.startActivity(intent);
+ }
+
+ /**
+ * to hide progressbar
+ */
+ private void hideProgressBar() {
+ if (progressBar != null && isUploadFetched && isStatisticsFetched && isRevertFetched) {
+ levelInfo = LevelController.LevelInfo.from(achievements.getImagesUploaded(),
+ achievements.getUniqueUsedImages(),
+ achievements.getNotRevertPercentage());
+ inflateAchievements(achievements);
+ setUploadProgress(achievements.getImagesUploaded());
+ setImageRevertPercentage(achievements.getNotRevertPercentage());
+ progressBar.setVisibility(View.GONE);
+ layoutImageReverts.setVisibility(View.VISIBLE);
+ layoutImageUploaded.setVisibility(View.VISIBLE);
+ layoutImageUsedByWiki.setVisibility(View.VISIBLE);
+ layoutStatistics.setVisibility(View.VISIBLE);
+ imageView.setVisibility(View.VISIBLE);
+ levelNumber.setVisibility(View.VISIBLE);
+ }
+ }
+
+ /**
+ * used to hide the layouts while fetching results from api
+ */
+ private void hideLayouts(){
+ layoutImageUsedByWiki.setVisibility(View.INVISIBLE);
+ layoutImageUploaded.setVisibility(View.INVISIBLE);
+ layoutImageReverts.setVisibility(View.INVISIBLE);
+ layoutStatistics.setVisibility(View.INVISIBLE);
+ imageView.setVisibility(View.INVISIBLE);
+ levelNumber.setVisibility(View.INVISIBLE);
+ }
+
+ /**
+ * It display the alertDialog with Image of screenshot
+ * @param screenshot
+ */
+ public void showAlert(Bitmap screenshot){
+ AlertDialog.Builder alertadd = new AlertDialog.Builder(AchievementsActivity.this);
+ LayoutInflater factory = LayoutInflater.from(AchievementsActivity.this);
+ final View view = factory.inflate(R.layout.image_alert_layout, null);
+ ImageView screenShotImage = (ImageView) view.findViewById(R.id.alert_image);
+ screenShotImage.setImageBitmap(screenshot);
+ TextView shareMessage = (TextView) view.findViewById(R.id.alert_text);
+ shareMessage.setText(R.string.achievements_share_message);
+ alertadd.setView(view);
+ alertadd.setPositiveButton("Proceed", new DialogInterface.OnClickListener() {
+ public void onClick(DialogInterface dialog, int which) {
+ shareScreen(screenshot);
+ }
+ });
+ alertadd.setNegativeButton("Cancel", new DialogInterface.OnClickListener() {
+ @Override
+ public void onClick(DialogInterface dialog, int which) {
+ dialog.cancel();
+ }
+ });
+ alertadd.show();
+ }
+
+ @OnClick(R.id.images_upload_info)
+ public void showUploadInfo(){
+ launchAlert(getResources().getString(R.string.images_uploaded)
+ ,getResources().getString(R.string.images_uploaded_explanation));
+ }
+
+ @OnClick(R.id.images_reverted_info)
+ public void showRevertedInfo(){
+ launchAlert(getResources().getString(R.string.image_reverts)
+ ,getResources().getString(R.string.images_reverted_explanation));
+ }
+
+ @OnClick(R.id.images_used_by_wiki_info)
+ public void showUsedByWikiInfo(){
+ launchAlert(getResources().getString(R.string.images_used_by_wiki)
+ ,getResources().getString(R.string.images_used_explanation));
+ }
+
+ /**
+ * takes title and message as input to display alerts
+ * @param title
+ * @param message
+ */
+ private void launchAlert(String title, String message){
+ new AlertDialog.Builder(AchievementsActivity.this)
+ .setTitle(title)
+ .setMessage(message)
+ .setCancelable(true)
+ .setNeutralButton(android.R.string.ok, (dialog, id) -> dialog.cancel())
+ .create()
+ .show();
+ }
+
+ /**
+ * check to ensure that user is logged in
+ * @return
+ */
+ private boolean checkAccount(){
+ Account currentAccount = sessionManager.getCurrentAccount();
+ if(currentAccount == null) {
+ Timber.d("Current account is null");
+ ViewUtil.showLongToast(this, getResources().getString(R.string.user_not_logged_in));
+ sessionManager.forceLogin(this);
+ return false;
+ }
+ return true;
+ }
+
+}
diff --git a/app/src/main/java/fr/free/nrw/commons/achievements/BitmapUtils.java b/app/src/main/java/fr/free/nrw/commons/achievements/BitmapUtils.java
new file mode 100644
index 000000000..b7400117d
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/achievements/BitmapUtils.java
@@ -0,0 +1,54 @@
+package fr.free.nrw.commons.achievements;
+
+import android.content.Context;
+import android.graphics.Bitmap;
+import android.graphics.Canvas;
+import android.graphics.Color;
+import android.graphics.Paint;
+import android.graphics.Rect;
+import android.graphics.drawable.BitmapDrawable;
+import android.graphics.drawable.Drawable;
+
+public class BitmapUtils {
+
+ /**
+ * write level Number on the badge
+ * @param bm
+ * @param text
+ * @return
+ */
+ public static BitmapDrawable writeOnDrawable(Bitmap bm, String text, Context context){
+ Bitmap.Config config = bm.getConfig();
+ if(config == null){
+ config = Bitmap.Config.ARGB_8888;
+ }
+ Bitmap bitmap = Bitmap.createBitmap(bm.getWidth(),bm.getHeight(),config);
+ Canvas canvas = new Canvas(bitmap);
+ canvas.drawBitmap(bm, 0, 0, null);
+ Paint paint = new Paint(Paint.ANTI_ALIAS_FLAG);
+ paint.setStyle(Paint.Style.FILL);
+ paint.setColor(Color.WHITE);
+ paint.setTextSize(Math.round(canvas.getHeight()/2));
+ paint.setTextAlign(Paint.Align.CENTER);
+ Rect rectText = new Rect();
+ paint.getTextBounds(text,0, text.length(),rectText);
+ canvas.drawText(text, Math.round(canvas.getWidth()/2),Math.round(canvas.getHeight()/1.35), paint);
+ return new BitmapDrawable(context.getResources(), bitmap);
+ }
+
+ /**
+ * Convert Drawable to bitmap
+ * @param drawable
+ * @return
+ */
+ public static Bitmap drawableToBitmap (Drawable drawable) {
+ if (drawable instanceof BitmapDrawable) {
+ return ((BitmapDrawable)drawable).getBitmap();
+ }
+ Bitmap bitmap = Bitmap.createBitmap(drawable.getIntrinsicWidth(), drawable.getIntrinsicHeight(), Bitmap.Config.ARGB_8888);
+ Canvas canvas = new Canvas(bitmap);
+ drawable.setBounds(0, 0, canvas.getWidth(), canvas.getHeight());
+ drawable.draw(canvas);
+ return bitmap;
+ }
+}
diff --git a/app/src/main/java/fr/free/nrw/commons/achievements/LevelController.java b/app/src/main/java/fr/free/nrw/commons/achievements/LevelController.java
new file mode 100644
index 000000000..e0f84bbee
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/achievements/LevelController.java
@@ -0,0 +1,85 @@
+package fr.free.nrw.commons.achievements;
+
+import android.util.Log;
+
+import fr.free.nrw.commons.R;
+
+/**
+ * calculates the level of the user
+ */
+public class LevelController {
+
+ public LevelInfo level;
+ public enum LevelInfo{
+ LEVEL_1(1, R.style.LevelOne, 5, 20, 85),
+ LEVEL_2(2, R.style.LevelTwo, 10, 30, 86),
+ LEVEL_3(3, R.style.LevelThree, 15,40, 87),
+ LEVEL_4(4, R.style.LevelFour,20,50, 88),
+ LEVEL_5(5, R.style.LevelFive, 25, 60, 89),
+ LEVEL_6(6,R.style.LevelOne,30,70, 90),
+ LEVEL_7(7, R.style.LevelTwo, 40, 80, 90),
+ LEVEL_8(8, R.style.LevelThree, 45, 90, 90),
+ LEVEL_9(9, R.style.LevelFour, 50, 100, 90),
+ LEVEL_10(10, R.style.LevelFive, 55, 110, 90),
+ LEVEL_11(11,R.style.LevelOne, 60, 120, 90),
+ LEVEL_12(12,R.style.LevelTwo,65 , 130, 90),
+ LEVEL_13(13,R.style.LevelThree, 70, 140, 90),
+ LEVEL_14(14,R.style.LevelFour, 75 , 150, 90),
+ LEVEL_15(15,R.style.LevelFive, 80, 160, 90);
+
+ private int levelNumber;
+ private int levelStyle;
+ private int maxUniqueImages;
+ private int maxUploadCount;
+ private int minNonRevertPercentage;
+
+ LevelInfo(int levelNumber,
+ int levelStyle,
+ int maxUniqueImages,
+ int maxUploadCount,
+ int minNonRevertPercentage) {
+ this.levelNumber = levelNumber;
+ this.levelStyle = levelStyle;
+ this.maxUniqueImages = maxUniqueImages;
+ this.maxUploadCount = maxUploadCount;
+ this.minNonRevertPercentage = minNonRevertPercentage;
+ }
+
+ public static LevelInfo from(int imagesUploaded,
+ int uniqueImagesUsed,
+ int nonRevertRate) {
+ LevelInfo level = LEVEL_15;
+
+ for (LevelInfo levelInfo : LevelInfo.values()) {
+ if (imagesUploaded < levelInfo.maxUploadCount
+ || uniqueImagesUsed < levelInfo.maxUniqueImages
+ || nonRevertRate < levelInfo.minNonRevertPercentage ) {
+ level = levelInfo;
+ return level;
+ }
+ }
+ return level;
+ }
+
+ public int getLevelStyle() {
+ return levelStyle;
+ }
+
+ public int getLevelNumber() {
+ return levelNumber;
+ }
+
+ public int getMaxUniqueImages() {
+ return maxUniqueImages;
+ }
+
+ public int getMaxUploadCount() {
+ return maxUploadCount;
+ }
+
+ public int getMinNonRevertPercentage(){
+ return minNonRevertPercentage;
+ }
+ }
+
+}
diff --git a/app/src/main/java/fr/free/nrw/commons/auth/AuthenticatedActivity.java b/app/src/main/java/fr/free/nrw/commons/auth/AuthenticatedActivity.java
index e39528252..611cb7975 100644
--- a/app/src/main/java/fr/free/nrw/commons/auth/AuthenticatedActivity.java
+++ b/app/src/main/java/fr/free/nrw/commons/auth/AuthenticatedActivity.java
@@ -4,8 +4,13 @@ import android.os.Bundle;
import javax.inject.Inject;
+import fr.free.nrw.commons.R;
import fr.free.nrw.commons.mwapi.MediaWikiApi;
import fr.free.nrw.commons.theme.NavigationBaseActivity;
+import fr.free.nrw.commons.utils.ViewUtil;
+import io.reactivex.Observable;
+import io.reactivex.android.schedulers.AndroidSchedulers;
+import io.reactivex.schedulers.Schedulers;
import static fr.free.nrw.commons.auth.AccountUtil.AUTH_COOKIE;
@@ -34,6 +39,8 @@ public abstract class AuthenticatedActivity extends NavigationBaseActivity {
if (savedInstanceState != null) {
authCookie = savedInstanceState.getString(AUTH_COOKIE);
}
+
+ showBlockStatus();
}
@Override
@@ -45,4 +52,20 @@ public abstract class AuthenticatedActivity extends NavigationBaseActivity {
protected abstract void onAuthCookieAcquired(String authCookie);
protected abstract void onAuthFailure();
+
+ /**
+ * Makes API call to check if user is blocked from Commons. If the user is blocked, a snackbar
+ * is created to notify the user
+ */
+ protected void showBlockStatus()
+ {
+ Observable.fromCallable(() -> mediaWikiApi.isUserBlockedFromCommons())
+ .subscribeOn(Schedulers.io())
+ .observeOn(AndroidSchedulers.mainThread())
+ .filter(result -> result)
+ .subscribe(result -> {
+ ViewUtil.showSnackbar(findViewById(android.R.id.content), R.string.block_notification);
+ }
+ );
+ }
}
diff --git a/app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.java b/app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.java
index 773811737..959317c1f 100644
--- a/app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.java
+++ b/app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.java
@@ -5,6 +5,7 @@ import android.accounts.AccountAuthenticatorActivity;
import android.accounts.AccountAuthenticatorResponse;
import android.accounts.AccountManager;
import android.app.ProgressDialog;
+import android.content.Context;
import android.content.Intent;
import android.content.SharedPreferences;
import android.net.Uri;
@@ -41,10 +42,10 @@ import fr.free.nrw.commons.PageTitle;
import fr.free.nrw.commons.R;
import fr.free.nrw.commons.Utils;
import fr.free.nrw.commons.WelcomeActivity;
+import fr.free.nrw.commons.category.CategoryImagesActivity;
import fr.free.nrw.commons.contributions.ContributionsActivity;
import fr.free.nrw.commons.di.ApplicationlessInjection;
import fr.free.nrw.commons.mwapi.MediaWikiApi;
-import fr.free.nrw.commons.nearby.NearbyActivity;
import fr.free.nrw.commons.theme.NavigationBaseActivity;
import fr.free.nrw.commons.ui.widget.HtmlTextView;
import fr.free.nrw.commons.utils.ViewUtil;
@@ -62,6 +63,7 @@ import static fr.free.nrw.commons.auth.AccountUtil.AUTH_TOKEN_TYPE;
public class LoginActivity extends AccountAuthenticatorActivity {
public static final String PARAM_USERNAME = "fr.free.nrw.commons.login.username";
+ private static final String FEATURED_IMAGES_CATEGORY = "Category:Featured_pictures_on_Wikimedia_Commons";
@Inject MediaWikiApi mwApi;
@Inject AccountUtil accountUtil;
@@ -146,9 +148,13 @@ public class LoginActivity extends AccountAuthenticatorActivity {
}
}
+ /**
+ * This function is called when user skips the login.
+ * It redirects the user to Explore Activity.
+ */
private void skipLogin() {
prefs.edit().putBoolean("login_skipped", true).apply();
- NavigationBaseActivity.startActivityWithFlags(this, NearbyActivity.class, Intent.FLAG_ACTIVITY_CLEAR_TOP);
+ CategoryImagesActivity.startYourself(this, getString(R.string.title_activity_explore), FEATURED_IMAGES_CATEGORY);
finish();
}
@@ -180,6 +186,7 @@ public class LoginActivity extends AccountAuthenticatorActivity {
&& sessionManager.isUserLoggedIn()
&& sessionManager.getCachedAuthCookie() != null) {
prefs.edit().putBoolean("login_skipped", false).apply();
+ sessionManager.revalidateAuthToken();
startMainActivity();
}
@@ -294,11 +301,11 @@ public class LoginActivity extends AccountAuthenticatorActivity {
showMessageAndCancelDialog(R.string.login_failed_network);
} else if (result.toLowerCase(Locale.getDefault()).contains("nosuchuser".toLowerCase()) || result.toLowerCase().contains("noname".toLowerCase())) {
// Matches nosuchuser, nosuchusershort, noname
- showMessageAndCancelDialog(R.string.login_failed_username);
+ showMessageAndCancelDialog(R.string.login_failed_wrong_credentials);
emptySensitiveEditFields();
} else if (result.toLowerCase(Locale.getDefault()).contains("wrongpassword".toLowerCase())) {
// Matches wrongpassword, wrongpasswordempty
- showMessageAndCancelDialog(R.string.login_failed_password);
+ showMessageAndCancelDialog(R.string.login_failed_wrong_credentials);
emptySensitiveEditFields();
} else if (result.toLowerCase(Locale.getDefault()).contains("throttle".toLowerCase())) {
// Matches unknown throttle error codes
@@ -463,4 +470,9 @@ public class LoginActivity extends AccountAuthenticatorActivity {
loginButton.setEnabled(enabled);
}
}
+
+ public static void startYourself(Context context) {
+ Intent intent = new Intent(context, LoginActivity.class);
+ context.startActivity(intent);
+ }
}
diff --git a/app/src/main/java/fr/free/nrw/commons/auth/SessionManager.java b/app/src/main/java/fr/free/nrw/commons/auth/SessionManager.java
index ad9a0bda4..896158439 100644
--- a/app/src/main/java/fr/free/nrw/commons/auth/SessionManager.java
+++ b/app/src/main/java/fr/free/nrw/commons/auth/SessionManager.java
@@ -5,6 +5,8 @@ import android.accounts.AccountManager;
import android.content.Context;
import android.content.SharedPreferences;
+import javax.annotation.Nullable;
+
import fr.free.nrw.commons.mwapi.MediaWikiApi;
import io.reactivex.Completable;
import io.reactivex.Observable;
@@ -31,6 +33,7 @@ public class SessionManager {
/**
* @return Account|null
*/
+ @Nullable
public Account getCurrentAccount() {
if (currentAccount == null) {
AccountManager accountManager = AccountManager.get(context);
@@ -81,6 +84,12 @@ public class SessionManager {
return sharedPreferences.getBoolean("isUserLoggedIn", false);
}
+ public void forceLogin(Context context) {
+ if (context != null) {
+ LoginActivity.startYourself(context);
+ }
+ }
+
public Completable clearAllAccounts() {
AccountManager accountManager = AccountManager.get(context);
Account[] allAccounts = accountManager.getAccountsByType(ACCOUNT_TYPE);
diff --git a/app/src/main/java/fr/free/nrw/commons/caching/CacheController.java b/app/src/main/java/fr/free/nrw/commons/caching/CacheController.java
index ff6ceece4..72de0db70 100644
--- a/app/src/main/java/fr/free/nrw/commons/caching/CacheController.java
+++ b/app/src/main/java/fr/free/nrw/commons/caching/CacheController.java
@@ -7,18 +7,25 @@ import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
-import fr.free.nrw.commons.upload.MwVolleyApi;
+import javax.inject.Inject;
+import javax.inject.Singleton;
+
+import fr.free.nrw.commons.upload.GpsCategoryModel;
import timber.log.Timber;
+@Singleton
public class CacheController {
+ private final GpsCategoryModel gpsCategoryModel;
+ private final QuadTree> quadTree;
private double x, y;
- private QuadTree> quadTree;
private double xMinus, xPlus, yMinus, yPlus;
private static final int EARTH_RADIUS = 6378137;
- public CacheController() {
+ @Inject
+ CacheController(GpsCategoryModel gpsCategoryModel) {
+ this.gpsCategoryModel = gpsCategoryModel;
quadTree = new QuadTree<>(-180, -90, +180, +90);
}
@@ -31,8 +38,8 @@ public class CacheController {
public void cacheCategory() {
List pointCatList = new ArrayList<>();
- if (MwVolleyApi.GpsCatExists.getGpsCatExists()) {
- pointCatList.addAll(MwVolleyApi.getGpsCat());
+ if (gpsCategoryModel.getGpsCatExists()) {
+ pointCatList.addAll(gpsCategoryModel.getCategoryList());
Timber.d("Categories being cached: %s", pointCatList);
} else {
Timber.d("No categories found, so no categories cached");
@@ -65,7 +72,7 @@ public class CacheController {
}
//Based on algorithm at http://gis.stackexchange.com/questions/2951/algorithm-for-offsetting-a-latitude-longitude-by-some-amount-of-meters
- public void convertCoordRange() {
+ private void convertCoordRange() {
//Position, decimal degrees
double lat = y;
double lon = x;
diff --git a/app/src/main/java/fr/free/nrw/commons/category/CategorizationFragment.java b/app/src/main/java/fr/free/nrw/commons/category/CategorizationFragment.java
index e804189ab..93ddb60d5 100644
--- a/app/src/main/java/fr/free/nrw/commons/category/CategorizationFragment.java
+++ b/app/src/main/java/fr/free/nrw/commons/category/CategorizationFragment.java
@@ -39,7 +39,7 @@ import butterknife.ButterKnife;
import fr.free.nrw.commons.R;
import fr.free.nrw.commons.di.CommonsDaggerSupportFragment;
import fr.free.nrw.commons.mwapi.MediaWikiApi;
-import fr.free.nrw.commons.upload.MwVolleyApi;
+import fr.free.nrw.commons.upload.GpsCategoryModel;
import fr.free.nrw.commons.utils.StringSortingUtils;
import fr.free.nrw.commons.utils.ViewUtil;
import io.reactivex.Observable;
@@ -73,6 +73,7 @@ public class CategorizationFragment extends CommonsDaggerSupportFragment {
@Inject @Named("prefs") SharedPreferences prefsPrefs;
@Inject @Named("direct_nearby_upload_prefs") SharedPreferences directPrefs;
@Inject CategoryDao categoryDao;
+ @Inject GpsCategoryModel gpsCategoryModel;
private RVRendererAdapter categoriesAdapter;
private OnCategoriesSaveHandler onCategoriesSaveHandler;
@@ -253,7 +254,6 @@ public class CategorizationFragment extends CommonsDaggerSupportFragment {
}
private Observable defaultCategories() {
-
Observable directCat = directCategories();
if (hasDirectCategories) {
Timber.d("Image has direct Cat");
@@ -287,9 +287,7 @@ public class CategorizationFragment extends CommonsDaggerSupportFragment {
}
private Observable gpsCategories() {
- return Observable.fromIterable(
- MwVolleyApi.GpsCatExists.getGpsCatExists()
- ? MwVolleyApi.getGpsCat() : new ArrayList<>())
+ return Observable.fromIterable(gpsCategoryModel.getCategoryList())
.map(name -> new CategoryItem(name, false));
}
diff --git a/app/src/main/java/fr/free/nrw/commons/category/CategoryDetailsActivity.java b/app/src/main/java/fr/free/nrw/commons/category/CategoryDetailsActivity.java
new file mode 100644
index 000000000..3ab3c2c07
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/category/CategoryDetailsActivity.java
@@ -0,0 +1,253 @@
+package fr.free.nrw.commons.category;
+
+import android.content.Context;
+import android.content.Intent;
+import android.database.DataSetObserver;
+import android.os.Bundle;
+import android.support.design.widget.TabLayout;
+import android.support.v4.app.Fragment;
+import android.support.v4.app.FragmentManager;
+import android.support.v4.view.ViewPager;
+import android.view.Menu;
+import android.view.MenuInflater;
+import android.view.MenuItem;
+import android.view.View;
+import android.widget.AdapterView;
+import android.widget.FrameLayout;
+import android.widget.Toast;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import butterknife.BindView;
+import butterknife.ButterKnife;
+import fr.free.nrw.commons.Media;
+import fr.free.nrw.commons.PageTitle;
+import fr.free.nrw.commons.R;
+import fr.free.nrw.commons.explore.ViewPagerAdapter;
+import fr.free.nrw.commons.media.MediaDetailPagerFragment;
+import fr.free.nrw.commons.theme.NavigationBaseActivity;
+
+import static android.widget.Toast.LENGTH_SHORT;
+
+/**
+ * This activity displays details of a particular category
+ * Its generic and simply takes the name of category name in its start intent to load all images, subcategories in
+ * a particular category on wikimedia commons.
+ */
+
+public class CategoryDetailsActivity extends NavigationBaseActivity
+ implements MediaDetailPagerFragment.MediaDetailProvider,
+ AdapterView.OnItemClickListener{
+
+
+ private FragmentManager supportFragmentManager;
+ private CategoryImagesListFragment categoryImagesListFragment;
+ private MediaDetailPagerFragment mediaDetails;
+ private String categoryName;
+ @BindView(R.id.mediaContainer) FrameLayout mediaContainer;
+ @BindView(R.id.tabLayout) TabLayout tabLayout;
+ @BindView(R.id.viewPager) ViewPager viewPager;
+
+ ViewPagerAdapter viewPagerAdapter;
+
+ @Override
+ protected void onCreate(Bundle savedInstanceState) {
+ super.onCreate(savedInstanceState);
+ setContentView(R.layout.activity_category_details);
+ ButterKnife.bind(this);
+ supportFragmentManager = getSupportFragmentManager();
+ viewPagerAdapter = new ViewPagerAdapter(getSupportFragmentManager());
+ viewPager.setAdapter(viewPagerAdapter);
+ viewPager.setOffscreenPageLimit(2);
+ tabLayout.setupWithViewPager(viewPager);
+ setTabs();
+ setPageTitle();
+ initDrawer();
+ forceInitBackButton();
+ }
+
+ /**
+ * This activity contains 3 tabs and a viewpager. This method is used to set the titles of tab,
+ * Set the fragments according to the tab selected in the viewPager.
+ */
+ private void setTabs() {
+ List fragmentList = new ArrayList<>();
+ List titleList = new ArrayList<>();
+ categoryImagesListFragment = new CategoryImagesListFragment();
+ SubCategoryListFragment subCategoryListFragment = new SubCategoryListFragment();
+ SubCategoryListFragment parentCategoryListFragment = new SubCategoryListFragment();
+ categoryName = getIntent().getStringExtra("categoryName");
+ if (getIntent() != null && categoryName != null) {
+ Bundle arguments = new Bundle();
+ arguments.putString("categoryName", categoryName);
+ arguments.putBoolean("isParentCategory", false);
+ categoryImagesListFragment.setArguments(arguments);
+ subCategoryListFragment.setArguments(arguments);
+ Bundle parentCategoryArguments = new Bundle();
+ parentCategoryArguments.putString("categoryName", categoryName);
+ parentCategoryArguments.putBoolean("isParentCategory", true);
+ parentCategoryListFragment.setArguments(parentCategoryArguments);
+ }
+ fragmentList.add(categoryImagesListFragment);
+ titleList.add("MEDIA");
+ fragmentList.add(subCategoryListFragment);
+ titleList.add("SUBCATEGORIES");
+ fragmentList.add(parentCategoryListFragment);
+ titleList.add("PARENT CATEGORIES");
+ viewPagerAdapter.setTabData(fragmentList, titleList);
+ viewPagerAdapter.notifyDataSetChanged();
+
+ }
+
+ /**
+ * Gets the passed categoryName from the intents and displays it as the page title
+ */
+ private void setPageTitle() {
+ if (getIntent() != null && getIntent().getStringExtra("categoryName") != null) {
+ setTitle(getIntent().getStringExtra("categoryName"));
+ }
+ }
+
+ /**
+ * This method is called onClick of media inside category details (CategoryImageListFragment).
+ */
+ @Override
+ public void onItemClick(AdapterView> adapterView, View view, int i, long l) {
+ tabLayout.setVisibility(View.GONE);
+ viewPager.setVisibility(View.GONE);
+ mediaContainer.setVisibility(View.VISIBLE);
+ if (mediaDetails == null || !mediaDetails.isVisible()) {
+ // set isFeaturedImage true for featured images, to include author field on media detail
+ mediaDetails = new MediaDetailPagerFragment(false, true);
+ FragmentManager supportFragmentManager = getSupportFragmentManager();
+ supportFragmentManager
+ .beginTransaction()
+ .replace(R.id.mediaContainer, mediaDetails)
+ .addToBackStack(null)
+ .commit();
+ supportFragmentManager.executePendingTransactions();
+ }
+ mediaDetails.showImage(i);
+ forceInitBackButton();
+ }
+
+
+ /**
+ * Consumers should be simply using this method to use this activity.
+ * @param context A Context of the application package implementing this class.
+ * @param categoryName Name of the category for displaying its details
+ */
+ public static void startYourself(Context context, String categoryName) {
+ Intent intent = new Intent(context, CategoryDetailsActivity.class);
+ intent.addFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT);
+ intent.putExtra("categoryName", categoryName);
+ context.startActivity(intent);
+ }
+
+ /**
+ * This method is called mediaDetailPagerFragment. It returns the Media Object at that Index
+ * @param i It is the index of which media object is to be returned which is same as
+ * current index of viewPager.
+ * @return Media Object
+ */
+ @Override
+ public Media getMediaAtPosition(int i) {
+ if (categoryImagesListFragment.getAdapter() == null) {
+ // not yet ready to return data
+ return null;
+ } else {
+ return (Media) categoryImagesListFragment.getAdapter().getItem(i);
+ }
+ }
+
+ /**
+ * This method is called on from getCount of MediaDetailPagerFragment
+ * The viewpager will contain same number of media items as that of media elements in adapter.
+ * @return Total Media count in the adapter
+ */
+ @Override
+ public int getTotalMediaCount() {
+ if (categoryImagesListFragment.getAdapter() == null) {
+ return 0;
+ }
+ return categoryImagesListFragment.getAdapter().getCount();
+ }
+
+ /**
+ * This method is never called but it was in MediaDetailProvider Interface
+ * so it needs to be overrided.
+ */
+ @Override
+ public void notifyDatasetChanged() {
+
+ }
+
+ /**
+ * This method is never called but it was in MediaDetailProvider Interface
+ * so it needs to be overrided.
+ */
+ @Override
+ public void registerDataSetObserver(DataSetObserver observer) {
+ }
+
+ /**
+ * This method is never called but it was in MediaDetailProvider Interface
+ * so it needs to be overrided.
+ */
+ @Override
+ public void unregisterDataSetObserver(DataSetObserver observer) {
+
+ }
+
+ /**
+ * This method inflates the menu in the toolbar
+ */
+ @Override
+ public boolean onCreateOptionsMenu(Menu menu) {
+ MenuInflater inflater = getMenuInflater();
+ inflater.inflate(R.menu.fragment_category_detail, menu);
+ return super.onCreateOptionsMenu(menu);
+ }
+
+ /**
+ * This method handles the logic on ItemSelect in toolbar menu
+ * Currently only 1 choice is available to open category details page in browser
+ */
+ @Override
+ public boolean onOptionsItemSelected(MenuItem item) {
+
+ // Handle item selection
+ switch (item.getItemId()) {
+ case R.id.menu_browser_current_category:
+ Intent viewIntent = new Intent();
+ viewIntent.setAction(Intent.ACTION_VIEW);
+ viewIntent.setData(new PageTitle(categoryName).getCanonicalUri());
+ //check if web browser available
+ if (viewIntent.resolveActivity(this.getPackageManager()) != null) {
+ startActivity(viewIntent);
+ } else {
+ Toast toast = Toast.makeText(this, getString(R.string.no_web_browser), LENGTH_SHORT);
+ toast.show();
+ }
+ return true;
+ default:
+ return super.onOptionsItemSelected(item);
+ }
+ }
+
+ /**
+ * This method is called on backPressed of anyFragment in the activity.
+ * If condition is called when mediaDetailFragment is opened.
+ */
+ @Override
+ public void onBackPressed() {
+ if (supportFragmentManager.getBackStackEntryCount() == 1){
+ // back to search so show search toolbar and hide navigation toolbar
+ tabLayout.setVisibility(View.VISIBLE);
+ viewPager.setVisibility(View.VISIBLE);
+ mediaContainer.setVisibility(View.GONE);
+ }
+ super.onBackPressed();
+ }
+}
diff --git a/app/src/main/java/fr/free/nrw/commons/category/CategoryImageUtils.java b/app/src/main/java/fr/free/nrw/commons/category/CategoryImageUtils.java
index 18749847e..941201235 100644
--- a/app/src/main/java/fr/free/nrw/commons/category/CategoryImageUtils.java
+++ b/app/src/main/java/fr/free/nrw/commons/category/CategoryImageUtils.java
@@ -8,6 +8,7 @@ import org.w3c.dom.NodeList;
import java.text.ParseException;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
+import java.util.Collections;
import java.util.Date;
import java.util.List;
@@ -27,12 +28,30 @@ public class CategoryImageUtils {
List categoryImages = new ArrayList<>();
for (int i = 0; i < childNodes.getLength(); i++) {
Node node = childNodes.item(i);
- categoryImages.add(getMediaFromPage(node));
+ if (getMediaFromPage(node).getFilename().substring(0,5).equals("File:")){
+ categoryImages.add(getMediaFromPage(node));
+ }
}
return categoryImages;
}
+ /**
+ * The method iterates over the child nodes to return a list of Subcategory name
+ * sorted alphabetically
+ * @param childNodes
+ * @return
+ */
+ public static List getSubCategoryList(NodeList childNodes) {
+ List subCategories = new ArrayList<>();
+ for (int i = 0; i < childNodes.getLength(); i++) {
+ Node node = childNodes.item(i);
+ subCategories.add(getMediaFromPage(node).getFilename());
+ }
+ Collections.sort(subCategories);
+ return subCategories;
+ }
+
/**
* Creates a new Media object from the XML response as received by the API
* @param node
diff --git a/app/src/main/java/fr/free/nrw/commons/category/CategoryImagesActivity.java b/app/src/main/java/fr/free/nrw/commons/category/CategoryImagesActivity.java
index 1f385b258..382134472 100644
--- a/app/src/main/java/fr/free/nrw/commons/category/CategoryImagesActivity.java
+++ b/app/src/main/java/fr/free/nrw/commons/category/CategoryImagesActivity.java
@@ -6,6 +6,9 @@ import android.database.DataSetObserver;
import android.os.Bundle;
import android.support.v4.app.FragmentManager;
import android.support.v4.app.FragmentTransaction;
+import android.view.Menu;
+import android.view.MenuInflater;
+import android.view.MenuItem;
import android.view.View;
import android.widget.AdapterView;
@@ -13,8 +16,9 @@ import butterknife.ButterKnife;
import fr.free.nrw.commons.Media;
import fr.free.nrw.commons.R;
import fr.free.nrw.commons.auth.AuthenticatedActivity;
+import fr.free.nrw.commons.explore.SearchActivity;
import fr.free.nrw.commons.media.MediaDetailPagerFragment;
-import timber.log.Timber;
+import fr.free.nrw.commons.theme.NavigationBaseActivity;
/**
* This activity displays pictures of a particular category
@@ -44,6 +48,16 @@ public class CategoryImagesActivity
}
+ /**
+ * This method is called on backPressed of anyFragment in the activity.
+ * We are changing the icon here from back to hamburger icon.
+ */
+ @Override
+ public void onBackPressed() {
+ initDrawer();
+ super.onBackPressed();
+ }
+
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
@@ -55,11 +69,6 @@ public class CategoryImagesActivity
supportFragmentManager = getSupportFragmentManager();
setCategoryImagesFragment();
supportFragmentManager.addOnBackStackChangedListener(this);
- if (savedInstanceState != null) {
- mediaDetails = (MediaDetailPagerFragment) supportFragmentManager
- .findFragmentById(R.id.fragmentContainer);
-
- }
requestAuthToken();
initDrawer();
setPageTitle();
@@ -95,6 +104,9 @@ public class CategoryImagesActivity
public void onBackStackChanged() {
}
+ /**
+ * This method is called onClick of media inside category details (CategoryImageListFragment).
+ */
@Override
public void onItemClick(AdapterView> adapterView, View view, int i, long l) {
if (mediaDetails == null || !mediaDetails.isVisible()) {
@@ -103,17 +115,34 @@ public class CategoryImagesActivity
FragmentManager supportFragmentManager = getSupportFragmentManager();
supportFragmentManager
.beginTransaction()
- .replace(R.id.fragmentContainer, mediaDetails)
+ .hide(supportFragmentManager.getFragments().get(supportFragmentManager.getBackStackEntryCount()))
+ .add(R.id.fragmentContainer, mediaDetails)
.addToBackStack(null)
.commit();
- supportFragmentManager.executePendingTransactions();
+ // Reason for using hide, add instead of replace is to maintain scroll position after
+ // coming back to the search activity. See https://github.com/commons-app/apps-android-commons/issues/1631
+ // https://stackoverflow.com/questions/11353075/how-can-i-maintain-fragment-state-when-added-to-the-back-stack/19022550#19022550 supportFragmentManager.executePendingTransactions();
}
mediaDetails.showImage(i);
+ forceInitBackButton();
+ }
+
+ /**
+ * This method is called on backPressed when mediaDetailFragment is opened in the activity.
+ */
+ @Override
+ protected void onResume() {
+ if (supportFragmentManager.getBackStackEntryCount()==1){
+ //FIXME: Temporary fix for screen rotation inside media details. If we don't call onBackPressed then fragment stack is increasing every time.
+ //FIXME: Similar issue like this https://github.com/commons-app/apps-android-commons/issues/894
+ onBackPressed();
+ }
+ super.onResume();
}
/**
* Consumers should be simply using this method to use this activity.
- * @param context
+ * @param context A Context of the application package implementing this class.
* @param title Page title
* @param categoryName Name of the category for displaying its images
*/
@@ -125,6 +154,12 @@ public class CategoryImagesActivity
context.startActivity(intent);
}
+ /**
+ * This method is called mediaDetailPagerFragment. It returns the Media Object at that Index
+ * @param i It is the index of which media object is to be returned which is same as
+ * current index of viewPager.
+ * @return Media Object
+ */
@Override
public Media getMediaAtPosition(int i) {
if (categoryImagesListFragment.getAdapter() == null) {
@@ -135,6 +170,11 @@ public class CategoryImagesActivity
}
}
+ /**
+ * This method is called on from getCount of MediaDetailPagerFragment
+ * The viewpager will contain same number of media items as that of media elements in adapter.
+ * @return Total Media count in the adapter
+ */
@Override
public int getTotalMediaCount() {
if (categoryImagesListFragment.getAdapter() == null) {
@@ -143,18 +183,57 @@ public class CategoryImagesActivity
return categoryImagesListFragment.getAdapter().getCount();
}
+ /**
+ * This method is never called but it was in MediaDetailProvider Interface
+ * so it needs to be overrided.
+ */
@Override
public void notifyDatasetChanged() {
}
+ /**
+ * This method is never called but it was in MediaDetailProvider Interface
+ * so it needs to be overrided.
+ */
@Override
public void registerDataSetObserver(DataSetObserver observer) {
}
+ /**
+ * This method is never called but it was in MediaDetailProvider Interface
+ * so it needs to be overrided.
+ */
@Override
public void unregisterDataSetObserver(DataSetObserver observer) {
}
+
+ /**
+ * This method inflates the menu in the toolbar
+ */
+ @Override
+ public boolean onCreateOptionsMenu(Menu menu) {
+ MenuInflater inflater = getMenuInflater();
+ inflater.inflate(R.menu.menu_search, menu);
+ return super.onCreateOptionsMenu(menu);
+ }
+
+ /**
+ * This method handles the logic on ItemSelect in toolbar menu
+ * Currently only 1 choice is available to open search page of the app
+ */
+ @Override
+ public boolean onOptionsItemSelected(MenuItem item) {
+
+ // Handle item selection
+ switch (item.getItemId()) {
+ case R.id.action_search:
+ NavigationBaseActivity.startActivityWithFlags(this, SearchActivity.class);
+ return true;
+ default:
+ return super.onOptionsItemSelected(item);
+ }
+ }
}
diff --git a/app/src/main/java/fr/free/nrw/commons/category/CategoryImagesListFragment.java b/app/src/main/java/fr/free/nrw/commons/category/CategoryImagesListFragment.java
index 3b6734edd..385662a05 100644
--- a/app/src/main/java/fr/free/nrw/commons/category/CategoryImagesListFragment.java
+++ b/app/src/main/java/fr/free/nrw/commons/category/CategoryImagesListFragment.java
@@ -12,7 +12,9 @@ import android.widget.AdapterView;
import android.widget.GridView;
import android.widget.ListAdapter;
import android.widget.ProgressBar;
+import android.widget.RelativeLayout;
import android.widget.TextView;
+import android.widget.Toast;
import java.util.List;
import java.util.concurrent.TimeUnit;
@@ -48,9 +50,9 @@ public class CategoryImagesListFragment extends DaggerFragment {
TextView statusTextView;
@BindView(R.id.loadingImagesProgressBar) ProgressBar progressBar;
@BindView(R.id.categoryImagesList) GridView gridView;
-
+ @BindView(R.id.parentLayout) RelativeLayout parentLayout;
private boolean hasMoreImages = true;
- private boolean isLoading;
+ private boolean isLoading = true;
private String categoryName = null;
@Inject CategoryImageController controller;
@@ -123,7 +125,7 @@ public class CategoryImagesListFragment extends DaggerFragment {
statusTextView.setVisibility(VISIBLE);
statusTextView.setText(getString(R.string.no_internet));
} else {
- ViewUtil.showSnackbar(gridView, R.string.no_internet);
+ ViewUtil.showSnackbar(parentLayout, R.string.no_internet);
}
}
@@ -132,15 +134,20 @@ public class CategoryImagesListFragment extends DaggerFragment {
* @param throwable
*/
private void handleError(Throwable throwable) {
- Timber.e(throwable, "Error occurred while loading featured images");
- initErrorView();
+ Timber.e(throwable, "Error occurred while loading images inside a category");
+ try{
+ ViewUtil.showSnackbar(parentLayout, R.string.error_loading_images);
+ initErrorView();
+ }catch (Exception e){
+ e.printStackTrace();
+ }
+
}
/**
* Handles the UI updates for a error scenario
*/
private void initErrorView() {
- ViewUtil.showSnackbar(gridView, R.string.error_loading_images);
progressBar.setVisibility(GONE);
if (gridAdapter == null || gridAdapter.isEmpty()) {
statusTextView.setVisibility(VISIBLE);
@@ -152,7 +159,7 @@ public class CategoryImagesListFragment extends DaggerFragment {
/**
* Initializes the adapter with a list of Media objects
- * @param mediaList
+ * @param mediaList List of new Media to be displayed
*/
private void setAdapter(List mediaList) {
gridAdapter = new GridViewAdapter(this.getContext(), R.layout.layout_category_images, mediaList);
@@ -176,6 +183,9 @@ public class CategoryImagesListFragment extends DaggerFragment {
isLoading = true;
fetchMoreImages();
}
+ if (!hasMoreImages){
+ progressBar.setVisibility(GONE);
+ }
}
});
}
@@ -201,7 +211,7 @@ public class CategoryImagesListFragment extends DaggerFragment {
/**
* Handles the success scenario
* On first load, it initializes the grid view. On subsequent loads, it adds items to the adapter
- * @param collection
+ * @param collection List of new Media to be displayed
*/
private void handleSuccess(List collection) {
if(collection == null || collection.isEmpty()) {
@@ -213,6 +223,10 @@ public class CategoryImagesListFragment extends DaggerFragment {
if(gridAdapter == null) {
setAdapter(collection);
} else {
+ if (gridAdapter.containsAll(collection)) {
+ hasMoreImages = false;
+ return;
+ }
gridAdapter.addItems(collection);
}
@@ -221,7 +235,13 @@ public class CategoryImagesListFragment extends DaggerFragment {
statusTextView.setVisibility(GONE);
}
+ /**
+ * It return an instance of gridView adapter which helps in extracting media details
+ * used by the gridView
+ * @return GridView Adapter
+ */
public ListAdapter getAdapter() {
return gridView.getAdapter();
}
+
}
diff --git a/app/src/main/java/fr/free/nrw/commons/category/GridViewAdapter.java b/app/src/main/java/fr/free/nrw/commons/category/GridViewAdapter.java
index c8e6066f6..f8c54905e 100644
--- a/app/src/main/java/fr/free/nrw/commons/category/GridViewAdapter.java
+++ b/app/src/main/java/fr/free/nrw/commons/category/GridViewAdapter.java
@@ -42,6 +42,18 @@ public class GridViewAdapter extends ArrayAdapter {
notifyDataSetChanged();
}
+ /**
+ * Check the first item in the new list with old list and returns true if they are same
+ * Its triggered on successful response of the fetch images API.
+ * @param images
+ */
+ public boolean containsAll(List images){
+ if (data == null) {
+ data = new ArrayList<>();
+ }
+ return images.get(0).getFilename().equals(data.get(0).getFilename());
+ }
+
@Override
public boolean isEmpty() {
return data == null || data.isEmpty();
@@ -66,7 +78,7 @@ public class GridViewAdapter extends ArrayAdapter {
MediaWikiImageView imageView = convertView.findViewById(R.id.categoryImageView);
TextView fileName = convertView.findViewById(R.id.categoryImageTitle);
TextView author = convertView.findViewById(R.id.categoryImageAuthor);
- fileName.setText(item.getFilename());
+ fileName.setText(item.getDisplayTitle());
setAuthorView(item, author);
imageView.setMedia(item);
return convertView;
diff --git a/app/src/main/java/fr/free/nrw/commons/category/SubCategoryListFragment.java b/app/src/main/java/fr/free/nrw/commons/category/SubCategoryListFragment.java
new file mode 100644
index 000000000..d3000e9b6
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/category/SubCategoryListFragment.java
@@ -0,0 +1,167 @@
+package fr.free.nrw.commons.category;
+
+
+import android.content.Intent;
+import android.content.res.Configuration;
+import android.os.Bundle;
+import android.support.v7.widget.GridLayoutManager;
+import android.support.v7.widget.LinearLayoutManager;
+import android.support.v7.widget.RecyclerView;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+import android.widget.ProgressBar;
+import android.widget.TextView;
+import android.widget.Toast;
+
+import com.pedrogomez.renderers.RVRendererAdapter;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+
+import javax.inject.Inject;
+
+import butterknife.BindView;
+import butterknife.ButterKnife;
+import fr.free.nrw.commons.R;
+import fr.free.nrw.commons.di.CommonsDaggerSupportFragment;
+import fr.free.nrw.commons.explore.categories.SearchCategoriesAdapterFactory;
+import fr.free.nrw.commons.mwapi.MediaWikiApi;
+import fr.free.nrw.commons.utils.NetworkUtils;
+import fr.free.nrw.commons.utils.ViewUtil;
+import io.reactivex.Observable;
+import io.reactivex.android.schedulers.AndroidSchedulers;
+import io.reactivex.schedulers.Schedulers;
+import timber.log.Timber;
+
+import static android.view.View.GONE;
+import static android.view.View.VISIBLE;
+
+/**
+ * Displays the category search screen.
+ */
+
+public class SubCategoryListFragment extends CommonsDaggerSupportFragment {
+
+ private static int TIMEOUT_SECONDS = 15;
+
+ @BindView(R.id.imagesListBox)
+ RecyclerView categoriesRecyclerView;
+ @BindView(R.id.imageSearchInProgress)
+ ProgressBar progressBar;
+ @BindView(R.id.imagesNotFound)
+ TextView categoriesNotFoundView;
+
+ private String categoryName = null;
+ @Inject MediaWikiApi mwApi;
+
+ private RVRendererAdapter categoriesAdapter;
+ private boolean isParentCategory = true;
+
+ private final SearchCategoriesAdapterFactory adapterFactory = new SearchCategoriesAdapterFactory(item -> {
+ // Open SubCategory Details page
+ Intent intent = new Intent(getContext(), CategoryDetailsActivity.class);
+ intent.putExtra("categoryName", item);
+ getContext().startActivity(intent);
+
+ });
+
+ @Override
+ public View onCreateView(LayoutInflater inflater, ViewGroup container,Bundle savedInstanceState) {
+ View rootView = inflater.inflate(R.layout.fragment_browse_image, container, false);
+ ButterKnife.bind(this, rootView);
+ categoryName = getArguments().getString("categoryName");
+ isParentCategory = getArguments().getBoolean("isParentCategory");
+ initSubCategoryList();
+ if(getActivity().getResources().getConfiguration().orientation == Configuration.ORIENTATION_PORTRAIT){
+ categoriesRecyclerView.setLayoutManager(new LinearLayoutManager(getContext()));
+ }
+ else{
+ categoriesRecyclerView.setLayoutManager(new GridLayoutManager(getContext(), 2));
+ }
+ ArrayList items = new ArrayList<>();
+ categoriesAdapter = adapterFactory.create(items);
+ categoriesRecyclerView.setAdapter(categoriesAdapter);
+ return rootView;
+ }
+
+ /**
+ * Checks for internet connection and then initializes the recycler view with 25 categories of the searched query
+ * Clearing categoryAdapter every time new keyword is searched so that user can see only new results
+ */
+ public void initSubCategoryList() {
+ categoriesNotFoundView.setVisibility(GONE);
+ if(!NetworkUtils.isInternetConnectionEstablished(getContext())) {
+ handleNoInternet();
+ return;
+ }
+ progressBar.setVisibility(View.VISIBLE);
+ if (!isParentCategory){
+ Observable.fromCallable(() -> mwApi.getSubCategoryList(categoryName))
+ .subscribeOn(Schedulers.io())
+ .observeOn(AndroidSchedulers.mainThread())
+ .timeout(TIMEOUT_SECONDS, TimeUnit.SECONDS)
+ .subscribe(this::handleSuccess, this::handleError);
+ }else {
+ Observable.fromCallable(() -> mwApi.getParentCategoryList(categoryName))
+ .subscribeOn(Schedulers.io())
+ .observeOn(AndroidSchedulers.mainThread())
+ .timeout(TIMEOUT_SECONDS, TimeUnit.SECONDS)
+ .subscribe(this::handleSuccess, this::handleError);
+ }
+ }
+
+
+ /**
+ * Handles the success scenario
+ * it initializes the recycler view by adding items to the adapter
+ * @param subCategoryList
+ */
+ private void handleSuccess(List subCategoryList) {
+ if(subCategoryList == null || subCategoryList.isEmpty()) {
+ initEmptyView();
+ }
+ else {
+ progressBar.setVisibility(View.GONE);
+ categoriesAdapter.addAll(subCategoryList);
+ categoriesAdapter.notifyDataSetChanged();
+ }
+ }
+
+ /**
+ * Logs and handles API error scenario
+ * @param throwable
+ */
+ private void handleError(Throwable throwable) {
+ if (!isParentCategory){
+ Timber.e(throwable, "Error occurred while loading queried subcategories");
+ ViewUtil.showSnackbar(categoriesRecyclerView,R.string.error_loading_categories);
+ }else {
+ Timber.e(throwable, "Error occurred while loading queried parentcategories");
+ ViewUtil.showSnackbar(categoriesRecyclerView,R.string.error_loading_categories);
+ }
+ }
+
+ /**
+ * Handles the UI updates for a empty results scenario
+ */
+ private void initEmptyView() {
+ progressBar.setVisibility(GONE);
+ categoriesNotFoundView.setVisibility(VISIBLE);
+ if (!isParentCategory){
+ categoriesNotFoundView.setText(getString(R.string.no_subcategory_found));
+ }else {
+ categoriesNotFoundView.setText(getString(R.string.no_parentcategory_found));
+ }
+
+ }
+
+ /**
+ * Handles the UI updates for no internet scenario
+ */
+ private void handleNoInternet() {
+ progressBar.setVisibility(GONE);
+ ViewUtil.showSnackbar(categoriesRecyclerView, R.string.no_internet);
+ }
+}
diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/Contribution.java b/app/src/main/java/fr/free/nrw/commons/contributions/Contribution.java
index 7861f96de..99009c029 100644
--- a/app/src/main/java/fr/free/nrw/commons/contributions/Contribution.java
+++ b/app/src/main/java/fr/free/nrw/commons/contributions/Contribution.java
@@ -45,6 +45,7 @@ public class Contribution extends Media {
private long transferred;
private String decimalCoords;
private boolean isMultiple;
+ private String wikiDataEntityId;
public Contribution(Uri contentUri, String filename, Uri localUri, String imageUrl, Date timestamp,
int state, long dataLength, Date dateUploaded, long transferred,
@@ -222,4 +223,17 @@ public class Contribution extends Media {
throw new RuntimeException("Unrecognized license value: " + license);
}
+
+ public String getWikiDataEntityId() {
+ return wikiDataEntityId;
+ }
+
+ /**
+ * When the corresponding wikidata entity is known as in case of nearby uploads, it can be set
+ * using the setter method
+ * @param wikiDataEntityId
+ */
+ public void setWikiDataEntityId(String wikiDataEntityId) {
+ this.wikiDataEntityId = wikiDataEntityId;
+ }
}
diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java
index 37b3d5377..76f3e5a0f 100644
--- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java
+++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java
@@ -24,6 +24,7 @@ import static android.content.Intent.EXTRA_STREAM;
import static fr.free.nrw.commons.contributions.Contribution.SOURCE_CAMERA;
import static fr.free.nrw.commons.contributions.Contribution.SOURCE_GALLERY;
import static fr.free.nrw.commons.upload.UploadService.EXTRA_SOURCE;
+import static fr.free.nrw.commons.wikidata.WikidataConstants.WIKIDATA_ENTITY_ID_PREF;
public class ContributionController {
@@ -90,7 +91,8 @@ public class ContributionController {
fragment.startActivityForResult(pickImageIntent, SELECT_FROM_GALLERY);
}
- public void handleImagePicked(int requestCode, Intent data, boolean isDirectUpload) {
+ public void handleImagePicked(int requestCode, Intent data, boolean isDirectUpload, String wikiDataEntityId) {
+ Timber.d("Is direct upload %s and the Wikidata entity ID is %s", isDirectUpload, wikiDataEntityId);
FragmentActivity activity = fragment.getActivity();
Timber.d("handleImagePicked() called with onActivityResult()");
Intent shareIntent = new Intent(activity, ShareActivity.class);
@@ -102,9 +104,6 @@ public class ContributionController {
shareIntent.setType(activity.getContentResolver().getType(imageData));
shareIntent.putExtra(EXTRA_STREAM, imageData);
shareIntent.putExtra(EXTRA_SOURCE, SOURCE_GALLERY);
- if (isDirectUpload) {
- shareIntent.putExtra("isDirectUpload", true);
- }
break;
case SELECT_FROM_CAMERA:
//FIXME: Find out appropriate mime type
@@ -113,9 +112,6 @@ public class ContributionController {
shareIntent.setType("image/jpeg");
shareIntent.putExtra(EXTRA_STREAM, lastGeneratedCaptureUri);
shareIntent.putExtra(EXTRA_SOURCE, SOURCE_CAMERA);
- if (isDirectUpload) {
- shareIntent.putExtra("isDirectUpload", true);
- }
break;
default:
@@ -123,6 +119,10 @@ public class ContributionController {
}
Timber.i("Image selected");
try {
+ shareIntent.putExtra("isDirectUpload", isDirectUpload);
+ if (wikiDataEntityId != null && !wikiDataEntityId.equals("")) {
+ shareIntent.putExtra(WIKIDATA_ENTITY_ID_PREF, wikiDataEntityId);
+ }
activity.startActivity(shareIntent);
} catch (SecurityException e) {
Timber.e(e, "Security Exception");
diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionDao.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionDao.java
index 079cf6477..6d290b1a5 100644
--- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionDao.java
+++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionDao.java
@@ -8,7 +8,6 @@ import android.net.Uri;
import android.os.RemoteException;
import android.support.annotation.Nullable;
import android.text.TextUtils;
-import android.util.Log;
import java.util.Date;
diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java
index ad6cff606..e5f6f53bb 100644
--- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java
+++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java
@@ -276,17 +276,25 @@ public class ContributionsActivity
.getUploadCount(sessionManager.getCurrentAccount().name)
.subscribeOn(Schedulers.io())
.observeOn(AndroidSchedulers.mainThread())
- .subscribe(
- uploadCount -> getSupportActionBar().setSubtitle(getResources()
- .getQuantityString(R.plurals.contributions_subtitle,
- uploadCount, uploadCount)),
+ .subscribe(this::displayUploadCount,
t -> Timber.e(t, "Fetching upload count failed")
));
}
- public void betaSetUploadCount(int betaUploadCount){
+ private void displayUploadCount(Integer uploadCount) {
+ if (isFinishing()
+ || getSupportActionBar() == null
+ || getResources() == null) {
+ return;
+ }
+
getSupportActionBar().setSubtitle(getResources()
- .getQuantityString(R.plurals.contributions_subtitle, betaUploadCount, betaUploadCount));
+ .getQuantityString(R.plurals.contributions_subtitle,
+ uploadCount, uploadCount));
+ }
+
+ public void betaSetUploadCount(int betaUploadCount) {
+ displayUploadCount(betaUploadCount);
}
diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java
index ff400a8dd..0b600c5d0 100644
--- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java
+++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java
@@ -117,7 +117,7 @@ public class ContributionsListFragment extends CommonsDaggerSupportFragment {
if (resultCode == RESULT_OK) {
Timber.d("OnActivityResult() parameters: Req code: %d Result code: %d Data: %s",
requestCode, resultCode, data);
- controller.handleImagePicked(requestCode, data, false);
+ controller.handleImagePicked(requestCode, data, false, null);
} else {
Timber.e("OnActivityResult() parameters: Req code: %d Result code: %d Data: %s",
requestCode, resultCode, data);
diff --git a/app/src/main/java/fr/free/nrw/commons/data/DBOpenHelper.java b/app/src/main/java/fr/free/nrw/commons/data/DBOpenHelper.java
index 35305c5ba..b019a6303 100644
--- a/app/src/main/java/fr/free/nrw/commons/data/DBOpenHelper.java
+++ b/app/src/main/java/fr/free/nrw/commons/data/DBOpenHelper.java
@@ -6,12 +6,13 @@ import android.database.sqlite.SQLiteOpenHelper;
import fr.free.nrw.commons.category.CategoryDao;
import fr.free.nrw.commons.contributions.ContributionDao;
+import fr.free.nrw.commons.explore.recentsearches.RecentSearchesDao;
import fr.free.nrw.commons.modifications.ModifierSequenceDao;
public class DBOpenHelper extends SQLiteOpenHelper {
private static final String DATABASE_NAME = "commons.db";
- private static final int DATABASE_VERSION = 6;
+ private static final int DATABASE_VERSION = 7;
/**
* Do not use directly - @Inject an instance where it's needed and let
@@ -26,6 +27,7 @@ public class DBOpenHelper extends SQLiteOpenHelper {
ContributionDao.Table.onCreate(sqLiteDatabase);
ModifierSequenceDao.Table.onCreate(sqLiteDatabase);
CategoryDao.Table.onCreate(sqLiteDatabase);
+ RecentSearchesDao.Table.onCreate(sqLiteDatabase);
}
@Override
@@ -33,5 +35,6 @@ public class DBOpenHelper extends SQLiteOpenHelper {
ContributionDao.Table.onUpdate(sqLiteDatabase, from, to);
ModifierSequenceDao.Table.onUpdate(sqLiteDatabase, from, to);
CategoryDao.Table.onUpdate(sqLiteDatabase, from, to);
+ RecentSearchesDao.Table.onUpdate(sqLiteDatabase, from, to);
}
}
diff --git a/app/src/main/java/fr/free/nrw/commons/di/ActivityBuilderModule.java b/app/src/main/java/fr/free/nrw/commons/di/ActivityBuilderModule.java
index 51aa85903..70ffec55f 100644
--- a/app/src/main/java/fr/free/nrw/commons/di/ActivityBuilderModule.java
+++ b/app/src/main/java/fr/free/nrw/commons/di/ActivityBuilderModule.java
@@ -4,10 +4,14 @@ import dagger.Module;
import dagger.android.ContributesAndroidInjector;
import fr.free.nrw.commons.AboutActivity;
import fr.free.nrw.commons.WelcomeActivity;
+import fr.free.nrw.commons.achievements.AchievementsActivity;
import fr.free.nrw.commons.auth.LoginActivity;
import fr.free.nrw.commons.auth.SignupActivity;
+import fr.free.nrw.commons.category.CategoryDetailsActivity;
import fr.free.nrw.commons.contributions.ContributionsActivity;
import fr.free.nrw.commons.category.CategoryImagesActivity;
+import fr.free.nrw.commons.explore.SearchActivity;
+
import fr.free.nrw.commons.nearby.NearbyActivity;
import fr.free.nrw.commons.notification.NotificationActivity;
import fr.free.nrw.commons.settings.SettingsActivity;
@@ -50,4 +54,14 @@ public abstract class ActivityBuilderModule {
@ContributesAndroidInjector
abstract CategoryImagesActivity bindFeaturedImagesActivity();
+
+ @ContributesAndroidInjector
+ abstract SearchActivity bindSearchActivity();
+
+ @ContributesAndroidInjector
+ abstract CategoryDetailsActivity bindCategoryDetailsActivity();
+
+ @ContributesAndroidInjector
+ abstract AchievementsActivity bindAchievementsActivity();
+
}
diff --git a/app/src/main/java/fr/free/nrw/commons/di/CommonsApplicationComponent.java b/app/src/main/java/fr/free/nrw/commons/di/CommonsApplicationComponent.java
index 91f6d4ccb..43721a217 100644
--- a/app/src/main/java/fr/free/nrw/commons/di/CommonsApplicationComponent.java
+++ b/app/src/main/java/fr/free/nrw/commons/di/CommonsApplicationComponent.java
@@ -9,17 +9,18 @@ import dagger.android.support.AndroidSupportInjectionModule;
import fr.free.nrw.commons.CommonsApplication;
import fr.free.nrw.commons.MediaWikiImageView;
import fr.free.nrw.commons.auth.LoginActivity;
-import fr.free.nrw.commons.contributions.Contribution;
-import fr.free.nrw.commons.contributions.ContributionsActivity;
import fr.free.nrw.commons.contributions.ContributionsSyncAdapter;
import fr.free.nrw.commons.delete.DeleteTask;
import fr.free.nrw.commons.modifications.ModificationsSyncAdapter;
-import fr.free.nrw.commons.settings.SettingsFragment;
import fr.free.nrw.commons.nearby.PlaceRenderer;
+import fr.free.nrw.commons.upload.FileProcessor;
+import fr.free.nrw.commons.settings.SettingsFragment;
+
@Singleton
@Component(modules = {
CommonsApplicationModule.class,
+ NetworkingModule.class,
AndroidInjectionModule.class,
AndroidSupportInjectionModule.class,
ActivityBuilderModule.class,
@@ -47,6 +48,8 @@ public interface CommonsApplicationComponent extends AndroidInjector provideLruCache() {
return new LruCache<>(1024);
}
+
+ @Provides
+ @Singleton
+ public WikidataEditListener provideWikidataEditListener() {
+ return new WikidataEditListenerImpl();
+ }
}
\ No newline at end of file
diff --git a/app/src/main/java/fr/free/nrw/commons/di/ContentProviderBuilderModule.java b/app/src/main/java/fr/free/nrw/commons/di/ContentProviderBuilderModule.java
index f18c331c5..0db0ff7fb 100644
--- a/app/src/main/java/fr/free/nrw/commons/di/ContentProviderBuilderModule.java
+++ b/app/src/main/java/fr/free/nrw/commons/di/ContentProviderBuilderModule.java
@@ -4,6 +4,7 @@ import dagger.Module;
import dagger.android.ContributesAndroidInjector;
import fr.free.nrw.commons.category.CategoryContentProvider;
import fr.free.nrw.commons.contributions.ContributionsContentProvider;
+import fr.free.nrw.commons.explore.recentsearches.RecentSearchesContentProvider;
import fr.free.nrw.commons.modifications.ModificationsContentProvider;
@Module
@@ -19,4 +20,7 @@ public abstract class ContentProviderBuilderModule {
@ContributesAndroidInjector
abstract CategoryContentProvider bindCategoryContentProvider();
+ @ContributesAndroidInjector
+ abstract RecentSearchesContentProvider bindRecentSearchesContentProvider();
+
}
diff --git a/app/src/main/java/fr/free/nrw/commons/di/FragmentBuilderModule.java b/app/src/main/java/fr/free/nrw/commons/di/FragmentBuilderModule.java
index dfed64871..b14d8feef 100644
--- a/app/src/main/java/fr/free/nrw/commons/di/FragmentBuilderModule.java
+++ b/app/src/main/java/fr/free/nrw/commons/di/FragmentBuilderModule.java
@@ -3,8 +3,12 @@ package fr.free.nrw.commons.di;
import dagger.Module;
import dagger.android.ContributesAndroidInjector;
import fr.free.nrw.commons.category.CategorizationFragment;
+import fr.free.nrw.commons.category.SubCategoryListFragment;
import fr.free.nrw.commons.contributions.ContributionsListFragment;
import fr.free.nrw.commons.category.CategoryImagesListFragment;
+import fr.free.nrw.commons.explore.categories.SearchCategoryFragment;
+import fr.free.nrw.commons.explore.images.SearchImageFragment;
+import fr.free.nrw.commons.explore.recentsearches.RecentSearchesFragment;
import fr.free.nrw.commons.media.MediaDetailFragment;
import fr.free.nrw.commons.media.MediaDetailPagerFragment;
import fr.free.nrw.commons.nearby.NearbyListFragment;
@@ -51,4 +55,16 @@ public abstract class FragmentBuilderModule {
@ContributesAndroidInjector
abstract CategoryImagesListFragment bindFeaturedImagesListFragment();
+ @ContributesAndroidInjector
+ abstract SubCategoryListFragment bindSubCategoryListFragment();
+
+ @ContributesAndroidInjector
+ abstract SearchImageFragment bindBrowseImagesListFragment();
+
+ @ContributesAndroidInjector
+ abstract SearchCategoryFragment bindSearchCategoryListFragment();
+
+ @ContributesAndroidInjector
+ abstract RecentSearchesFragment bindRecentSearchesFragment();
+
}
diff --git a/app/src/main/java/fr/free/nrw/commons/di/NetworkingModule.java b/app/src/main/java/fr/free/nrw/commons/di/NetworkingModule.java
new file mode 100644
index 000000000..cd043e950
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/di/NetworkingModule.java
@@ -0,0 +1,59 @@
+package fr.free.nrw.commons.di;
+
+import android.content.Context;
+import android.content.SharedPreferences;
+import android.support.annotation.NonNull;
+
+import com.google.gson.Gson;
+import com.google.gson.GsonBuilder;
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import dagger.Module;
+import dagger.Provides;
+import fr.free.nrw.commons.BuildConfig;
+import fr.free.nrw.commons.mwapi.ApacheHttpClientMediaWikiApi;
+import fr.free.nrw.commons.mwapi.MediaWikiApi;
+import okhttp3.HttpUrl;
+import okhttp3.OkHttpClient;
+
+@Module
+@SuppressWarnings({"WeakerAccess", "unused"})
+public class NetworkingModule {
+ public static final long OK_HTTP_CACHE_SIZE = 10 * 1024 * 1024;
+
+ @Provides
+ @Singleton
+ public OkHttpClient provideOkHttpClient() {
+ return new OkHttpClient.Builder().build();
+ }
+
+ @Provides
+ @Singleton
+ public MediaWikiApi provideMediaWikiApi(Context context,
+ @Named("default_preferences") SharedPreferences defaultPreferences,
+ @Named("category_prefs") SharedPreferences categoryPrefs,
+ Gson gson) {
+ return new ApacheHttpClientMediaWikiApi(context, BuildConfig.WIKIMEDIA_API_HOST, BuildConfig.WIKIDATA_API_HOST, defaultPreferences, categoryPrefs, gson);
+ }
+
+ @Provides
+ @Named("commons_mediawiki_url")
+ @NonNull
+ @SuppressWarnings("ConstantConditions")
+ public HttpUrl provideMwUrl() {
+ return HttpUrl.parse(BuildConfig.COMMONS_URL);
+ }
+
+ /**
+ * Gson objects are very heavy. The app should ideally be using just one instance of it instead of creating new instances everywhere.
+ * @return returns a singleton Gson instance
+ */
+ @Provides
+ @Singleton
+ public Gson provideGson() {
+ return new GsonBuilder().create();
+ }
+
+}
diff --git a/app/src/main/java/fr/free/nrw/commons/explore/SearchActivity.java b/app/src/main/java/fr/free/nrw/commons/explore/SearchActivity.java
new file mode 100644
index 000000000..f28065eb5
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/explore/SearchActivity.java
@@ -0,0 +1,243 @@
+package fr.free.nrw.commons.explore;
+
+import android.database.DataSetObserver;
+import android.os.Bundle;
+import android.support.design.widget.TabLayout;
+import android.support.v4.app.Fragment;
+import android.support.v4.app.FragmentManager;
+import android.support.v4.app.FragmentTransaction;
+import android.support.v4.view.ViewPager;
+import android.support.v7.widget.Toolbar;
+import android.text.TextUtils;
+import android.view.View;
+import android.widget.FrameLayout;
+import android.widget.SearchView;
+import android.widget.Toast;
+
+import com.jakewharton.rxbinding2.view.RxView;
+import com.jakewharton.rxbinding2.widget.RxSearchView;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+
+import butterknife.BindView;
+import butterknife.ButterKnife;
+import fr.free.nrw.commons.Media;
+import fr.free.nrw.commons.R;
+import fr.free.nrw.commons.explore.categories.SearchCategoryFragment;
+import fr.free.nrw.commons.explore.images.SearchImageFragment;
+import fr.free.nrw.commons.explore.recentsearches.RecentSearchesFragment;
+import fr.free.nrw.commons.media.MediaDetailPagerFragment;
+import fr.free.nrw.commons.theme.NavigationBaseActivity;
+import fr.free.nrw.commons.utils.ViewUtil;
+import io.reactivex.android.schedulers.AndroidSchedulers;
+
+/**
+ * Represents search screen of this app
+ */
+
+public class SearchActivity extends NavigationBaseActivity implements MediaDetailPagerFragment.MediaDetailProvider{
+
+ @BindView(R.id.toolbar_search) Toolbar toolbar;
+ @BindView(R.id.searchHistoryContainer) FrameLayout searchHistoryContainer;
+ @BindView(R.id.mediaContainer) FrameLayout mediaContainer;
+ @BindView(R.id.searchBox) SearchView searchView;
+ @BindView(R.id.tabLayout) TabLayout tabLayout;
+ @BindView(R.id.viewPager) ViewPager viewPager;
+
+ private SearchImageFragment searchImageFragment;
+ private SearchCategoryFragment searchCategoryFragment;
+ private RecentSearchesFragment recentSearchesFragment;
+ private FragmentManager supportFragmentManager;
+ private MediaDetailPagerFragment mediaDetails;
+ ViewPagerAdapter viewPagerAdapter;
+
+ @Override
+ protected void onCreate(Bundle savedInstanceState) {
+ super.onCreate(savedInstanceState);
+ setContentView(R.layout.activity_search);
+ ButterKnife.bind(this);
+ initDrawer();
+ setTitle(getString(R.string.title_activity_search));
+ toolbar.setNavigationOnClickListener(v->onBackPressed());
+ supportFragmentManager = getSupportFragmentManager();
+ setSearchHistoryFragment();
+ viewPagerAdapter = new ViewPagerAdapter(getSupportFragmentManager());
+ viewPager.setAdapter(viewPagerAdapter);
+ tabLayout.setupWithViewPager(viewPager);
+ setTabs();
+ searchView.setQueryHint(getString(R.string.search_commons));
+ searchView.onActionViewExpanded();
+ searchView.clearFocus();
+
+ }
+
+ /**
+ * This method sets the search history fragment.
+ * Search history fragment is displayed when query is empty.
+ */
+ private void setSearchHistoryFragment() {
+ recentSearchesFragment = new RecentSearchesFragment();
+ FragmentTransaction transaction = supportFragmentManager.beginTransaction();
+ transaction.add(R.id.searchHistoryContainer, recentSearchesFragment).commit();
+ }
+
+ /**
+ * Sets the titles in the tabLayout and fragments in the viewPager
+ */
+ public void setTabs() {
+ List fragmentList = new ArrayList<>();
+ List titleList = new ArrayList<>();
+ searchImageFragment = new SearchImageFragment();
+ searchCategoryFragment= new SearchCategoryFragment();
+ fragmentList.add(searchImageFragment);
+ titleList.add("MEDIA");
+ fragmentList.add(searchCategoryFragment);
+ titleList.add("CATEGORIES");
+
+ viewPagerAdapter.setTabData(fragmentList, titleList);
+ viewPagerAdapter.notifyDataSetChanged();
+ RxSearchView.queryTextChanges(searchView)
+ .takeUntil(RxView.detaches(searchView))
+ .debounce(500, TimeUnit.MILLISECONDS)
+ .observeOn(AndroidSchedulers.mainThread())
+ .subscribe( query -> {
+ //update image list
+ if (!TextUtils.isEmpty(query)) {
+ viewPager.setVisibility(View.VISIBLE);
+ tabLayout.setVisibility(View.VISIBLE);
+ searchHistoryContainer.setVisibility(View.GONE);
+ searchImageFragment.updateImageList(query.toString());
+ searchCategoryFragment.updateCategoryList(query.toString());
+ }else {
+ viewPager.setVisibility(View.GONE);
+ tabLayout.setVisibility(View.GONE);
+ searchHistoryContainer.setVisibility(View.VISIBLE);
+ recentSearchesFragment.updateRecentSearches();
+ // open search history fragment
+ }
+ }
+ );
+ }
+
+ /**
+ * returns Media Object at position
+ * @param i position of Media in the imagesRecyclerView adapter.
+ */
+ @Override
+ public Media getMediaAtPosition(int i) {
+ return searchImageFragment.getImageAtPosition(i);
+ }
+
+ /**
+ * returns total number of images present in the imagesRecyclerView adapter.
+ */
+ @Override
+ public int getTotalMediaCount() {
+ return searchImageFragment.getTotalImagesCount();
+ }
+
+ /**
+ * This method is never called but it was in MediaDetailProvider Interface
+ * so it needs to be overrided.
+ */
+ @Override
+ public void notifyDatasetChanged() {
+
+ }
+
+ /**
+ * This method is never called but it was in MediaDetailProvider Interface
+ * so it needs to be overrided.
+ */
+ @Override
+ public void registerDataSetObserver(DataSetObserver observer) {
+
+ }
+
+ /**
+ * This method is never called but it was in MediaDetailProvider Interface
+ * so it needs to be overrided.
+ */
+ @Override
+ public void unregisterDataSetObserver(DataSetObserver observer) {
+
+ }
+
+ /**
+ * Open media detail pager fragment on click of image in search results
+ * @param index item index that should be opened
+ */
+ public void onSearchImageClicked(int index) {
+ ViewUtil.hideKeyboard(this.findViewById(R.id.searchBox));
+ toolbar.setVisibility(View.GONE);
+ tabLayout.setVisibility(View.GONE);
+ viewPager.setVisibility(View.GONE);
+ mediaContainer.setVisibility(View.VISIBLE);
+ setNavigationBaseToolbarVisibility(true);
+ if (mediaDetails == null || !mediaDetails.isVisible()) {
+ // set isFeaturedImage true for featured images, to include author field on media detail
+ mediaDetails = new MediaDetailPagerFragment(false, true);
+ FragmentManager supportFragmentManager = getSupportFragmentManager();
+ supportFragmentManager
+ .beginTransaction()
+ .hide(supportFragmentManager.getFragments().get(supportFragmentManager.getBackStackEntryCount()))
+ .add(R.id.mediaContainer, mediaDetails)
+ .addToBackStack(null)
+ .commit();
+ // Reason for using hide, add instead of replace is to maintain scroll position after
+ // coming back to the search activity. See https://github.com/commons-app/apps-android-commons/issues/1631
+ // https://stackoverflow.com/questions/11353075/how-can-i-maintain-fragment-state-when-added-to-the-back-stack/19022550#19022550
+ supportFragmentManager.executePendingTransactions();
+ }
+ mediaDetails.showImage(index);
+ forceInitBackButton();
+ }
+
+ /**
+ * This method is called on Screen Rotation
+ */
+ @Override
+ protected void onResume() {
+ if (supportFragmentManager.getBackStackEntryCount()==1){
+ //FIXME: Temporary fix for screen rotation inside media details. If we don't call onBackPressed then fragment stack is increasing every time.
+ //FIXME: Similar issue like this https://github.com/commons-app/apps-android-commons/issues/894
+ // This is called on screen rotation when user is inside media details. Ideally it should show Media Details but since we are not saving the state now. We are throwing the user to search screen otherwise the app was crashing.
+ //
+ onBackPressed();
+ }
+ super.onResume();
+ }
+
+ /**
+ * This method is called on backPressed of anyFragment in the activity.
+ * If condition is called when mediaDetailFragment is opened.
+ */
+ @Override
+ public void onBackPressed() {
+ if (getSupportFragmentManager().getBackStackEntryCount() == 1){
+ // back to search so show search toolbar and hide navigation toolbar
+ toolbar.setVisibility(View.VISIBLE);
+ tabLayout.setVisibility(View.VISIBLE);
+ viewPager.setVisibility(View.VISIBLE);
+ mediaContainer.setVisibility(View.GONE);
+ setNavigationBaseToolbarVisibility(false);
+ }else {
+ toolbar.setVisibility(View.GONE);
+ setNavigationBaseToolbarVisibility(true);
+ }
+ super.onBackPressed();
+ }
+
+ /**
+ * This method is called on click of a recent search to update query in SearchView.
+ * @param query Recent Search Query
+ */
+ public void updateText(String query) {
+ searchView.setQuery(query, true);
+ // Clear focus of searchView now. searchView.clearFocus(); does not seem to work Check the below link for more details.
+ // https://stackoverflow.com/questions/6117967/how-to-remove-focus-without-setting-focus-to-another-control/15481511
+ viewPager.requestFocus();
+ }
+}
diff --git a/app/src/main/java/fr/free/nrw/commons/explore/ViewPagerAdapter.java b/app/src/main/java/fr/free/nrw/commons/explore/ViewPagerAdapter.java
new file mode 100755
index 000000000..5ebbd4f37
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/explore/ViewPagerAdapter.java
@@ -0,0 +1,57 @@
+package fr.free.nrw.commons.explore;
+
+import android.support.v4.app.Fragment;
+import android.support.v4.app.FragmentManager;
+import android.support.v4.app.FragmentPagerAdapter;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * This adapter will be used to display fragments in a ViewPager
+ */
+public class ViewPagerAdapter extends FragmentPagerAdapter {
+ private List fragmentList = new ArrayList<>();
+ private List fragmentTitleList = new ArrayList<>();
+
+ public ViewPagerAdapter(FragmentManager manager) {
+ super(manager);
+ }
+
+ /**
+ * This method returns the fragment of the viewpager at a particular position
+ * @param position
+ */
+ @Override
+ public Fragment getItem(int position) {
+ return fragmentList.get(position);
+ }
+
+ /**
+ * This method returns the total number of fragments in the viewpager.
+ * @return size
+ */
+ @Override
+ public int getCount() {
+ return fragmentList.size();
+ }
+
+ /**
+ * This method sets the fragment and title list in the viewpager
+ * @param fragmentList List of all fragments to be displayed in the viewpager
+ * @param fragmentTitleList List of all titles of the fragments
+ */
+ public void setTabData(List fragmentList, List fragmentTitleList) {
+ this.fragmentList = fragmentList;
+ this.fragmentTitleList = fragmentTitleList;
+ }
+
+ /**
+ * This method returns the title of the page at a particular position
+ * @param position
+ */
+ @Override
+ public CharSequence getPageTitle(int position) {
+ return fragmentTitleList.get(position);
+ }
+}
diff --git a/app/src/main/java/fr/free/nrw/commons/explore/categories/SearchCategoriesAdapterFactory.java b/app/src/main/java/fr/free/nrw/commons/explore/categories/SearchCategoriesAdapterFactory.java
new file mode 100644
index 000000000..3ac75e07e
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/explore/categories/SearchCategoriesAdapterFactory.java
@@ -0,0 +1,32 @@
+package fr.free.nrw.commons.explore.categories;
+
+import com.pedrogomez.renderers.ListAdapteeCollection;
+import com.pedrogomez.renderers.RVRendererAdapter;
+import com.pedrogomez.renderers.RendererBuilder;
+
+import java.util.Collections;
+import java.util.List;
+
+/**
+ * This class helps in creating adapter for categoriesRecyclerView in SearchCategoryFragment,
+ * implementing onClicks on categoriesRecyclerView Items
+ **/
+public class SearchCategoriesAdapterFactory {
+ private final SearchCategoriesRenderer.CategoryClickedListener listener;
+
+ public SearchCategoriesAdapterFactory(SearchCategoriesRenderer.CategoryClickedListener listener) {
+ this.listener = listener;
+ }
+
+ /**
+ * This method creates a recyclerViewAdapter for Categories.
+ * @param searchImageItemList List of category name to be displayed
+ * @return categoriesAdapter
+ **/
+ public RVRendererAdapter create(List searchImageItemList) {
+ RendererBuilder builder = new RendererBuilder().bind(String.class, new SearchCategoriesRenderer(listener));
+ ListAdapteeCollection collection = new ListAdapteeCollection<>(
+ searchImageItemList != null ? searchImageItemList : Collections.emptyList());
+ return new RVRendererAdapter<>(builder, collection);
+ }
+}
diff --git a/app/src/main/java/fr/free/nrw/commons/explore/categories/SearchCategoriesRenderer.java b/app/src/main/java/fr/free/nrw/commons/explore/categories/SearchCategoriesRenderer.java
new file mode 100644
index 000000000..631b7b552
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/explore/categories/SearchCategoriesRenderer.java
@@ -0,0 +1,56 @@
+package fr.free.nrw.commons.explore.categories;
+
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+import android.widget.TextView;
+
+import com.pedrogomez.renderers.Renderer;
+
+import butterknife.BindView;
+import butterknife.ButterKnife;
+import fr.free.nrw.commons.R;
+
+/**
+ * presentation logic of individual category in search is handled here
+ **/
+class SearchCategoriesRenderer extends Renderer {
+ @BindView(R.id.textView1) TextView tvCategoryName;
+
+ private final CategoryClickedListener listener;
+
+ SearchCategoriesRenderer(CategoryClickedListener listener) {
+ this.listener = listener;
+ }
+
+ @Override
+ protected View inflate(LayoutInflater layoutInflater, ViewGroup viewGroup) {
+ return layoutInflater.inflate(R.layout.item_recent_searches, viewGroup, false);
+ }
+
+ @Override
+ protected void setUpView(View view) {
+ ButterKnife.bind(this, view);
+ }
+
+ @Override
+ protected void hookListeners(View view) {
+ view.setOnClickListener(v -> {
+ String item = getContent();
+ if (listener != null) {
+ listener.categoryClicked(item);
+ }
+ });
+ }
+
+ @Override
+ public void render() {
+ String item = getContent();
+ tvCategoryName.setText(item.replaceFirst("^Category:", ""));
+ }
+
+ public interface CategoryClickedListener {
+ void categoryClicked(String item);
+ }
+
+}
diff --git a/app/src/main/java/fr/free/nrw/commons/explore/categories/SearchCategoryFragment.java b/app/src/main/java/fr/free/nrw/commons/explore/categories/SearchCategoryFragment.java
new file mode 100644
index 000000000..7f2b3ff93
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/explore/categories/SearchCategoryFragment.java
@@ -0,0 +1,222 @@
+package fr.free.nrw.commons.explore.categories;
+
+
+import android.content.SharedPreferences;
+import android.content.res.Configuration;
+import android.os.Bundle;
+import android.os.Handler;
+import android.support.v7.widget.GridLayoutManager;
+import android.support.v7.widget.LinearLayoutManager;
+import android.support.v7.widget.RecyclerView;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+import android.widget.ProgressBar;
+import android.widget.TextView;
+
+import com.pedrogomez.renderers.RVRendererAdapter;
+
+import java.util.ArrayList;
+import java.util.Date;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+
+import butterknife.BindView;
+import butterknife.ButterKnife;
+import fr.free.nrw.commons.R;
+import fr.free.nrw.commons.category.CategoryDetailsActivity;
+import fr.free.nrw.commons.di.CommonsDaggerSupportFragment;
+import fr.free.nrw.commons.explore.recentsearches.RecentSearch;
+import fr.free.nrw.commons.explore.recentsearches.RecentSearchesDao;
+import fr.free.nrw.commons.mwapi.MediaWikiApi;
+import fr.free.nrw.commons.utils.NetworkUtils;
+import fr.free.nrw.commons.utils.ViewUtil;
+import io.reactivex.Observable;
+import io.reactivex.android.schedulers.AndroidSchedulers;
+import io.reactivex.schedulers.Schedulers;
+import timber.log.Timber;
+
+import static android.view.View.GONE;
+import static android.view.View.VISIBLE;
+
+/**
+ * Displays the category search screen.
+ */
+
+public class SearchCategoryFragment extends CommonsDaggerSupportFragment {
+
+ private static int TIMEOUT_SECONDS = 15;
+
+ @BindView(R.id.imagesListBox)
+ RecyclerView categoriesRecyclerView;
+ @BindView(R.id.imageSearchInProgress)
+ ProgressBar progressBar;
+ @BindView(R.id.imagesNotFound)
+ TextView categoriesNotFoundView;
+ String query;
+
+ @Inject RecentSearchesDao recentSearchesDao;
+ @Inject MediaWikiApi mwApi;
+ @Inject @Named("default_preferences") SharedPreferences prefs;
+
+ private RVRendererAdapter categoriesAdapter;
+ private List queryList = new ArrayList<>();
+
+ private final SearchCategoriesAdapterFactory adapterFactory = new SearchCategoriesAdapterFactory(item -> {
+ // Called on Click of a individual category Item
+ // Open Category Details activity
+ CategoryDetailsActivity.startYourself(getContext(), item);
+ saveQuery(query);
+ });
+
+ /**
+ * This method saves Search Query in the Recent Searches Database.
+ * @param query
+ */
+ private void saveQuery(String query) {
+ RecentSearch recentSearch = recentSearchesDao.find(query);
+
+ // Newly searched query...
+ if (recentSearch == null) {
+ recentSearch = new RecentSearch(null, query, new Date());
+ }
+ else {
+ recentSearch.setLastSearched(new Date());
+ }
+ recentSearchesDao.save(recentSearch);
+
+ }
+
+
+ @Override
+ public View onCreateView(LayoutInflater inflater, ViewGroup container,Bundle savedInstanceState) {
+ View rootView = inflater.inflate(R.layout.fragment_browse_image, container, false);
+ ButterKnife.bind(this, rootView);
+ if(getActivity().getResources().getConfiguration().orientation == Configuration.ORIENTATION_PORTRAIT){
+ categoriesRecyclerView.setLayoutManager(new LinearLayoutManager(getContext()));
+ }
+ else{
+ categoriesRecyclerView.setLayoutManager(new GridLayoutManager(getContext(), 2));
+ }
+ ArrayList items = new ArrayList<>();
+ categoriesAdapter = adapterFactory.create(items);
+ categoriesRecyclerView.setAdapter(categoriesAdapter);
+ categoriesRecyclerView.addOnScrollListener(new RecyclerView.OnScrollListener() {
+ @Override
+ public void onScrollStateChanged(RecyclerView recyclerView, int newState) {
+ super.onScrollStateChanged(recyclerView, newState);
+ // check if end of recycler view is reached, if yes then add more results to existing results
+ if (!recyclerView.canScrollVertically(1)) {
+ addCategoriesToList(query);
+ }
+ }
+ });
+ return rootView;
+ }
+
+ /**
+ * Checks for internet connection and then initializes the recycler view with 25 categories of the searched query
+ * Clearing categoryAdapter every time new keyword is searched so that user can see only new results
+ */
+ public void updateCategoryList(String query) {
+ this.query = query;
+ categoriesNotFoundView.setVisibility(GONE);
+ if(!NetworkUtils.isInternetConnectionEstablished(getContext())) {
+ handleNoInternet();
+ return;
+ }
+ progressBar.setVisibility(View.VISIBLE);
+ queryList.clear();
+ categoriesAdapter.clear();
+ Observable.fromCallable(() -> mwApi.searchCategory(query,queryList.size()))
+ .subscribeOn(Schedulers.io())
+ .observeOn(AndroidSchedulers.mainThread())
+ .timeout(TIMEOUT_SECONDS, TimeUnit.SECONDS)
+ .subscribe(this::handleSuccess, this::handleError);
+ }
+
+
+ /**
+ * Adds more results to existing search results
+ */
+ public void addCategoriesToList(String query) {
+ this.query = query;
+ progressBar.setVisibility(View.VISIBLE);
+ Observable.fromCallable(() -> mwApi.searchCategory(query,queryList.size()))
+ .subscribeOn(Schedulers.io())
+ .observeOn(AndroidSchedulers.mainThread())
+ .timeout(TIMEOUT_SECONDS, TimeUnit.SECONDS)
+ .subscribe(this::handlePaginationSuccess, this::handleError);
+ }
+
+ /**
+ * Handles the success scenario
+ * it initializes the recycler view by adding items to the adapter
+ * @param mediaList
+ */
+ private void handlePaginationSuccess(List mediaList) {
+ queryList.addAll(mediaList);
+ progressBar.setVisibility(View.GONE);
+ categoriesAdapter.addAll(mediaList);
+ categoriesAdapter.notifyDataSetChanged();
+ }
+
+
+
+ /**
+ * Handles the success scenario
+ * it initializes the recycler view by adding items to the adapter
+ * @param mediaList
+ */
+ private void handleSuccess(List mediaList) {
+ queryList = mediaList;
+ if(mediaList == null || mediaList.isEmpty()) {
+ initErrorView();
+ }
+ else {
+
+ progressBar.setVisibility(View.GONE);
+ categoriesAdapter.addAll(mediaList);
+ categoriesAdapter.notifyDataSetChanged();
+
+ // check if user is waiting for 5 seconds if yes then save search query to history.
+ Handler handler = new Handler();
+ handler.postDelayed(() -> saveQuery(query), 5000);
+ }
+ }
+
+ /**
+ * Logs and handles API error scenario
+ * @param throwable
+ */
+ private void handleError(Throwable throwable) {
+ Timber.e(throwable, "Error occurred while loading queried categories");
+ try {
+ initErrorView();
+ ViewUtil.showSnackbar(categoriesRecyclerView, R.string.error_loading_categories);
+ }catch (Exception e){
+ e.printStackTrace();
+ }
+
+ }
+
+ /**
+ * Handles the UI updates for a error scenario
+ */
+ private void initErrorView() {
+ progressBar.setVisibility(GONE);
+ categoriesNotFoundView.setVisibility(VISIBLE);
+ categoriesNotFoundView.setText(getString(R.string.categories_not_found, query));
+ }
+
+ /**
+ * Handles the UI updates for no internet scenario
+ */
+ private void handleNoInternet() {
+ progressBar.setVisibility(GONE);
+ ViewUtil.showSnackbar(categoriesRecyclerView, R.string.no_internet);
+ }
+}
diff --git a/app/src/main/java/fr/free/nrw/commons/explore/images/SearchImageFragment.java b/app/src/main/java/fr/free/nrw/commons/explore/images/SearchImageFragment.java
new file mode 100644
index 000000000..a503207e4
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/explore/images/SearchImageFragment.java
@@ -0,0 +1,245 @@
+package fr.free.nrw.commons.explore.images;
+
+
+import android.content.SharedPreferences;
+import android.content.res.Configuration;
+import android.os.Bundle;
+import android.os.Handler;
+import android.support.v7.widget.GridLayoutManager;
+import android.support.v7.widget.LinearLayoutManager;
+import android.support.v7.widget.RecyclerView;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+import android.widget.ProgressBar;
+import android.widget.TextView;
+import com.pedrogomez.renderers.RVRendererAdapter;
+import java.util.ArrayList;
+import java.util.Date;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+import javax.inject.Inject;
+import javax.inject.Named;
+import butterknife.BindView;
+import butterknife.ButterKnife;
+import fr.free.nrw.commons.Media;
+import fr.free.nrw.commons.R;
+import fr.free.nrw.commons.di.CommonsDaggerSupportFragment;
+import fr.free.nrw.commons.explore.SearchActivity;
+import fr.free.nrw.commons.explore.recentsearches.RecentSearch;
+import fr.free.nrw.commons.explore.recentsearches.RecentSearchesDao;
+import fr.free.nrw.commons.mwapi.MediaWikiApi;
+import fr.free.nrw.commons.utils.NetworkUtils;
+import fr.free.nrw.commons.utils.ViewUtil;
+import io.reactivex.Observable;
+import io.reactivex.android.schedulers.AndroidSchedulers;
+import io.reactivex.schedulers.Schedulers;
+import timber.log.Timber;
+
+import static android.view.View.GONE;
+import static android.view.View.VISIBLE;
+
+/**
+ * Displays the image search screen.
+ */
+
+public class SearchImageFragment extends CommonsDaggerSupportFragment {
+
+ private static int TIMEOUT_SECONDS = 15;
+
+ @BindView(R.id.imagesListBox)
+ RecyclerView imagesRecyclerView;
+ @BindView(R.id.imageSearchInProgress)
+ ProgressBar progressBar;
+ @BindView(R.id.imagesNotFound)
+ TextView imagesNotFoundView;
+ String query;
+
+ @Inject RecentSearchesDao recentSearchesDao;
+ @Inject MediaWikiApi mwApi;
+ @Inject @Named("default_preferences") SharedPreferences prefs;
+
+ private RVRendererAdapter imagesAdapter;
+ private List queryList = new ArrayList<>();
+
+ private final SearchImagesAdapterFactory adapterFactory = new SearchImagesAdapterFactory(item -> {
+ // Called on Click of a individual media Item
+ int index = queryList.indexOf(item);
+ ((SearchActivity)getContext()).onSearchImageClicked(index);
+ saveQuery(query);
+ });
+
+ /**
+ * This method saves Search Query in the Recent Searches Database.
+ * @param query
+ */
+ private void saveQuery(String query) {
+ RecentSearch recentSearch = recentSearchesDao.find(query);
+
+ // Newly searched query...
+ if (recentSearch == null) {
+ recentSearch = new RecentSearch(null, query, new Date());
+ }
+ else {
+ recentSearch.setLastSearched(new Date());
+ }
+
+ recentSearchesDao.save(recentSearch);
+
+ }
+
+
+ @Override
+ public View onCreateView(LayoutInflater inflater, ViewGroup container,Bundle savedInstanceState) {
+ View rootView = inflater.inflate(R.layout.fragment_browse_image, container, false);
+ ButterKnife.bind(this, rootView);
+ if(getActivity().getResources().getConfiguration().orientation == Configuration.ORIENTATION_PORTRAIT){
+ imagesRecyclerView.setLayoutManager(new LinearLayoutManager(getContext()));
+ }
+ else{
+ imagesRecyclerView.setLayoutManager(new GridLayoutManager(getContext(), 2));
+ }
+ ArrayList items = new ArrayList<>();
+ imagesAdapter = adapterFactory.create(items);
+ imagesRecyclerView.setAdapter(imagesAdapter);
+ imagesRecyclerView.addOnScrollListener(new RecyclerView.OnScrollListener() {
+ @Override
+ public void onScrollStateChanged(RecyclerView recyclerView, int newState) {
+ super.onScrollStateChanged(recyclerView, newState);
+ // check if end of recycler view is reached, if yes then add more results to existing results
+ if (!recyclerView.canScrollVertically(1)) {
+ addImagesToList(query);
+ }
+ }
+ });
+ return rootView;
+ }
+
+ /**
+ * Checks for internet connection and then initializes the recycler view with 25 images of the searched query
+ * Clearing imageAdapter every time new keyword is searched so that user can see only new results
+ */
+ public void updateImageList(String query) {
+ this.query = query;
+ imagesNotFoundView.setVisibility(GONE);
+ if(!NetworkUtils.isInternetConnectionEstablished(getContext())) {
+ handleNoInternet();
+ return;
+ }
+ progressBar.setVisibility(View.VISIBLE);
+ queryList.clear();
+ imagesAdapter.clear();
+ Observable.fromCallable(() -> mwApi.searchImages(query,queryList.size()))
+ .subscribeOn(Schedulers.io())
+ .observeOn(AndroidSchedulers.mainThread())
+ .timeout(TIMEOUT_SECONDS, TimeUnit.SECONDS)
+ .subscribe(this::handleSuccess, this::handleError);
+ }
+
+
+ /**
+ * Adds more results to existing search results
+ */
+ public void addImagesToList(String query) {
+ this.query = query;
+ progressBar.setVisibility(View.VISIBLE);
+ Observable.fromCallable(() -> mwApi.searchImages(query,queryList.size()))
+ .subscribeOn(Schedulers.io())
+ .observeOn(AndroidSchedulers.mainThread())
+ .timeout(TIMEOUT_SECONDS, TimeUnit.SECONDS)
+ .subscribe(this::handlePaginationSuccess, this::handleError);
+ }
+
+ /**
+ * Handles the success scenario
+ * it initializes the recycler view by adding items to the adapter
+ * @param mediaList List of media to be added
+ */
+ private void handlePaginationSuccess(List mediaList) {
+ queryList.addAll(mediaList);
+ progressBar.setVisibility(View.GONE);
+ imagesAdapter.addAll(mediaList);
+ imagesAdapter.notifyDataSetChanged();
+ }
+
+
+
+ /**
+ * Handles the success scenario
+ * it initializes the recycler view by adding items to the adapter
+ * @param mediaList List of media to be shown
+ */
+ private void handleSuccess(List mediaList) {
+ queryList = mediaList;
+ if(mediaList == null || mediaList.isEmpty()) {
+ initErrorView();
+ }
+ else {
+
+ progressBar.setVisibility(View.GONE);
+ imagesAdapter.addAll(mediaList);
+ imagesAdapter.notifyDataSetChanged();
+
+ // check if user is waiting for 5 seconds if yes then save search query to history.
+ Handler handler = new Handler();
+ handler.postDelayed(() -> saveQuery(query), 5000);
+ }
+ }
+
+ /**
+ * Logs and handles API error scenario
+ * @param throwable
+ */
+ private void handleError(Throwable throwable) {
+ Timber.e(throwable, "Error occurred while loading queried images");
+ try {
+ initErrorView();
+ ViewUtil.showSnackbar(imagesRecyclerView, R.string.error_loading_images);
+ }catch (Exception e){
+ e.printStackTrace();
+ }
+ }
+
+ /**
+ * Handles the UI updates for a error scenario
+ */
+ private void initErrorView() {
+ progressBar.setVisibility(GONE);
+ imagesNotFoundView.setVisibility(VISIBLE);
+ imagesNotFoundView.setText(getString(R.string.images_not_found, query));
+ }
+
+ /**
+ * Handles the UI updates for no internet scenario
+ */
+ private void handleNoInternet() {
+ progressBar.setVisibility(GONE);
+ ViewUtil.showSnackbar(imagesRecyclerView, R.string.no_internet);
+ }
+
+ /**
+ * returns total number of images present in the recyclerview adapter.
+ */
+ public int getTotalImagesCount(){
+ if (imagesAdapter == null) {
+ return 0;
+ }
+ else {
+ return imagesAdapter.getItemCount();
+ }
+ }
+
+ /**
+ * returns Media Object at position
+ * @param i position of Media in the recyclerview adapter.
+ */
+ public Media getImageAtPosition(int i) {
+ if (imagesAdapter.getItem(i).getFilename() == null) {
+ // not yet ready to return data
+ return null;
+ }
+ else {
+ return new Media(imagesAdapter.getItem(i).getFilename());
+ }
+ }
+}
diff --git a/app/src/main/java/fr/free/nrw/commons/explore/images/SearchImagesAdapterFactory.java b/app/src/main/java/fr/free/nrw/commons/explore/images/SearchImagesAdapterFactory.java
new file mode 100644
index 000000000..94930e261
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/explore/images/SearchImagesAdapterFactory.java
@@ -0,0 +1,35 @@
+package fr.free.nrw.commons.explore.images;
+
+import com.pedrogomez.renderers.ListAdapteeCollection;
+import com.pedrogomez.renderers.RVRendererAdapter;
+import com.pedrogomez.renderers.RendererBuilder;
+
+import java.util.Collections;
+import java.util.List;
+
+import fr.free.nrw.commons.Media;
+
+/**
+ * This class helps in creating adapter for imagesRecyclerView in SearchImagesFragment,
+ * implementing onClicks on imagesRecyclerView Items
+ **/
+class SearchImagesAdapterFactory {
+ private final SearchImagesRenderer.ImageClickedListener listener;
+
+ SearchImagesAdapterFactory(SearchImagesRenderer.ImageClickedListener listener) {
+ this.listener = listener;
+ }
+
+ /**
+ * This method creates a recyclerViewAdapter for Media.
+ * @param searchImageItemList List of Media objects to be displayed
+ * @return imagesAdapter
+ **/
+ public RVRendererAdapter create(List searchImageItemList) {
+ RendererBuilder builder = new RendererBuilder()
+ .bind(Media.class, new SearchImagesRenderer(listener));
+ ListAdapteeCollection collection = new ListAdapteeCollection<>(
+ searchImageItemList != null ? searchImageItemList : Collections.emptyList());
+ return new RVRendererAdapter<>(builder, collection);
+ }
+}
diff --git a/app/src/main/java/fr/free/nrw/commons/explore/images/SearchImagesRenderer.java b/app/src/main/java/fr/free/nrw/commons/explore/images/SearchImagesRenderer.java
new file mode 100644
index 000000000..42c044d70
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/explore/images/SearchImagesRenderer.java
@@ -0,0 +1,75 @@
+package fr.free.nrw.commons.explore.images;
+
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+import android.widget.TextView;
+
+import com.pedrogomez.renderers.Renderer;
+
+import butterknife.BindView;
+import butterknife.ButterKnife;
+import fr.free.nrw.commons.Media;
+import fr.free.nrw.commons.MediaWikiImageView;
+import fr.free.nrw.commons.R;
+
+/**
+ * presentation logic of individual image in search is handled here
+ **/
+class SearchImagesRenderer extends Renderer {
+ @BindView(R.id.categoryImageTitle) TextView tvImageName;
+ @BindView(R.id.categoryImageAuthor) TextView categoryImageAuthor;
+ @BindView(R.id.categoryImageView)
+ MediaWikiImageView browseImage;
+
+ private final ImageClickedListener listener;
+
+ SearchImagesRenderer(ImageClickedListener listener) {
+ this.listener = listener;
+ }
+
+ @Override
+ protected View inflate(LayoutInflater layoutInflater, ViewGroup viewGroup) {
+ return layoutInflater.inflate(R.layout.layout_category_images, viewGroup, false);
+ }
+
+ @Override
+ protected void setUpView(View view) {
+ ButterKnife.bind(this, view);
+ }
+
+ @Override
+ protected void hookListeners(View view) {
+ view.setOnClickListener(v -> {
+ Media item = getContent();
+ if (listener != null) {
+ listener.imageClicked(item);
+ }
+ });
+ }
+
+ @Override
+ public void render() {
+ Media item = getContent();
+ tvImageName.setText(item.getDisplayTitle());
+ browseImage.setMedia(item);
+ setAuthorView(item, categoryImageAuthor);
+ }
+
+ interface ImageClickedListener {
+ void imageClicked(Media item);
+ }
+
+ /**
+ * formats author name as "Uploaded by: authorName" and sets it in textview
+ */
+ private void setAuthorView(Media item, TextView author) {
+ if (item.getCreator() != null && !item.getCreator().equals("")) {
+ author.setVisibility(View.GONE);
+ String uploadedByTemplate = getContext().getString(R.string.image_uploaded_by);
+ author.setText(String.format(uploadedByTemplate, item.getCreator()));
+ } else {
+ author.setVisibility(View.VISIBLE);
+ }
+ }
+}
diff --git a/app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearch.java b/app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearch.java
new file mode 100644
index 000000000..c5172bb7c
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearch.java
@@ -0,0 +1,70 @@
+package fr.free.nrw.commons.explore.recentsearches;
+
+import android.net.Uri;
+import java.util.Date;
+
+/**
+ * Represents a recently searched query
+ * Example - query = "butterfly"
+ */
+public class RecentSearch {
+ private Uri contentUri;
+ private String query;
+ private Date lastSearched;
+
+ /**
+ * Constructor
+ * @param contentUri the content URI for this query
+ * @param query query name
+ * @param lastSearched last searched date
+ */
+ public RecentSearch(Uri contentUri, String query, Date lastSearched) {
+ this.contentUri = contentUri;
+ this.query = query;
+ this.lastSearched = lastSearched;
+ }
+
+ /**
+ * Gets query name
+ * @return query name
+ */
+ public String getQuery() {
+ return query;
+ }
+
+ /**
+ * Gets last searched date
+ * @return Last searched date
+ */
+ public Date getLastSearched() {
+ // warning: Date objects are mutable.
+ return (Date)lastSearched.clone();
+ }
+
+
+ /**
+ * Updates the last searched date
+ * @param lastSearched Last searched date
+ */
+ public void setLastSearched(Date lastSearched) {
+ this.lastSearched = lastSearched;
+ }
+
+ /**
+ * Gets the content URI for this query
+ * @return content URI
+ */
+ public Uri getContentUri() {
+ return contentUri;
+ }
+
+ /**
+ * Modifies the content URI - marking this query as already saved in the database
+ *
+ * @param contentUri the content URI
+ */
+ public void setContentUri(Uri contentUri) {
+ this.contentUri = contentUri;
+ }
+
+}
\ No newline at end of file
diff --git a/app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesContentProvider.java b/app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesContentProvider.java
new file mode 100644
index 000000000..bf3cf959a
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesContentProvider.java
@@ -0,0 +1,202 @@
+package fr.free.nrw.commons.explore.recentsearches;
+
+import android.content.ContentValues;
+import android.content.UriMatcher;
+import android.database.Cursor;
+import android.database.sqlite.SQLiteDatabase;
+import android.database.sqlite.SQLiteQueryBuilder;
+import android.net.Uri;
+import android.support.annotation.NonNull;
+import android.text.TextUtils;
+
+import javax.inject.Inject;
+
+import fr.free.nrw.commons.contributions.ContributionDao;
+import fr.free.nrw.commons.data.DBOpenHelper;
+import fr.free.nrw.commons.di.CommonsDaggerContentProvider;
+import timber.log.Timber;
+
+import static android.content.UriMatcher.NO_MATCH;
+import static fr.free.nrw.commons.explore.recentsearches.RecentSearchesDao.Table.ALL_FIELDS;
+import static fr.free.nrw.commons.explore.recentsearches.RecentSearchesDao.Table.COLUMN_ID;
+import static fr.free.nrw.commons.explore.recentsearches.RecentSearchesDao.Table.TABLE_NAME;
+
+
+/**
+ * This class contains functions for executing queries for
+ * inserting, searching, deleting, editing recent searches in SqLite DB
+ **/
+public class RecentSearchesContentProvider extends CommonsDaggerContentProvider {
+
+ public static final String RECENT_SEARCH_AUTHORITY = "fr.free.nrw.commons.explore.recentsearches.contentprovider";
+ // For URI matcher
+ private static final int RECENT_SEARCHES = 1;
+ private static final int RECENT_SEARCHES_ID = 2;
+ private static final String BASE_PATH = "recent_searches";
+ public static final Uri BASE_URI = Uri.parse("content://" + RECENT_SEARCH_AUTHORITY + "/" + BASE_PATH);
+ private static final UriMatcher uriMatcher = new UriMatcher(NO_MATCH);
+
+ static {
+ uriMatcher.addURI(RECENT_SEARCH_AUTHORITY, BASE_PATH, RECENT_SEARCHES);
+ uriMatcher.addURI(RECENT_SEARCH_AUTHORITY, BASE_PATH + "/#", RECENT_SEARCHES_ID);
+ }
+
+ public static Uri uriForId(int id) {
+ return Uri.parse(BASE_URI.toString() + "/" + id);
+ }
+
+ @Inject DBOpenHelper dbOpenHelper;
+
+ /**
+ * This functions executes query for searching recent searches in SqLite DB
+ **/
+ @SuppressWarnings("ConstantConditions")
+ @Override
+ public Cursor query(@NonNull Uri uri, String[] projection, String selection,
+ String[] selectionArgs, String sortOrder) {
+ SQLiteQueryBuilder queryBuilder = new SQLiteQueryBuilder();
+ queryBuilder.setTables(TABLE_NAME);
+
+ int uriType = uriMatcher.match(uri);
+
+ SQLiteDatabase db = dbOpenHelper.getReadableDatabase();
+ Cursor cursor;
+
+ switch (uriType) {
+ case RECENT_SEARCHES:
+ cursor = queryBuilder.query(db, projection, selection, selectionArgs,
+ null, null, sortOrder);
+ break;
+ case RECENT_SEARCHES_ID:
+ cursor = queryBuilder.query(db,
+ ALL_FIELDS,
+ "_id = ?",
+ new String[]{uri.getLastPathSegment()},
+ null,
+ null,
+ sortOrder
+ );
+ break;
+ default:
+ throw new IllegalArgumentException("Unknown URI" + uri);
+ }
+
+ cursor.setNotificationUri(getContext().getContentResolver(), uri);
+
+ return cursor;
+ }
+
+ @Override
+ public String getType(@NonNull Uri uri) {
+ return null;
+ }
+
+ /**
+ * This functions executes query for inserting a recentSearch object in SqLite DB
+ **/
+ @SuppressWarnings("ConstantConditions")
+ @Override
+ public Uri insert(@NonNull Uri uri, ContentValues contentValues) {
+ int uriType = uriMatcher.match(uri);
+ SQLiteDatabase sqlDB = dbOpenHelper.getWritableDatabase();
+ long id;
+ switch (uriType) {
+ case RECENT_SEARCHES:
+ id = sqlDB.insert(TABLE_NAME, null, contentValues);
+ break;
+ default:
+ throw new IllegalArgumentException("Unknown URI: " + uri);
+ }
+ getContext().getContentResolver().notifyChange(uri, null);
+ return Uri.parse(BASE_URI + "/" + id);
+ }
+
+ /**
+ * This functions executes query for deleting a recentSearch object in SqLite DB
+ **/
+ @Override
+ public int delete(@NonNull Uri uri, String s, String[] strings) {
+ int rows;
+ int uriType = uriMatcher.match(uri);
+ SQLiteDatabase db = dbOpenHelper.getReadableDatabase();
+ switch (uriType) {
+ case RECENT_SEARCHES_ID:
+ Timber.d("Deleting recent searches id %s", uri.getLastPathSegment());
+ rows = db.delete(RecentSearchesDao.Table.TABLE_NAME,
+ "_id = ?",
+ new String[]{uri.getLastPathSegment()}
+ );
+ break;
+ default:
+ throw new IllegalArgumentException("Unknown URI" + uri);
+ }
+ getContext().getContentResolver().notifyChange(uri, null);
+ return rows;
+ }
+
+ /**
+ * This functions executes query for inserting multiple recentSearch objects in SqLite DB
+ **/
+ @SuppressWarnings("ConstantConditions")
+ @Override
+ public int bulkInsert(@NonNull Uri uri, @NonNull ContentValues[] values) {
+ Timber.d("Hello, bulk insert! (RecentSearchesContentProvider)");
+ int uriType = uriMatcher.match(uri);
+ SQLiteDatabase sqlDB = dbOpenHelper.getWritableDatabase();
+ sqlDB.beginTransaction();
+ switch (uriType) {
+ case RECENT_SEARCHES:
+ for (ContentValues value : values) {
+ Timber.d("Inserting! %s", value);
+ sqlDB.insert(TABLE_NAME, null, value);
+ }
+ break;
+ default:
+ throw new IllegalArgumentException("Unknown URI: " + uri);
+ }
+ sqlDB.setTransactionSuccessful();
+ sqlDB.endTransaction();
+ getContext().getContentResolver().notifyChange(uri, null);
+ return values.length;
+ }
+
+ /**
+ * This functions executes query for updating a particular recentSearch object in SqLite DB
+ **/
+ @SuppressWarnings("ConstantConditions")
+ @Override
+ public int update(@NonNull Uri uri, ContentValues contentValues, String selection,
+ String[] selectionArgs) {
+ /*
+ SQL Injection warnings: First, note that we're not exposing this to the
+ outside world (exported="false"). Even then, we should make sure to sanitize
+ all user input appropriately. Input that passes through ContentValues
+ should be fine. So only issues are those that pass in via concating.
+
+ In here, the only concat created argument is for id. It is cast to an int,
+ and will error out otherwise.
+ */
+ int uriType = uriMatcher.match(uri);
+ SQLiteDatabase sqlDB = dbOpenHelper.getWritableDatabase();
+ int rowsUpdated;
+ switch (uriType) {
+ case RECENT_SEARCHES_ID:
+ if (TextUtils.isEmpty(selection)) {
+ int id = Integer.valueOf(uri.getLastPathSegment());
+ rowsUpdated = sqlDB.update(TABLE_NAME,
+ contentValues,
+ COLUMN_ID + " = ?",
+ new String[]{String.valueOf(id)});
+ } else {
+ throw new IllegalArgumentException(
+ "Parameter `selection` should be empty when updating an ID");
+ }
+ break;
+ default:
+ throw new IllegalArgumentException("Unknown URI: " + uri + " with type " + uriType);
+ }
+ getContext().getContentResolver().notifyChange(uri, null);
+ return rowsUpdated;
+ }
+}
+
diff --git a/app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesDao.java b/app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesDao.java
new file mode 100644
index 000000000..4bc84b7b1
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesDao.java
@@ -0,0 +1,235 @@
+package fr.free.nrw.commons.explore.recentsearches;
+
+import android.content.ContentProviderClient;
+import android.content.ContentValues;
+import android.database.Cursor;
+import android.database.sqlite.SQLiteDatabase;
+import android.os.RemoteException;
+import android.support.annotation.NonNull;
+import android.support.annotation.Nullable;
+import android.util.Log;
+
+import java.util.ArrayList;
+import java.util.Date;
+import java.util.List;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Provider;
+
+/**
+ * This class doesn't execute queries in database directly instead it contains the logic behind
+ * inserting, deleting, searching data from recent searches database.
+ **/
+public class RecentSearchesDao {
+
+ private final Provider clientProvider;
+
+ @Inject
+ public RecentSearchesDao(@Named("recentsearch") Provider clientProvider) {
+ this.clientProvider = clientProvider;
+ }
+
+ /**
+ * This method is called on click of media/ categories for storing them in recent searches
+ * @param recentSearch a recent searches object that is to be added in SqLite DB
+ */
+ public void save(RecentSearch recentSearch) {
+ ContentProviderClient db = clientProvider.get();
+ try {
+ if (recentSearch.getContentUri() == null) {
+ recentSearch.setContentUri(db.insert(RecentSearchesContentProvider.BASE_URI, toContentValues(recentSearch)));
+ } else {
+ db.update(recentSearch.getContentUri(), toContentValues(recentSearch), null, null);
+ }
+ } catch (RemoteException e) {
+ throw new RuntimeException(e);
+ } finally {
+ db.release();
+ }
+ }
+
+ /**
+ * This method is called on confirmation of delete recent searches.
+ * It deletes latest 10 recent searches from the database
+ * @param recentSearchesStringList list of recent searches to be deleted
+ */
+ public void deleteAll(List recentSearchesStringList) {
+ ContentProviderClient db = clientProvider.get();
+ for (String recentSearchName : recentSearchesStringList) {
+ try {
+ RecentSearch recentSearch = find(recentSearchName);
+ if (recentSearch.getContentUri() == null) {
+ throw new RuntimeException("tried to delete item with no content URI");
+ } else {
+ Log.d("QUERY_NAME",recentSearch.getContentUri()+"- delete tried");
+ db.delete(recentSearch.getContentUri(), null, null);
+ Log.d("QUERY_NAME",recentSearch.getQuery()+"- query deleted");
+ }
+ } catch (RemoteException e) {
+ Log.d("Exception",e+"- query deleted");
+ throw new RuntimeException(e);
+ } finally {
+ db.release();
+ }
+ }
+ }
+
+ /**
+ * Find persisted search query in database, based on its name.
+ * @param name Search query Ex- "butterfly"
+ * @return recently searched query from database, or null if not found
+ */
+ @Nullable
+ public RecentSearch find(String name) {
+ Cursor cursor = null;
+ ContentProviderClient db = clientProvider.get();
+ try {
+ cursor = db.query(
+ RecentSearchesContentProvider.BASE_URI,
+ Table.ALL_FIELDS,
+ Table.COLUMN_NAME + "=?",
+ new String[]{name},
+ null);
+ if (cursor != null && cursor.moveToFirst()) {
+ return fromCursor(cursor);
+ }
+ } catch (RemoteException e) {
+ // This feels lazy, but to hell with checked exceptions. :)
+ throw new RuntimeException(e);
+ } finally {
+ if (cursor != null) {
+ cursor.close();
+ }
+ db.release();
+ }
+ return null;
+ }
+
+ /**
+ * Retrieve recently-searched queries, ordered by descending date.
+ * @return a list containing recent searches
+ */
+ @NonNull
+ public List recentSearches(int limit) {
+ List items = new ArrayList<>();
+ Cursor cursor = null;
+ ContentProviderClient db = clientProvider.get();
+ try {
+ cursor = db.query( RecentSearchesContentProvider.BASE_URI, Table.ALL_FIELDS,
+ null, new String[]{}, Table.COLUMN_LAST_USED + " DESC");
+ // fixme add a limit on the original query instead of falling out of the loop?
+ while (cursor != null && cursor.moveToNext() && cursor.getPosition() < limit) {
+ items.add(fromCursor(cursor).getQuery());
+ }
+ } catch (RemoteException e) {
+ throw new RuntimeException(e);
+ } finally {
+ if (cursor != null) {
+ cursor.close();
+ }
+ db.release();
+ }
+ return items;
+ }
+
+
+ /**
+ * It creates an Recent Searches object from data stored in the SQLite DB by using cursor
+ * @param cursor
+ * @return RecentSearch object
+ */
+ @NonNull
+ RecentSearch fromCursor(Cursor cursor) {
+ // Hardcoding column positions!
+ return new RecentSearch(
+ RecentSearchesContentProvider.uriForId(cursor.getInt(cursor.getColumnIndex(Table.COLUMN_ID))),
+ cursor.getString(cursor.getColumnIndex(Table.COLUMN_NAME)),
+ new Date(cursor.getLong(cursor.getColumnIndex(Table.COLUMN_LAST_USED)))
+ );
+ }
+
+ /**
+ * This class contains the database table architechture for recent searches,
+ * It also contains queries and logic necessary to the create, update, delete this table.
+ */
+ private ContentValues toContentValues(RecentSearch recentSearch) {
+ ContentValues cv = new ContentValues();
+ cv.put(RecentSearchesDao.Table.COLUMN_NAME, recentSearch.getQuery());
+ cv.put(RecentSearchesDao.Table.COLUMN_LAST_USED, recentSearch.getLastSearched().getTime());
+ return cv;
+ }
+
+ /**
+ * This class contains the database table architechture for recent searches,
+ * It also contains queries and logic necessary to the create, update, delete this table.
+ */
+ public static class Table {
+ public static final String TABLE_NAME = "recent_searches";
+ public static final String COLUMN_ID = "_id";
+ static final String COLUMN_NAME = "name";
+ static final String COLUMN_LAST_USED = "last_used";
+
+ // NOTE! KEEP IN SAME ORDER AS THEY ARE DEFINED UP THERE. HELPS HARD CODE COLUMN INDICES.
+ public static final String[] ALL_FIELDS = {
+ COLUMN_ID,
+ COLUMN_NAME,
+ COLUMN_LAST_USED,
+ };
+
+ static final String DROP_TABLE_STATEMENT = "DROP TABLE IF EXISTS " + TABLE_NAME;
+
+ static final String CREATE_TABLE_STATEMENT = "CREATE TABLE " + TABLE_NAME + " ("
+ + COLUMN_ID + " INTEGER PRIMARY KEY,"
+ + COLUMN_NAME + " STRING,"
+ + COLUMN_LAST_USED + " INTEGER"
+ + ");";
+
+ /**
+ * This method creates a RecentSearchesTable in SQLiteDatabase
+ * @param db SQLiteDatabase
+ */
+ public static void onCreate(SQLiteDatabase db) {
+ db.execSQL(CREATE_TABLE_STATEMENT);
+ }
+
+ /**
+ * This method deletes RecentSearchesTable from SQLiteDatabase
+ * @param db SQLiteDatabase
+ */
+ public static void onDelete(SQLiteDatabase db) {
+ db.execSQL(DROP_TABLE_STATEMENT);
+ onCreate(db);
+ }
+
+ /**
+ * This method is called on migrating from a older version to a newer version
+ * @param db SQLiteDatabase
+ * @param from Version from which we are migrating
+ * @param to Version to which we are migrating
+ */
+ public static void onUpdate(SQLiteDatabase db, int from, int to) {
+ if (from == to) {
+ return;
+ }
+ if (from < 6) {
+ // doesn't exist yet
+ from++;
+ onUpdate(db, from, to);
+ return;
+ }
+ if (from == 6) {
+ // table added in version 7
+ onCreate(db);
+ from++;
+ onUpdate(db, from, to);
+ return;
+ }
+ if (from == 7) {
+ from++;
+ onUpdate(db, from, to);
+ return;
+ }
+ }
+ }
+}
diff --git a/app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesFragment.java b/app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesFragment.java
new file mode 100644
index 000000000..5c109fbb4
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesFragment.java
@@ -0,0 +1,85 @@
+package fr.free.nrw.commons.explore.recentsearches;
+
+import android.os.Bundle;
+import android.support.v7.app.AlertDialog;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+import android.widget.ArrayAdapter;
+import android.widget.ImageView;
+import android.widget.ListView;
+import android.widget.Toast;
+
+import java.util.List;
+
+import javax.inject.Inject;
+
+import butterknife.BindView;
+import butterknife.ButterKnife;
+import fr.free.nrw.commons.R;
+import fr.free.nrw.commons.di.CommonsDaggerSupportFragment;
+import fr.free.nrw.commons.explore.SearchActivity;
+
+
+/**
+ * Displays the recent searches screen.
+ */
+public class RecentSearchesFragment extends CommonsDaggerSupportFragment {
+ @Inject RecentSearchesDao recentSearchesDao;
+ @BindView(R.id.recent_searches_list) ListView recentSearchesList;
+ List recentSearches;
+ ArrayAdapter adapter;
+ @BindView(R.id.recent_searches_delete_button)
+ ImageView recent_searches_delete_button;
+
+ @Override
+ public View onCreateView(LayoutInflater inflater, ViewGroup container,
+ Bundle savedInstanceState) {
+ View rootView = inflater.inflate(R.layout.fragment_search_history, container, false);
+ ButterKnife.bind(this, rootView);
+ recentSearches = recentSearchesDao.recentSearches(10);
+ recent_searches_delete_button.setOnClickListener(v -> {
+ new AlertDialog.Builder(getContext())
+ .setMessage(getString(R.string.delete_recent_searches_dialog))
+ .setPositiveButton("YES", (dialog, which) -> {
+ recentSearchesDao.deleteAll(recentSearches);
+ Toast.makeText(getContext(),getString(R.string.search_history_deleted),Toast.LENGTH_SHORT).show();
+ recentSearches = recentSearchesDao.recentSearches(10);
+ adapter = new ArrayAdapter(getContext(),R.layout.item_recent_searches, recentSearches);
+ recentSearchesList.setAdapter(adapter);
+ adapter.notifyDataSetChanged();
+ dialog.dismiss();
+ })
+ .setNegativeButton("NO", null)
+ .create()
+ .show();
+ });
+ adapter = new ArrayAdapter(getContext(),R.layout.item_recent_searches, recentSearches);
+ recentSearchesList.setAdapter(adapter);
+ recentSearchesList.setOnItemClickListener((parent, view, position, id) -> (
+ (SearchActivity)getContext()).updateText(recentSearches.get(position)));
+ adapter.notifyDataSetChanged();
+ return rootView;
+ }
+
+ /**
+ * This method is called on back press of activity
+ * so we are updating the list from database to refresh the recent searches list.
+ */
+ @Override
+ public void onResume() {
+ recentSearches = recentSearchesDao.recentSearches(10);
+ adapter.notifyDataSetChanged();
+ super.onResume();
+ }
+
+ /**
+ * This method is called when search query is null to update Recent Searches
+ */
+ public void updateRecentSearches() {
+ recentSearches = recentSearchesDao.recentSearches(10);
+ adapter = new ArrayAdapter(getContext(),R.layout.item_recent_searches, recentSearches);
+ recentSearchesList.setAdapter(adapter);
+ adapter.notifyDataSetChanged();
+ }
+}
diff --git a/app/src/main/java/fr/free/nrw/commons/glide/SvgDecoder.java b/app/src/main/java/fr/free/nrw/commons/glide/SvgDecoder.java
new file mode 100644
index 000000000..9087f9501
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/glide/SvgDecoder.java
@@ -0,0 +1,36 @@
+package fr.free.nrw.commons.glide;
+
+import android.support.annotation.NonNull;
+
+import com.bumptech.glide.load.Options;
+import com.bumptech.glide.load.ResourceDecoder;
+import com.bumptech.glide.load.engine.Resource;
+import com.bumptech.glide.load.resource.SimpleResource;
+import com.caverock.androidsvg.SVG;
+import com.caverock.androidsvg.SVGParseException;
+
+import java.io.IOException;
+import java.io.InputStream;
+
+/**
+ * Decodes an SVG internal representation from an {@link InputStream}.
+ */
+public class SvgDecoder implements ResourceDecoder {
+
+ @Override
+ public boolean handles(@NonNull InputStream source, @NonNull Options options) {
+ // TODO: Can we tell?
+ return true;
+ }
+
+ public Resource