From 66ba35a15fc04990d21eea666871de816eda27da Mon Sep 17 00:00:00 2001 From: Bence Konya Date: Mon, 18 Mar 2019 22:03:51 +0100 Subject: [PATCH] Fix #2205: Fix upload card view arrow direction error (#2653) --- .../fr/free/nrw/commons/upload/UploadActivity.java | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java b/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java index 65c773387..53361dc01 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java @@ -667,8 +667,18 @@ public class UploadActivity extends BaseActivity implements UploadView, SimilarI finish(); } + /** + * Rotates the button and shows or hides the content based on the given state. Typically used + * for collapsing or expanding {@link CardView} animation. + * + * @param state the expanded state of the View whose elements are to be updated. True if + * expanded. + * @param button the image to rotate. Typically an arrow points up when the CardView is + * collapsed and down when it is expanded. + * @param content the Views that should be shown or hidden based on the state. + */ private void updateCardState(boolean state, ImageView button, View... content) { - button.animate().rotation(button.getRotation() + (state ? 180 : -180)).start(); + button.animate().rotation(state ? 180 : 0).start(); if (content != null) { for (View view : content) { view.setVisibility(state ? View.VISIBLE : View.GONE);