From 66395b98719e76d3c6f6546678a361486cc27a97 Mon Sep 17 00:00:00 2001 From: Paul Hawke Date: Sun, 6 Jul 2025 19:50:16 -0500 Subject: [PATCH] convert top level classes to kotlin (#6368) * Converted welcome activity / pager to kotlin * Removed unused interface * Convert ViewPagerAdapter to kotlin and enforce that all tabs must have a title that comes from strings.xml * Convert OkHttpConnectionFactory and remove an exception class nobody was using * Convert MapController to kotlin along with fixing nullability in a few places --- .idea/codeStyles/Project.xml | 1 + .../fr/free/nrw/commons/MapController.java | 30 ---- .../java/fr/free/nrw/commons/MapController.kt | 46 ++++++ .../nrw/commons/OkHttpConnectionFactory.java | 154 ------------------ .../nrw/commons/OkHttpConnectionFactory.kt | 122 ++++++++++++++ .../java/fr/free/nrw/commons/ViewHolder.java | 7 - .../fr/free/nrw/commons/ViewPagerAdapter.java | 68 -------- .../fr/free/nrw/commons/ViewPagerAdapter.kt | 44 +++++ .../fr/free/nrw/commons/WelcomeActivity.java | 109 ------------- .../fr/free/nrw/commons/WelcomeActivity.kt | 78 +++++++++ .../free/nrw/commons/WelcomePagerAdapter.java | 77 --------- .../free/nrw/commons/WelcomePagerAdapter.kt | 70 ++++++++ .../category/CategoryDetailsActivity.kt | 17 +- .../nrw/commons/contributions/MainActivity.kt | 4 +- .../nrw/commons/explore/ExploreFragment.java | 22 +-- .../nrw/commons/explore/SearchActivity.java | 20 +-- .../WikidataItemDetailsActivity.java | 20 +-- .../commons/explore/map/ExploreMapCalls.java | 3 + .../explore/map/ExploreMapPresenter.java | 9 +- .../free/nrw/commons/media/MediaInterface.kt | 2 +- .../commons/navtab/MoreBottomSheetFragment.kt | 4 +- .../free/nrw/commons/nearby/NearbyPlaces.java | 26 ++- .../nrw/commons/profile/ProfileActivity.kt | 35 ++-- .../commons/upload/UploadProgressActivity.kt | 13 +- app/src/main/res/values/strings.xml | 2 + .../free/nrw/commons/MockWebServerTest.java | 110 ------------- .../fr/free/nrw/commons/MockWebServerTest.kt | 110 +++++++++++++ .../free/nrw/commons/TestConnectionFactory.kt | 3 +- .../commons/auth/csrf/CsrfTokenClientTest.kt | 4 +- 29 files changed, 555 insertions(+), 655 deletions(-) delete mode 100644 app/src/main/java/fr/free/nrw/commons/MapController.java create mode 100644 app/src/main/java/fr/free/nrw/commons/MapController.kt delete mode 100644 app/src/main/java/fr/free/nrw/commons/OkHttpConnectionFactory.java create mode 100644 app/src/main/java/fr/free/nrw/commons/OkHttpConnectionFactory.kt delete mode 100644 app/src/main/java/fr/free/nrw/commons/ViewHolder.java delete mode 100644 app/src/main/java/fr/free/nrw/commons/ViewPagerAdapter.java create mode 100644 app/src/main/java/fr/free/nrw/commons/ViewPagerAdapter.kt delete mode 100644 app/src/main/java/fr/free/nrw/commons/WelcomeActivity.java create mode 100644 app/src/main/java/fr/free/nrw/commons/WelcomeActivity.kt delete mode 100644 app/src/main/java/fr/free/nrw/commons/WelcomePagerAdapter.java create mode 100644 app/src/main/java/fr/free/nrw/commons/WelcomePagerAdapter.kt delete mode 100644 app/src/test/kotlin/fr/free/nrw/commons/MockWebServerTest.java create mode 100644 app/src/test/kotlin/fr/free/nrw/commons/MockWebServerTest.kt diff --git a/.idea/codeStyles/Project.xml b/.idea/codeStyles/Project.xml index 5c297a65e..ea0cb3b07 100644 --- a/.idea/codeStyles/Project.xml +++ b/.idea/codeStyles/Project.xml @@ -16,6 +16,7 @@