mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 04:43:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Migrate Feedback module from Java to Kt (#5985)

Browse source 
* Rename `.java` to `.kt`

* Migrated FeedbackContentCreator to kotlin

* Rename FeedbackDialog from `java` to `kt`

* Migrated Feedback Dialog from `java` to `kt`

* Renamed OnFeedbackSubmitCallback to kotlij

* Migrated OnFeedbackSubmitCallback to kotlin

* Fixed: TestCase Failure

* Fixed Test : Changed Private Modifier to Public

* Suppressed deprecated and added TODO for lint

* Linked Deprecation with Github Issue

* Rename Feedback from java to kt

* Migrated Feedback Data Class to Kotlin

* Modified the data class to var for mutuability
This commit is contained in:
Neel Doshi 2024-12-07 12:49:00 +05:30 • committed by GitHub
parent 015c5d5c63
commit 64fd10d00e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 252 additions and 387 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/src/test/kotlin/fr/free/nrw/commons/feedback/FeedbackDialogTests.kt
View file

@ -34,7 +34,7 @@ class FeedbackDialogTests {
private lateinit var dialogFeedbackBinding: DialogFeedbackBinding
@Mock
private val onFeedbackSubmitCallback: OnFeedbackSubmitCallback? = null
private lateinit var onFeedbackSubmitCallback: OnFeedbackSubmitCallback
private lateinit var dialog: FeedbackDialog
private lateinit var context: Context
@ -53,7 +53,7 @@ class FeedbackDialogTests {
dialog.show()
Whitebox.setInternalState(dialog, "onFeedbackSubmitCallback", onFeedbackSubmitCallback)
Whitebox.setInternalState(dialog, "dialogFeedbackBinding", dialogFeedbackBinding)
Whitebox.setInternalState(dialog, "_binding", dialogFeedbackBinding)
}
@Test