From 635deea78e8d727a0a990330bd11edf303dbd294 Mon Sep 17 00:00:00 2001 From: misaochan Date: Tue, 9 Aug 2016 17:18:09 +1200 Subject: [PATCH] Change requestPermissions() call --- .../nrw/commons/contributions/ContributionsListFragment.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java index 0fc2b163b..7f93599f3 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java @@ -114,7 +114,8 @@ public class ContributionsListFragment extends Fragment { //Gallery crashes before reach ShareActivity screen so must implement permissions check here if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) { if (ContextCompat.checkSelfPermission(this.getActivity(), Manifest.permission.READ_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) { - ActivityCompat.requestPermissions(this.getActivity(), new String[]{Manifest.permission.READ_EXTERNAL_STORAGE}, 1); + //See http://stackoverflow.com/questions/33169455/onrequestpermissionsresult-not-being-called-in-dialog-fragment + requestPermissions(new String[]{Manifest.permission.READ_EXTERNAL_STORAGE}, 1); return false; } else { controller.startGalleryPick(); @@ -164,6 +165,7 @@ public class ContributionsListFragment extends Fragment { // 1 = Storage allowed when gallery selected case 1: { if (grantResults.length > 0 && grantResults[0] == PackageManager.PERMISSION_GRANTED) { + Log.d("ContributionsList", "Call controller.startGalleryPick()"); controller.startGalleryPick(); } }