From 60993b310910e6d74a9c26fa12fe7dc093d274b3 Mon Sep 17 00:00:00 2001 From: Madhur Gupta <30932899+madhurgupta10@users.noreply.github.com> Date: Tue, 4 May 2021 21:09:32 +0530 Subject: [PATCH] Fixes #4173 (#4396) --- app/build.gradle | 4 ++-- .../fr/free/nrw/commons/CommonsApplication.java | 3 ++- .../nrw/commons/logging/CommonsLogSender.java | 15 +++++++++++++++ 3 files changed, 19 insertions(+), 3 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 355748b73..0b1c1a475 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -57,8 +57,8 @@ dependencies { implementation "com.squareup.okhttp3:okhttp-ws:$OKHTTP_VERSION" // Logging - implementation 'ch.acra:acra-dialog:5.3.0' - implementation 'ch.acra:acra-mail:5.3.0' + implementation 'ch.acra:acra-dialog:5.8.1-beta11' + implementation 'ch.acra:acra-mail:5.8.1-beta11' implementation 'org.slf4j:slf4j-api:1.7.25' api('com.github.tony19:logback-android-classic:1.1.1-6') { exclude group: 'com.google.android', module: 'android' diff --git a/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java b/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java index 9a1d8187b..f2fdfbd4f 100644 --- a/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java +++ b/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java @@ -68,7 +68,8 @@ import timber.log.Timber; ) @AcraMailSender( - mailTo = "commons-app-android-private@googlegroups.com" + mailTo = "commons-app-android-private@googlegroups.com", + reportAsFile = false ) @AcraDialog( diff --git a/app/src/main/java/fr/free/nrw/commons/logging/CommonsLogSender.java b/app/src/main/java/fr/free/nrw/commons/logging/CommonsLogSender.java index 4e8fe2e70..29c2c732e 100644 --- a/app/src/main/java/fr/free/nrw/commons/logging/CommonsLogSender.java +++ b/app/src/main/java/fr/free/nrw/commons/logging/CommonsLogSender.java @@ -2,12 +2,16 @@ package fr.free.nrw.commons.logging; import android.content.Context; +import android.os.Bundle; import javax.inject.Inject; import javax.inject.Singleton; import fr.free.nrw.commons.auth.SessionManager; import fr.free.nrw.commons.utils.ConfigUtils; import fr.free.nrw.commons.utils.DeviceInfoUtil; +import org.acra.data.CrashReportData; +import org.acra.sender.ReportSenderException; +import org.jetbrains.annotations.NotNull; /** * Class responsible for sending logs to developers @@ -87,4 +91,15 @@ public class CommonsLogSender extends LogsSender { return builder.toString(); } + + @Override + public boolean requiresForeground() { + return false; + } + + @Override + public void send(@NotNull Context context, @NotNull CrashReportData crashReportData, + @NotNull Bundle bundle) throws ReportSenderException { + + } }