mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 21:03:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Use switch statements instead of long if elseifs

Browse source
This commit is contained in:
addshore 2017-05-13 12:52:22 +02:00
parent 6b75810f37
commit 5f6f67d3e2
1 changed files with 41 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

79
app/src/main/java/fr/free/nrw/commons/Utils.java
View file

@ -199,54 +199,57 @@ public class Utils {
} }
public static String licenseTemplateFor(String license) { public static String licenseTemplateFor(String license) {
if (license.equals(Prefs.Licenses.CC_BY_3)) { switch (license) {
return "{{self|cc-by-3.0}}"; case Prefs.Licenses.CC_BY_3:
} else if (license.equals(Prefs.Licenses.CC_BY_4)) { return "{{self|cc-by-3.0}}";
return "{{self|cc-by-4.0}}"; case Prefs.Licenses.CC_BY_4:
} else if (license.equals(Prefs.Licenses.CC_BY_SA_3)) { return "{{self|cc-by-4.0}}";
return "{{self|cc-by-sa-3.0}}"; case Prefs.Licenses.CC_BY_SA_3:
} else if (license.equals(Prefs.Licenses.CC_BY_SA_4)) { return "{{self|cc-by-sa-3.0}}";
return "{{self|cc-by-sa-4.0}}"; case Prefs.Licenses.CC_BY_SA_4:
} else if (license.equals(Prefs.Licenses.CC0)) { return "{{self|cc-by-sa-4.0}}";
return "{{self|cc-zero}}"; case Prefs.Licenses.CC0:
} else if (license.equals(Prefs.Licenses.CC_BY)) { return "{{self|cc-zero}}";
return "{{self|cc-by-3.0}}"; case Prefs.Licenses.CC_BY:
} else if (license.equals(Prefs.Licenses.CC_BY_SA)) { return "{{self|cc-by-3.0}}";
return "{{self|cc-by-sa-3.0}}"; case Prefs.Licenses.CC_BY_SA:
return "{{self|cc-by-sa-3.0}}";
} }
throw new RuntimeException("Unrecognized license value: " + license); throw new RuntimeException("Unrecognized license value: " + license);
} }
public static int licenseNameFor(String license) { public static int licenseNameFor(String license) {
if (license.equals(Prefs.Licenses.CC_BY_3)) { switch (license) {
return R.string.license_name_cc_by; case Prefs.Licenses.CC_BY_3:
} else if (license.equals(Prefs.Licenses.CC_BY_4)) { return R.string.license_name_cc_by;
return R.string.license_name_cc_by_four; case Prefs.Licenses.CC_BY_4:
} else if (license.equals(Prefs.Licenses.CC_BY_SA_3)) { return R.string.license_name_cc_by_four;
return R.string.license_name_cc_by_sa; case Prefs.Licenses.CC_BY_SA_3:
} else if (license.equals(Prefs.Licenses.CC_BY_SA_4)) { return R.string.license_name_cc_by_sa;
return R.string.license_name_cc_by_sa_four; case Prefs.Licenses.CC_BY_SA_4:
} else if (license.equals(Prefs.Licenses.CC0)) { return R.string.license_name_cc_by_sa_four;
return R.string.license_name_cc0; case Prefs.Licenses.CC0:
} else if (license.equals(Prefs.Licenses.CC_BY)) { // for backward compatibility to v2.1 return R.string.license_name_cc0;
return R.string.license_name_cc_by_3_0; case Prefs.Licenses.CC_BY: // for backward compatibility to v2.1
} else if (license.equals(Prefs.Licenses.CC_BY_SA)) { // for backward compatibility to v2.1 return R.string.license_name_cc_by_3_0;
return R.string.license_name_cc_by_sa_3_0; case Prefs.Licenses.CC_BY_SA: // for backward compatibility to v2.1
return R.string.license_name_cc_by_sa_3_0;
} }
throw new RuntimeException("Unrecognized license value: " + license); throw new RuntimeException("Unrecognized license value: " + license);
} }
public static String licenseUrlFor(String license) { public static String licenseUrlFor(String license) {
if (license.equals(Prefs.Licenses.CC_BY_3)) { switch (license) {
return "https://creativecommons.org/licenses/by/3.0/"; case Prefs.Licenses.CC_BY_3:
} else if (license.equals(Prefs.Licenses.CC_BY_4)) { return "https://creativecommons.org/licenses/by/3.0/";
return "https://creativecommons.org/licenses/by/4.0/"; case Prefs.Licenses.CC_BY_4:
} else if (license.equals(Prefs.Licenses.CC_BY_SA_3)) { return "https://creativecommons.org/licenses/by/4.0/";
return "https://creativecommons.org/licenses/by-sa/3.0/"; case Prefs.Licenses.CC_BY_SA_3:
} else if (license.equals(Prefs.Licenses.CC_BY_SA_4)) { return "https://creativecommons.org/licenses/by-sa/3.0/";
return "https://creativecommons.org/licenses/by-sa/4.0/"; case Prefs.Licenses.CC_BY_SA_4:
} else if (license.equals(Prefs.Licenses.CC0)) { return "https://creativecommons.org/licenses/by-sa/4.0/";
return "https://creativecommons.org/publicdomain/zero/1.0/"; case Prefs.Licenses.CC0:
return "https://creativecommons.org/publicdomain/zero/1.0/";
} }
throw new RuntimeException("Unrecognized license value: " + license); throw new RuntimeException("Unrecognized license value: " + license);
} }