mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 12:23:58 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Remove butterknife from achievements fragment (#5382)

Browse source 
* Replace butterknife view bindings

* Migrated onClick listeners, and removed Butterknife
This commit is contained in:
Paul Hawke 2023-11-11 23:39:59 -06:00 • committed by GitHub
parent 861d2b9bf6
commit 5e35db159d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 100 additions and 227 deletions
Download patch file Download diff file Expand all files Collapse all files

219
app/src/main/java/fr/free/nrw/commons/profile/achievements/AchievementsFragment.java
View file

@ -15,18 +15,17 @@ import android.widget.ProgressBar;
import android.widget.RelativeLayout; import android.widget.RelativeLayout;
import android.widget.TextView; import android.widget.TextView;
import android.widget.Toast; import android.widget.Toast;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable; import androidx.annotation.Nullable;
import androidx.appcompat.view.ContextThemeWrapper; import androidx.appcompat.view.ContextThemeWrapper;
import androidx.appcompat.widget.AppCompatTextView; import androidx.appcompat.widget.AppCompatTextView;
import androidx.constraintlayout.widget.ConstraintLayout; import androidx.constraintlayout.widget.ConstraintLayout;
import androidx.vectordrawable.graphics.drawable.VectorDrawableCompat; import androidx.vectordrawable.graphics.drawable.VectorDrawableCompat;
import butterknife.BindView;
import butterknife.ButterKnife;
import butterknife.OnClick;
import com.dinuscxj.progressbar.CircleProgressBar; import com.dinuscxj.progressbar.CircleProgressBar;
import fr.free.nrw.commons.R; import fr.free.nrw.commons.R;
import fr.free.nrw.commons.Utils; import fr.free.nrw.commons.Utils;
import fr.free.nrw.commons.auth.SessionManager; import fr.free.nrw.commons.auth.SessionManager;
import fr.free.nrw.commons.databinding.FragmentAchievementsBinding;
import fr.free.nrw.commons.di.CommonsDaggerSupportFragment; import fr.free.nrw.commons.di.CommonsDaggerSupportFragment;
import fr.free.nrw.commons.mwapi.OkHttpJsonApiClient; import fr.free.nrw.commons.mwapi.OkHttpJsonApiClient;
import fr.free.nrw.commons.utils.ConfigUtils; import fr.free.nrw.commons.utils.ConfigUtils;
@ -62,86 +61,19 @@ public class AchievementsFragment extends CommonsDaggerSupportFragment {
private LevelController.LevelInfo levelInfo; private LevelController.LevelInfo levelInfo;
@BindView(R.id.achievement_badge_image)
ImageView imageView;
@BindView(R.id.achievement_badge_text)
TextView badgeText;
@BindView(R.id.achievement_level)
TextView levelNumber;
@BindView(R.id.thanks_received)
TextView thanksReceived;
@BindView(R.id.images_uploaded_progressbar)
CircleProgressBar imagesUploadedProgressbar;
@BindView(R.id.tv_uploaded_images)
AppCompatTextView uploadedImagesTextview;
@BindView(R.id.images_used_by_wiki_progress_bar)
CircleProgressBar imagesUsedByWikiProgressBar;
@BindView(R.id.tv_wiki_pb)
AppCompatTextView imagesUsedByWikiTextview;
@BindView(R.id.image_reverts_progressbar)
CircleProgressBar imageRevertsProgressbar;
@BindView(R.id.image_featured)
TextView imagesFeatured;
@BindView(R.id.quality_images)
TextView tvQualityImages;
@BindView(R.id.images_revert_limit_text)
TextView imagesRevertLimitText;
@BindView(R.id.progressBar)
ProgressBar progressBar;
@BindView(R.id.layout_image_uploaded)
RelativeLayout layoutImageUploaded;
@BindView(R.id.layout_image_reverts)
RelativeLayout layoutImageReverts;
@BindView(R.id.layout_image_used_by_wiki)
RelativeLayout layoutImageUsedByWiki;
@BindView(R.id.layout_statistics)
LinearLayout layoutStatistics;
@BindView(R.id.images_used_by_wiki_text)
TextView imageByWikiText;
@BindView(R.id.images_reverted_text)
TextView imageRevertedText;
@BindView(R.id.images_upload_text_param)
TextView imageUploadedText;
@BindView(R.id.wikidata_edits)
TextView wikidataEditsText;
@BindView(R.id.tv_achievements_of_user)
AppCompatTextView tvAchievementsOfUser;
@Inject @Inject
SessionManager sessionManager; SessionManager sessionManager;
@Inject @Inject
OkHttpJsonApiClient okHttpJsonApiClient; OkHttpJsonApiClient okHttpJsonApiClient;
private FragmentAchievementsBinding binding;
private CompositeDisposable compositeDisposable = new CompositeDisposable(); private CompositeDisposable compositeDisposable = new CompositeDisposable();
// To keep track of the number of wiki edits made by a user // To keep track of the number of wiki edits made by a user
private int numberOfEdits = 0; private int numberOfEdits = 0;
// menu item for action bar
private MenuItem item;
private String userName; private String userName;
@Override @Override
@ -160,8 +92,17 @@ public class AchievementsFragment extends CommonsDaggerSupportFragment {
*/ */
@Override @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
View rootView = inflater.inflate(R.layout.fragment_achievements, container, false); binding = FragmentAchievementsBinding.inflate(inflater, container, false);
ButterKnife.bind(this, rootView); View rootView = binding.getRoot();
binding.achievementInfo.setOnClickListener(view -> showInfoDialog());
binding.imagesUploadInfo.setOnClickListener(view -> showUploadInfo());
binding.imagesRevertedInfo.setOnClickListener(view -> showRevertedInfo());
binding.imagesUsedByWikiInfo.setOnClickListener(view -> showUsedByWikiInfo());
binding.imagesNearbyInfo.setOnClickListener(view -> showImagesViaNearbyInfo());
binding.imagesFeaturedInfo.setOnClickListener(view -> showFeaturedImagesInfo());
binding.thanksReceivedInfo.setOnClickListener(view -> showThanksReceivedInfo());
binding.qualityImagesInfo.setOnClickListener(view -> showQualityImagesInfo());
// DisplayMetrics used to fetch the size of the screen // DisplayMetrics used to fetch the size of the screen
DisplayMetrics displayMetrics = new DisplayMetrics(); DisplayMetrics displayMetrics = new DisplayMetrics();
@ -171,33 +112,33 @@ public class AchievementsFragment extends CommonsDaggerSupportFragment {
// Used for the setting the size of imageView at runtime // Used for the setting the size of imageView at runtime
ConstraintLayout.LayoutParams params = (ConstraintLayout.LayoutParams) ConstraintLayout.LayoutParams params = (ConstraintLayout.LayoutParams)
imageView.getLayoutParams(); binding.achievementBadgeImage.getLayoutParams();
params.height = (int) (height * BADGE_IMAGE_HEIGHT_RATIO); params.height = (int) (height * BADGE_IMAGE_HEIGHT_RATIO);
params.width = (int) (width * BADGE_IMAGE_WIDTH_RATIO); params.width = (int) (width * BADGE_IMAGE_WIDTH_RATIO);
imageView.requestLayout(); binding.achievementBadgeImage.requestLayout();
progressBar.setVisibility(View.VISIBLE); binding.progressBar.setVisibility(View.VISIBLE);
setHasOptionsMenu(true); setHasOptionsMenu(true);
// Set the initial value of WikiData edits to 0 // Set the initial value of WikiData edits to 0
wikidataEditsText.setText("0"); binding.wikidataEdits.setText("0");
if(sessionManager.getUserName().equals(userName)){ if(sessionManager.getUserName() == null || sessionManager.getUserName().equals(userName)){
tvAchievementsOfUser.setVisibility(View.GONE); binding.tvAchievementsOfUser.setVisibility(View.GONE);
}else{ }else{
tvAchievementsOfUser.setVisibility(View.VISIBLE); binding.tvAchievementsOfUser.setVisibility(View.VISIBLE);
tvAchievementsOfUser.setText(getString(R.string.achievements_of_user,userName)); binding.tvAchievementsOfUser.setText(getString(R.string.achievements_of_user,userName));
} }
// Achievements currently unimplemented in Beta flavor. Skip all API calls. // Achievements currently unimplemented in Beta flavor. Skip all API calls.
if(ConfigUtils.isBetaFlavour()) { if(ConfigUtils.isBetaFlavour()) {
progressBar.setVisibility(View.GONE); binding.progressBar.setVisibility(View.GONE);
imageByWikiText.setText(R.string.no_image); binding.imagesUsedByWikiText.setText(R.string.no_image);
imageRevertedText.setText(R.string.no_image_reverted); binding.imagesRevertedText.setText(R.string.no_image_reverted);
imageUploadedText.setText(R.string.no_image_uploaded); binding.imagesUploadTextParam.setText(R.string.no_image_uploaded);
wikidataEditsText.setText("0"); binding.wikidataEdits.setText("0");
imagesFeatured.setText("0"); binding.imageFeatured.setText("0");
tvQualityImages.setText("0"); binding.qualityImages.setText("0");
thanksReceived.setText("0"); binding.achievementLevel.setText("0");
setMenuVisibility(true); setMenuVisibility(true);
return rootView; return rootView;
} }
@ -206,6 +147,12 @@ public class AchievementsFragment extends CommonsDaggerSupportFragment {
return rootView; return rootView;
} }
@Override
public void onDestroyView() {
binding = null;
super.onDestroyView();
}
@Override @Override
public void setMenuVisibility(boolean visible) { public void setMenuVisibility(boolean visible) {
super.setMenuVisibility(visible); super.setMenuVisibility(visible);
@ -230,8 +177,7 @@ public class AchievementsFragment extends CommonsDaggerSupportFragment {
/** /**
* To invoke the AlertDialog on clicking info button * To invoke the AlertDialog on clicking info button
*/ */
@OnClick(R.id.achievement_info) protected void showInfoDialog(){
public void showInfoDialog(){
launchAlert( launchAlert(
getResources().getString(R.string.Achievements), getResources().getString(R.string.Achievements),
getResources().getString(R.string.achievements_info_message)); getResources().getString(R.string.achievements_info_message));
@ -242,7 +188,7 @@ public class AchievementsFragment extends CommonsDaggerSupportFragment {
* which then calls parseJson when results are fetched * which then calls parseJson when results are fetched
*/ */
private void setAchievements() { private void setAchievements() {
progressBar.setVisibility(View.VISIBLE); binding.progressBar.setVisibility(View.VISIBLE);
if (checkAccount()) { if (checkAccount()) {
try{ try{
@ -256,8 +202,8 @@ public class AchievementsFragment extends CommonsDaggerSupportFragment {
setUploadCount(Achievements.from(response)); setUploadCount(Achievements.from(response));
} else { } else {
Timber.d("success"); Timber.d("success");
layoutImageReverts.setVisibility(View.INVISIBLE); binding.layoutImageReverts.setVisibility(View.INVISIBLE);
imageView.setVisibility(View.INVISIBLE); binding.achievementBadgeImage.setVisibility(View.INVISIBLE);
// If the number of edits made by the user are more than 150,000 // If the number of edits made by the user are more than 150,000
// in some cases such high number of wiki edit counts cause the // in some cases such high number of wiki edit counts cause the
// achievements calculator to fail in some cases, for more details // achievements calculator to fail in some cases, for more details
@ -299,7 +245,7 @@ public class AchievementsFragment extends CommonsDaggerSupportFragment {
.observeOn(AndroidSchedulers.mainThread()) .observeOn(AndroidSchedulers.mainThread())
.subscribe(edits -> { .subscribe(edits -> {
numberOfEdits = edits; numberOfEdits = edits;
wikidataEditsText.setText(String.valueOf(edits)); binding.wikidataEdits.setText(String.valueOf(edits));
}, e -> { }, e -> {
Timber.e("Error:" + e); Timber.e("Error:" + e);
})); }));
@ -314,11 +260,11 @@ public class AchievementsFragment extends CommonsDaggerSupportFragment {
*/ */
private void showSnackBarWithRetry(boolean tooManyAchievements) { private void showSnackBarWithRetry(boolean tooManyAchievements) {
if (tooManyAchievements) { if (tooManyAchievements) {
progressBar.setVisibility(View.GONE); binding.progressBar.setVisibility(View.GONE);
ViewUtil.showDismissibleSnackBar(getActivity().findViewById(android.R.id.content), ViewUtil.showDismissibleSnackBar(getActivity().findViewById(android.R.id.content),
R.string.achievements_fetch_failed_ultimate_achievement, R.string.retry, view -> setAchievements()); R.string.achievements_fetch_failed_ultimate_achievement, R.string.retry, view -> setAchievements());
} else { } else {
progressBar.setVisibility(View.GONE); binding.progressBar.setVisibility(View.GONE);
ViewUtil.showDismissibleSnackBar(getActivity().findViewById(android.R.id.content), ViewUtil.showDismissibleSnackBar(getActivity().findViewById(android.R.id.content),
R.string.achievements_fetch_failed, R.string.retry, view -> setAchievements()); R.string.achievements_fetch_failed, R.string.retry, view -> setAchievements());
} }
@ -329,7 +275,7 @@ public class AchievementsFragment extends CommonsDaggerSupportFragment {
*/ */
private void onError() { private void onError() {
ViewUtil.showLongToast(getActivity(), getResources().getString(R.string.error_occurred)); ViewUtil.showLongToast(getActivity(), getResources().getString(R.string.error_occurred));
progressBar.setVisibility(View.GONE); binding.progressBar.setVisibility(View.GONE);
} }
/** /**
@ -368,10 +314,10 @@ public class AchievementsFragment extends CommonsDaggerSupportFragment {
if (uploadCount==0){ if (uploadCount==0){
setZeroAchievements(); setZeroAchievements();
}else { }else {
imagesUploadedProgressbar.setVisibility(View.VISIBLE); binding.imagesUploadedProgressbar.setVisibility(View.VISIBLE);
imagesUploadedProgressbar.setProgress binding.imagesUploadedProgressbar.setProgress
(100*uploadCount/levelInfo.getMaxUploadCount()); (100*uploadCount/levelInfo.getMaxUploadCount());
uploadedImagesTextview.setText binding.tvUploadedImages.setText
(uploadCount + "/" + levelInfo.getMaxUploadCount()); (uploadCount + "/" + levelInfo.getMaxUploadCount());
} }
@ -387,14 +333,14 @@ public class AchievementsFragment extends CommonsDaggerSupportFragment {
getString(R.string.ok), getString(R.string.ok),
() -> {}, () -> {},
true); true);
imagesUploadedProgressbar.setVisibility(View.INVISIBLE); binding.imagesUploadedProgressbar.setVisibility(View.INVISIBLE);
imageRevertsProgressbar.setVisibility(View.INVISIBLE); binding.imageRevertsProgressbar.setVisibility(View.INVISIBLE);
imagesUsedByWikiProgressBar.setVisibility(View.INVISIBLE); binding.imagesUsedByWikiProgressBar.setVisibility(View.INVISIBLE);
imageView.setVisibility(View.INVISIBLE); binding.achievementBadgeImage.setVisibility(View.INVISIBLE);
imageByWikiText.setText(R.string.no_image); binding.imagesUsedByWikiText.setText(R.string.no_image);
imageRevertedText.setText(R.string.no_image_reverted); binding.imagesRevertedText.setText(R.string.no_image_reverted);
imageUploadedText.setText(R.string.no_image_uploaded); binding.imagesUploadTextParam.setText(R.string.no_image_uploaded);
imageView.setVisibility(View.INVISIBLE); binding.achievementBadgeImage.setVisibility(View.INVISIBLE);
} }
/** /**
@ -402,11 +348,11 @@ public class AchievementsFragment extends CommonsDaggerSupportFragment {
* @param notRevertPercentage * @param notRevertPercentage
*/ */
private void setImageRevertPercentage(int notRevertPercentage){ private void setImageRevertPercentage(int notRevertPercentage){
imageRevertsProgressbar.setVisibility(View.VISIBLE); binding.imageRevertsProgressbar.setVisibility(View.VISIBLE);
imageRevertsProgressbar.setProgress(notRevertPercentage); binding.imageRevertsProgressbar.setProgress(notRevertPercentage);
String revertPercentage = Integer.toString(notRevertPercentage); String revertPercentage = Integer.toString(notRevertPercentage);
imageRevertsProgressbar.setProgressTextFormatPattern(revertPercentage + "%%"); binding.imageRevertsProgressbar.setProgressTextFormatPattern(revertPercentage + "%%");
imagesRevertLimitText.setText(getResources().getString(R.string.achievements_revert_limit_message)+ levelInfo.getMinNonRevertPercentage() + "%"); binding.imagesRevertLimitText.setText(getResources().getString(R.string.achievements_revert_limit_message)+ levelInfo.getMinNonRevertPercentage() + "%");
} }
/** /**
@ -415,90 +361,81 @@ public class AchievementsFragment extends CommonsDaggerSupportFragment {
* @param achievements * @param achievements
*/ */
private void inflateAchievements(Achievements achievements) { private void inflateAchievements(Achievements achievements) {
imagesUsedByWikiProgressBar.setVisibility(View.VISIBLE); binding.imagesUsedByWikiProgressBar.setVisibility(View.VISIBLE);
thanksReceived.setText(String.valueOf(achievements.getThanksReceived())); binding.achievementLevel.setText(String.valueOf(achievements.getThanksReceived()));
imagesUsedByWikiProgressBar.setProgress binding.imagesUsedByWikiProgressBar.setProgress
(100 * achievements.getUniqueUsedImages() / levelInfo.getMaxUniqueImages()); (100 * achievements.getUniqueUsedImages() / levelInfo.getMaxUniqueImages());
if(imagesUsedByWikiTextview != null) { if(binding.tvWikiPb != null) {
imagesUsedByWikiTextview.setText binding.tvWikiPb.setText
(achievements.getUniqueUsedImages() + "/" + levelInfo.getMaxUniqueImages()); (achievements.getUniqueUsedImages() + "/" + levelInfo.getMaxUniqueImages());
} }
imagesFeatured.setText(String.valueOf(achievements.getFeaturedImages())); binding.imageFeatured.setText(String.valueOf(achievements.getFeaturedImages()));
tvQualityImages.setText(String.valueOf(achievements.getQualityImages())); binding.qualityImages.setText(String.valueOf(achievements.getQualityImages()));
String levelUpInfoString = getString(R.string.level).toUpperCase(); String levelUpInfoString = getString(R.string.level).toUpperCase();
levelUpInfoString += " " + levelInfo.getLevelNumber(); levelUpInfoString += " " + levelInfo.getLevelNumber();
levelNumber.setText(levelUpInfoString); binding.achievementLevel.setText(levelUpInfoString);
imageView.setImageDrawable(VectorDrawableCompat.create(getResources(), R.drawable.badge, binding.achievementBadgeImage.setImageDrawable(VectorDrawableCompat.create(getResources(), R.drawable.badge,
new ContextThemeWrapper(getActivity(), levelInfo.getLevelStyle()).getTheme())); new ContextThemeWrapper(getActivity(), levelInfo.getLevelStyle()).getTheme()));
badgeText.setText(Integer.toString(levelInfo.getLevelNumber())); binding.achievementBadgeText.setText(Integer.toString(levelInfo.getLevelNumber()));
} }
/** /**
* to hide progressbar * to hide progressbar
*/ */
private void hideProgressBar(Achievements achievements) { private void hideProgressBar(Achievements achievements) {
if (progressBar != null) { if (binding.progressBar != null) {
levelInfo = LevelController.LevelInfo.from(achievements.getImagesUploaded(), levelInfo = LevelController.LevelInfo.from(achievements.getImagesUploaded(),
achievements.getUniqueUsedImages(), achievements.getUniqueUsedImages(),
achievements.getNotRevertPercentage()); achievements.getNotRevertPercentage());
inflateAchievements(achievements); inflateAchievements(achievements);
setUploadProgress(achievements.getImagesUploaded()); setUploadProgress(achievements.getImagesUploaded());
setImageRevertPercentage(achievements.getNotRevertPercentage()); setImageRevertPercentage(achievements.getNotRevertPercentage());
progressBar.setVisibility(View.GONE); binding.progressBar.setVisibility(View.GONE);
item.setVisible(true);
} }
} }
protected void showUploadInfo(){
@OnClick(R.id.images_upload_info)
public void showUploadInfo(){
launchAlertWithHelpLink( launchAlertWithHelpLink(
getResources().getString(R.string.images_uploaded), getResources().getString(R.string.images_uploaded),
getResources().getString(R.string.images_uploaded_explanation), getResources().getString(R.string.images_uploaded_explanation),
IMAGES_UPLOADED_URL); IMAGES_UPLOADED_URL);
} }
@OnClick(R.id.images_reverted_info) protected void showRevertedInfo(){
public void showRevertedInfo(){
launchAlertWithHelpLink( launchAlertWithHelpLink(
getResources().getString(R.string.image_reverts), getResources().getString(R.string.image_reverts),
getResources().getString(R.string.images_reverted_explanation), getResources().getString(R.string.images_reverted_explanation),
IMAGES_REVERT_URL); IMAGES_REVERT_URL);
} }
@OnClick(R.id.images_used_by_wiki_info) protected void showUsedByWikiInfo(){
public void showUsedByWikiInfo(){
launchAlertWithHelpLink( launchAlertWithHelpLink(
getResources().getString(R.string.images_used_by_wiki), getResources().getString(R.string.images_used_by_wiki),
getResources().getString(R.string.images_used_explanation), getResources().getString(R.string.images_used_explanation),
IMAGES_USED_URL); IMAGES_USED_URL);
} }
@OnClick(R.id.images_nearby_info) protected void showImagesViaNearbyInfo(){
public void showImagesViaNearbyInfo(){
launchAlertWithHelpLink( launchAlertWithHelpLink(
getResources().getString(R.string.statistics_wikidata_edits), getResources().getString(R.string.statistics_wikidata_edits),
getResources().getString(R.string.images_via_nearby_explanation), getResources().getString(R.string.images_via_nearby_explanation),
IMAGES_NEARBY_PLACES_URL); IMAGES_NEARBY_PLACES_URL);
} }
@OnClick(R.id.images_featured_info) protected void showFeaturedImagesInfo(){
public void showFeaturedImagesInfo(){
launchAlertWithHelpLink( launchAlertWithHelpLink(
getResources().getString(R.string.statistics_featured), getResources().getString(R.string.statistics_featured),
getResources().getString(R.string.images_featured_explanation), getResources().getString(R.string.images_featured_explanation),
IMAGES_FEATURED_URL); IMAGES_FEATURED_URL);
} }
@OnClick(R.id.thanks_received_info) protected void showThanksReceivedInfo(){
public void showThanksReceivedInfo(){
launchAlertWithHelpLink( launchAlertWithHelpLink(
getResources().getString(R.string.statistics_thanks), getResources().getString(R.string.statistics_thanks),
getResources().getString(R.string.thanks_received_explanation), getResources().getString(R.string.thanks_received_explanation),
THANKS_URL); THANKS_URL);
} }
@OnClick(R.id.quality_images_info)
public void showQualityImagesInfo() { public void showQualityImagesInfo() {
launchAlertWithHelpLink( launchAlertWithHelpLink(
getResources().getString(R.string.statistics_quality), getResources().getString(R.string.statistics_quality),

108
app/src/test/kotlin/fr/free/nrw/commons/profile/achievements/AchievementsFragmentUnitTests.kt
View file

@ -1,5 +1,6 @@
package fr.free.nrw.commons.profile.achievements package fr.free.nrw.commons.profile.achievements
import android.accounts.Account
import android.content.Context import android.content.Context
import android.os.Looper import android.os.Looper
import android.view.LayoutInflater import android.view.LayoutInflater
@ -55,109 +56,37 @@ class AchievementsFragmentUnitTests {
private lateinit var layoutInflater: LayoutInflater private lateinit var layoutInflater: LayoutInflater
@Mock
private lateinit var imageView: ImageView
@Mock
private lateinit var badgeText: TextView
@Mock
private lateinit var levelNumber: TextView
@Mock
private lateinit var thanksReceived: TextView
@Mock
private lateinit var imagesUploadedProgressbar: CircleProgressBar
@Mock
private lateinit var imagesUsedByWikiProgressBar: CircleProgressBar
@Mock
private lateinit var imageRevertsProgressbar: CircleProgressBar
@Mock
private lateinit var imagesFeatured: TextView
@Mock
private lateinit var tvQualityImages: TextView
@Mock
private lateinit var imagesRevertLimitText: TextView
@Mock
private lateinit var imageByWikiText: TextView
@Mock
private lateinit var imageRevertedText: TextView
@Mock
private lateinit var imageUploadedText: TextView
@Mock
private lateinit var progressBar: ProgressBar
@Mock @Mock
private lateinit var sessionManager: SessionManager private lateinit var sessionManager: SessionManager
@Mock @Mock
private lateinit var parentView: ViewGroup private lateinit var parentView: ViewGroup
@Mock
private lateinit var account: Account
@Before @Before
fun setUp() { fun setUp() {
MockitoAnnotations.openMocks(this) MockitoAnnotations.openMocks(this)
fragment = AchievementsFragment()
Whitebox.setInternalState(fragment, "sessionManager", sessionManager)
Mockito.`when`(sessionManager.userName).thenReturn("Test")
Mockito.`when`(sessionManager.currentAccount).thenReturn(account)
context = ApplicationProvider.getApplicationContext() context = ApplicationProvider.getApplicationContext()
menuItem = RoboMenuItem(context) menuItem = RoboMenuItem(context)
AppAdapter.set(TestAppAdapter()) AppAdapter.set(TestAppAdapter())
val activity = Robolectric.buildActivity(ProfileActivity::class.java).create().get() val activity = Robolectric.buildActivity(ProfileActivity::class.java).create().get()
fragment = AchievementsFragment()
val fragmentManager: FragmentManager = activity.supportFragmentManager val fragmentManager: FragmentManager = activity.supportFragmentManager
val fragmentTransaction: FragmentTransaction = fragmentManager.beginTransaction() val fragmentTransaction: FragmentTransaction = fragmentManager.beginTransaction()
fragmentTransaction.add(fragment, null) fragmentTransaction.add(fragment, null)
fragmentTransaction.commitNowAllowingStateLoss() fragmentTransaction.commitNowAllowingStateLoss()
layoutInflater = LayoutInflater.from(activity) layoutInflater = LayoutInflater.from(activity)
view = LayoutInflater.from(activity) view = fragment.onCreateView(layoutInflater, activity.findViewById(R.id.container), null)!!
.inflate(R.layout.fragment_achievements, null) as View
achievements = Achievements(0, 0, 0, 0, 0, 0, 0) achievements = Achievements(0, 0, 0, 0, 0, 0, 0)
Whitebox.setInternalState(fragment, "thanksReceived", thanksReceived)
Whitebox.setInternalState(
fragment,
"imagesUsedByWikiProgressBar",
imagesUsedByWikiProgressBar
)
Whitebox.setInternalState(
fragment,
"imagesUsedByWikiProgressBar",
imagesUsedByWikiProgressBar
)
Whitebox.setInternalState(fragment, "imagesFeatured", imagesFeatured)
Whitebox.setInternalState(fragment, "tvQualityImages", tvQualityImages)
Whitebox.setInternalState(fragment, "levelNumber", levelNumber)
Whitebox.setInternalState(fragment, "imageView", imageView)
Whitebox.setInternalState(fragment, "badgeText", badgeText)
Whitebox.setInternalState(fragment, "imagesUploadedProgressbar", imagesUploadedProgressbar)
Whitebox.setInternalState(fragment, "imageRevertsProgressbar", imageRevertsProgressbar)
Whitebox.setInternalState(
fragment,
"imagesUsedByWikiProgressBar",
imagesUsedByWikiProgressBar
)
Whitebox.setInternalState(fragment, "imageView", imageView)
Whitebox.setInternalState(fragment, "imageByWikiText", imageByWikiText)
Whitebox.setInternalState(fragment, "imageRevertedText", imageRevertedText)
Whitebox.setInternalState(fragment, "imageUploadedText", imageUploadedText)
Whitebox.setInternalState(fragment, "imageView", imageView)
Whitebox.setInternalState(fragment, "progressBar", progressBar)
Whitebox.setInternalState(fragment, "imagesRevertLimitText", imagesRevertLimitText)
Whitebox.setInternalState(fragment, "item", menuItem)
Whitebox.setInternalState(fragment, "sessionManager", sessionManager)
Whitebox.setInternalState(fragment, "mView", parentView)
Mockito.`when`(sessionManager.userName).thenReturn("Test")
} }
@Test @Test
@ -354,18 +283,20 @@ class AchievementsFragmentUnitTests {
@Test @Test
@Throws(Exception::class) @Throws(Exception::class)
fun testMenuVisibilityOverrideNotVisible() { fun testMenuVisibilityOverrideNotVisible() {
Shadows.shadowOf(Looper.getMainLooper()).idle()
val method: Method = AchievementsFragment::class.java.getDeclaredMethod( val method: Method = AchievementsFragment::class.java.getDeclaredMethod(
"setMenuVisibility", "setMenuVisibility",
Boolean::class.java Boolean::class.java
) )
method.isAccessible = true method.isAccessible = true
method.invoke(fragment, false) method.invoke(fragment, false)
Assert.assertNull(ShadowToast.getLatestToast()) assertToast()
} }
@Test @Test
@Throws(Exception::class) @Throws(Exception::class)
fun testMenuVisibilityOverrideVisibleWithContext() { fun testMenuVisibilityOverrideVisibleWithContext() {
Shadows.shadowOf(Looper.getMainLooper()).idle()
Mockito.`when`(parentView.context).thenReturn(context) Mockito.`when`(parentView.context).thenReturn(context)
val method: Method = AchievementsFragment::class.java.getDeclaredMethod( val method: Method = AchievementsFragment::class.java.getDeclaredMethod(
"setMenuVisibility", "setMenuVisibility",
@ -373,14 +304,19 @@ class AchievementsFragmentUnitTests {
) )
method.isAccessible = true method.isAccessible = true
method.invoke(fragment, true) method.invoke(fragment, true)
if(ConfigUtils.isBetaFlavour) { assertToast()
}
private fun assertToast() {
if (ConfigUtils.isBetaFlavour) {
Assert.assertEquals( Assert.assertEquals(
ShadowToast.getTextOfLatestToast().toString(), ShadowToast.getTextOfLatestToast().toString(),
context.getString(R.string.achievements_unavailable_beta) context.getString(R.string.achievements_unavailable_beta)
) )
} else { } else {
Assert.assertNull( Assert.assertEquals(
ShadowToast.getTextOfLatestToast() context.getString(R.string.user_not_logged_in),
ShadowToast.getTextOfLatestToast().toString()
) )
} }
} }