From 5d4768e1ee0aec6af9ab24b127b78896bdbfe5b2 Mon Sep 17 00:00:00 2001 From: misaochan Date: Mon, 11 Jan 2016 17:02:02 +1300 Subject: [PATCH] Simplify catList is empty logic --- .../java/fr/free/nrw/commons/upload/ShareActivity.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/commons/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java b/commons/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java index d66543c63..d81aaea6b 100644 --- a/commons/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java +++ b/commons/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java @@ -191,7 +191,7 @@ public class ShareActivity //convert image Uri to file path FilePathConverter uriObj = new FilePathConverter(this, mediaUri); String filePath = uriObj.getFilePath(); - + if (filePath != null) { //extract the coordinates of image in decimal degrees @@ -206,11 +206,11 @@ public class ShareActivity app.cacheData.setQtPoint(decLongitude, decLatitude); MwVolleyApi apiCall = new MwVolleyApi(this); - List displayCatList = app.cacheData.findCategory(); - + boolean catListEmpty = displayCatList.isEmpty(); + //if no categories found in cache, call MW API to match image coords with nearby Commons categories - if (displayCatList.size() == 0) { + if (catListEmpty) { cacheFound = false; apiCall.request(decimalCoords); Log.d(TAG, "displayCatList size 0, calling MWAPI" + displayCatList.toString());