From 5a4251fe551efcffa1c84fb3e6e4c75b9e7cad5b Mon Sep 17 00:00:00 2001 From: misaochan Date: Fri, 18 Dec 2015 14:53:51 +1300 Subject: [PATCH] Fixed minor issues --- .../java/fr/free/nrw/commons/MediaWikiImageView.java | 6 +++--- .../fr/free/nrw/commons/media/MediaDetailFragment.java | 1 - .../java/fr/free/nrw/commons/upload/ImageProcessing.java | 9 ++++----- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/commons/src/main/java/fr/free/nrw/commons/MediaWikiImageView.java b/commons/src/main/java/fr/free/nrw/commons/MediaWikiImageView.java index b1b08e172..f733edcf3 100644 --- a/commons/src/main/java/fr/free/nrw/commons/MediaWikiImageView.java +++ b/commons/src/main/java/fr/free/nrw/commons/MediaWikiImageView.java @@ -151,7 +151,7 @@ public class MediaWikiImageView extends ImageView { // from the network. ImageContainer newContainer = mImageLoader.get(mUrl, new ImageListener() { - + @Override public void onErrorResponse(final VolleyError error) { if(!tryOriginal) { post(new Runnable() { @@ -163,7 +163,7 @@ public class MediaWikiImageView extends ImageView { } - + @Override public void onResponse(final ImageContainer response, boolean isImmediate) { // If this was an immediate response that was delivered inside of a layout // pass do not set the image immediately as it will trigger a requestLayout @@ -171,7 +171,7 @@ public class MediaWikiImageView extends ImageView { // the main thread. if (isImmediate && isInLayoutPass) { post(new Runnable() { - + @Override public void run() { onResponse(response, false); } diff --git a/commons/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java b/commons/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java index af31763bc..b6424d728 100644 --- a/commons/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java +++ b/commons/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java @@ -187,7 +187,6 @@ public class MediaDetailFragment extends SherlockFragment { @Override protected void onPreExecute() { extractor = new MediaDataExtractor(media.getFilename(), licenseList); - } @Override diff --git a/commons/src/main/java/fr/free/nrw/commons/upload/ImageProcessing.java b/commons/src/main/java/fr/free/nrw/commons/upload/ImageProcessing.java index 2f7212e66..60b36aced 100644 --- a/commons/src/main/java/fr/free/nrw/commons/upload/ImageProcessing.java +++ b/commons/src/main/java/fr/free/nrw/commons/upload/ImageProcessing.java @@ -11,9 +11,6 @@ import android.util.Log; import java.io.IOException; -/** - * Created by misao on 16-Dec-15. - */ public class ImageProcessing { private Uri uri; @@ -23,8 +20,10 @@ public class ImageProcessing { this.context = context; this.uri = uri; } - - //Gets file path of image from its Uri + /** + * Gets file path of image from its Uri + * May return null + */ public String getFilePath(){ String filePath =""; // Will return "image:x*"