mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 04:43:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Add new location change states

Browse source
This commit is contained in:
neslihanturan 2018-02-19 23:18:57 +03:00
parent 7e999cb364
commit 581483e4ca
1 changed files with 32 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

29
app/src/main/java/fr/free/nrw/commons/location/LocationServiceManager.java
View file

@ -94,10 +94,10 @@ public class LocationServiceManager implements LocationListener {
} }
} }
protected boolean isBetterLocation(Location location, Location currentBestLocation) { protected LocationChangeType isBetterLocation(Location location, Location currentBestLocation) {
if (currentBestLocation == null) { if (currentBestLocation == null) {
// A new location is always better than no location // A new location is always better than no location
return true; return LocationChangeType.LOCATION_SIGNIFICANTLY_CHANGED;
} }
// Check whether the new location fix is newer or older // Check whether the new location fix is newer or older
@ -106,15 +106,6 @@ public class LocationServiceManager implements LocationListener {
boolean isSignificantlyOlder = timeDelta < -MIN_LOCATION_UPDATE_REQUEST_TIME_IN_MILLIS; boolean isSignificantlyOlder = timeDelta < -MIN_LOCATION_UPDATE_REQUEST_TIME_IN_MILLIS;
boolean isNewer = timeDelta > 0; boolean isNewer = timeDelta > 0;
// If it's been more than two minutes since the current location, use the new location
// because the user has likely moved
if (isSignificantlyNewer) {
return true;
// If the new location is more than two minutes older, it must be worse
} else if (isSignificantlyOlder) {
return false;
}
// Check whether the new location fix is more or less accurate // Check whether the new location fix is more or less accurate
int accuracyDelta = (int) (location.getAccuracy() - currentBestLocation.getAccuracy()); int accuracyDelta = (int) (location.getAccuracy() - currentBestLocation.getAccuracy());
boolean isLessAccurate = accuracyDelta > 0; boolean isLessAccurate = accuracyDelta > 0;
@ -133,16 +124,22 @@ public class LocationServiceManager implements LocationListener {
location.getLongitude(), location.getLongitude(),
results); results);
// If it's been more than two minutes since the current location, use the new location
// because the user has likely moved
if (isSignificantlyNewer if (isSignificantlyNewer
|| isMoreAccurate || isMoreAccurate
|| (isNewer && !isLessAccurate) || (isNewer && !isLessAccurate)
|| (isNewer && !isSignificantlyLessAccurate && isFromSameProvider)) { || (isNewer && !isSignificantlyLessAccurate && isFromSameProvider)) {
Log.d("deneme","distance:"+results[0]); Log.d("deneme","distance:"+results[0]);
return true; if (results[0] < 1000) { // Means change is smaller than 1000 meter
return LocationChangeType.LOCATION_SLIGHTLY_CHANGED;
} else {
return LocationChangeType.LOCATION_SIGNIFICANTLY_CHANGED;
}
// If the new location is more than two minutes older, it must be worse // If the new location is more than two minutes older, it must be worse
} else{ } else{
Log.d("deneme","distance:"+results[0]); Log.d("deneme","distance:"+results[0]);
return false; return LocationChangeType.LOCATION_NOT_CHANGED;
} }
} }
@ -206,4 +203,10 @@ public class LocationServiceManager implements LocationListener {
public void onProviderDisabled(String provider) { public void onProviderDisabled(String provider) {
Timber.d("Provider %s disabled", provider); Timber.d("Provider %s disabled", provider);
} }
public enum LocationChangeType{
LOCATION_SIGNIFICANTLY_CHANGED,
LOCATION_SLIGHTLY_CHANGED,
LOCATION_NOT_CHANGED
}
} }