mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-31 14:53:59 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

tests: fix failing testUpdateDepictsProperty

Browse source
This commit is contained in:
Rohit Verma 2024-08-28 09:19:11 +05:30
parent ec4a6bc0c4
commit 51aa0bdff9
2 changed files with 12 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/fr/free/nrw/commons/wikidata/WikiBaseClient.kt
View file

@ -47,9 +47,9 @@ class WikiBaseClient @Inject constructor(
}
}
fun postDeleteClaims(entityId: String, data: String): Observable<Boolean> {
fun postDeleteClaims(entityId: String, data: String?): Observable<Boolean> {
return csrfToken().switchMap { editToken ->
wikiBaseInterface.postDeleteClaims(editToken, entityId, data)
wikiBaseInterface.postDeleteClaims(editToken, entityId, data!!)
.map { response: MwPostResponse -> response.successVal == 1 }
}
}

13
app/src/test/kotlin/fr/free/nrw/commons/wikidata/WikidataEditServiceTest.kt
View file

@ -19,6 +19,7 @@ import org.mockito.Mockito
import org.mockito.Mockito.verifyNoInteractions
import org.mockito.MockitoAnnotations
import fr.free.nrw.commons.wikidata.model.EditClaim
import fr.free.nrw.commons.wikidata.model.RemoveClaim
class WikidataEditServiceTest {
@Mock
@ -53,9 +54,15 @@ class WikidataEditServiceTest {
@Test
fun testUpdateDepictsProperty() {
whenever(wikibaseClient.postEditEntityByFilename("Test.jpg",
gson.toJson(Mockito.mock(EditClaim::class.java)))).thenReturn(Observable.just(true))
wikidataEditService.updateDepictsProperty("Test.jpg", listOf())
val fileEntityId = "12345"
whenever(wikibaseClient.getClaimIdsByProperty("M" + fileEntityId, "P180"))
.thenReturn(Observable.just(emptyList()))
whenever(wikibaseClient.postDeleteClaims("M" + fileEntityId,
gson.toJson(Mockito.mock(RemoveClaim::class.java)))
).thenReturn(Observable.just(true))
wikidataEditService.updateDepictsProperty(fileEntityId, listOf())
}
@Test