mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-29 22:03:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Unit tests resolved

Browse source
This commit is contained in:
Saifuddin 2025-01-07 17:47:02 +05:30
parent 420842676b
commit 4fbe1dcd36
4 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesDao.kt
View file

@ -137,7 +137,7 @@ class BookmarkPicturesDao @Inject constructor(
} }
@SuppressLint("Range") @SuppressLint("Range")
private fun fromCursor(cursor: Cursor): Bookmark { fun fromCursor(cursor: Cursor): Bookmark {
val fileName = cursor.getString(cursor.getColumnIndex(Table.COLUMN_MEDIA_NAME)) val fileName = cursor.getString(cursor.getColumnIndex(Table.COLUMN_MEDIA_NAME))
return Bookmark( return Bookmark(
fileName, fileName,

12
app/src/test/kotlin/fr/free/nrw/commons/bookmarks/pictures/BookmarkPictureDaoTest.kt
View file

@ -19,7 +19,7 @@ import com.nhaarman.mockitokotlin2.verify
import com.nhaarman.mockitokotlin2.whenever import com.nhaarman.mockitokotlin2.whenever
import fr.free.nrw.commons.TestCommonsApplication import fr.free.nrw.commons.TestCommonsApplication
import fr.free.nrw.commons.bookmarks.models.Bookmark import fr.free.nrw.commons.bookmarks.models.Bookmark
import fr.free.nrw.commons.bookmarks.pictures.BookmarkPicturesContentProvider.BASE_URI import fr.free.nrw.commons.bookmarks.pictures.BookmarkPicturesContentProvider.Companion.BASE_URI
import fr.free.nrw.commons.bookmarks.pictures.BookmarkPicturesDao.Table.COLUMN_CREATOR import fr.free.nrw.commons.bookmarks.pictures.BookmarkPicturesDao.Table.COLUMN_CREATOR
import fr.free.nrw.commons.bookmarks.pictures.BookmarkPicturesDao.Table.COLUMN_MEDIA_NAME import fr.free.nrw.commons.bookmarks.pictures.BookmarkPicturesDao.Table.COLUMN_MEDIA_NAME
import fr.free.nrw.commons.bookmarks.pictures.BookmarkPicturesDao.Table.CREATE_TABLE_STATEMENT import fr.free.nrw.commons.bookmarks.pictures.BookmarkPicturesDao.Table.CREATE_TABLE_STATEMENT
@ -84,7 +84,7 @@ class BookmarkPictureDaoTest {
fun getAllBookmarks() { fun getAllBookmarks() {
whenever(client.query(any(), any(), anyOrNull(), any(), anyOrNull())).thenReturn(createCursor(14)) whenever(client.query(any(), any(), anyOrNull(), any(), anyOrNull())).thenReturn(createCursor(14))
var result = testObject.allBookmarks var result = testObject.getAllBookmarks()
assertEquals(14, (result.size)) assertEquals(14, (result.size))
} }
@ -92,19 +92,19 @@ class BookmarkPictureDaoTest {
@Test(expected = RuntimeException::class) @Test(expected = RuntimeException::class)
fun getAllBookmarksTranslatesExceptions() { fun getAllBookmarksTranslatesExceptions() {
whenever(client.query(any(), any(), anyOrNull(), any(), anyOrNull())).thenThrow(RemoteException("")) whenever(client.query(any(), any(), anyOrNull(), any(), anyOrNull())).thenThrow(RemoteException(""))
testObject.allBookmarks testObject.getAllBookmarks()
} }
@Test @Test
fun getAllBookmarksReturnsEmptyList_emptyCursor() { fun getAllBookmarksReturnsEmptyList_emptyCursor() {
whenever(client.query(any(), any(), anyOrNull(), any(), anyOrNull())).thenReturn(createCursor(0)) whenever(client.query(any(), any(), anyOrNull(), any(), anyOrNull())).thenReturn(createCursor(0))
assertTrue(testObject.allBookmarks.isEmpty()) assertTrue(testObject.getAllBookmarks().isEmpty())
} }
@Test @Test
fun getAllBookmarksReturnsEmptyList_nullCursor() { fun getAllBookmarksReturnsEmptyList_nullCursor() {
whenever(client.query(any(), any(), anyOrNull(), any(), anyOrNull())).thenReturn(null) whenever(client.query(any(), any(), anyOrNull(), any(), anyOrNull())).thenReturn(null)
assertTrue(testObject.allBookmarks.isEmpty()) assertTrue(testObject.getAllBookmarks().isEmpty())
} }
@Test @Test
@ -113,7 +113,7 @@ class BookmarkPictureDaoTest {
whenever(client.query(any(), any(), anyOrNull(), any(), anyOrNull())).thenReturn(mockCursor) whenever(client.query(any(), any(), anyOrNull(), any(), anyOrNull())).thenReturn(mockCursor)
whenever(mockCursor.moveToFirst()).thenReturn(false) whenever(mockCursor.moveToFirst()).thenReturn(false)
testObject.allBookmarks testObject.getAllBookmarks()
verify(mockCursor).close() verify(mockCursor).close()
} }

2
app/src/test/kotlin/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesControllerTest.kt
View file

@ -35,7 +35,7 @@ class BookmarkPicturesControllerTest {
fun setup() { fun setup() {
MockitoAnnotations.initMocks(this) MockitoAnnotations.initMocks(this)
val mockMedia = mockMedia val mockMedia = mockMedia
whenever(bookmarkDao!!.allBookmarks) whenever(bookmarkDao!!.getAllBookmarks())
.thenReturn(mockBookmarkList) .thenReturn(mockBookmarkList)
whenever( whenever(
mediaClient!!.getMedia( mediaClient!!.getMedia(

2
app/src/test/kotlin/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesFragmentUnitTests.kt
View file

@ -162,7 +162,7 @@ class BookmarkPicturesFragmentUnitTests {
@Test @Test
@Throws(Exception::class) @Throws(Exception::class)
fun testGetAdapter() { fun testGetAdapter() {
fragment.adapter fragment.getAdapter()
} }
@Test @Test