mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Reduce minSdk back to 21 (#5236)

Browse source 
Commit 0f0358f22 (Bump minSdk to 29, 2023-04-30) bumped the minSdk to
29 since it was found to be necessary for publishing the app to Play
Store.

On futher analysis[1], it seems like that might actually not be necessary.
The crux is:

  1. We (rightly) answer "No" to the Play Console question:

       "Does your app access location in the background in APKs or
        app bundles targeting Android 9 (Pie) or older (SDK level 28 or lower)?"

  2. We do not request for the ACCESS_BACKGROUND_LOCATION permission.

So, it should be safe for us to have the minSdkVersion as 21 itself. If
again we face any rejection of the app update, let us handle it at that
point. I clearly am not able to see any valid reason for Play store to
reject the app update.

[1]: https://github.com/commons-app/apps-android-commons/issues/5223#issuecomment-1569554999

Co-authored-by: Kaartic Sivaraam <kaartic.sn@zohocorp.com>
This commit is contained in:
Kaartic Sivaraam 2023-06-16 12:22:15 +05:30 • committed by GitHub
parent 231b96d00e
commit 4cb3b0cfe9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/build.gradle
View file

@ -177,7 +177,7 @@ android {
versionName '4.1.0' versionName '4.1.0'
setProperty("archivesBaseName", "app-commons-v$versionName-" + getBranchName()) setProperty("archivesBaseName", "app-commons-v$versionName-" + getBranchName())
minSdkVersion 29 minSdkVersion 21
targetSdkVersion 31 targetSdkVersion 31
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
testInstrumentationRunnerArguments clearPackageData: 'true' testInstrumentationRunnerArguments clearPackageData: 'true'