From 4c43bf2bd47136ea83811c41124b5561d7d06c78 Mon Sep 17 00:00:00 2001 From: Shashank Kumar <126143257+shashankiitbhu@users.noreply.github.com> Date: Wed, 27 Mar 2024 18:54:44 +0530 Subject: [PATCH] Fix-Peer Review Buttons not get disabled after voting an Image for deletion (#5519) * Fix-Peer Review Buttons not get disabled after voting an Image for deletion * Fix --- .../free/nrw/commons/delete/DeleteHelper.java | 3 +++ .../nrw/commons/review/ReviewController.java | 4 ++++ .../commons/review/ReviewImageFragment.java | 18 ++++++++++++++++++ 3 files changed, 25 insertions(+) diff --git a/app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.java b/app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.java index 841b0624f..8d807aadb 100644 --- a/app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.java +++ b/app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.java @@ -205,6 +205,8 @@ public class DeleteHelper { }); alert.setPositiveButton(context.getString(R.string.ok), (dialogInterface, i) -> { + reviewCallback.disableButtons(); + String reason = getLocalizedResources(context, Locale.ENGLISH).getString(R.string.delete_helper_ask_alert_set_positive_button_reason) + " "; @@ -229,6 +231,7 @@ public class DeleteHelper { } else { reviewCallback.onFailure(); } + reviewCallback.enableButtons(); }); }); diff --git a/app/src/main/java/fr/free/nrw/commons/review/ReviewController.java b/app/src/main/java/fr/free/nrw/commons/review/ReviewController.java index 0aac8796f..ae69607d1 100644 --- a/app/src/main/java/fr/free/nrw/commons/review/ReviewController.java +++ b/app/src/main/java/fr/free/nrw/commons/review/ReviewController.java @@ -191,5 +191,9 @@ public class ReviewController { void onSuccess(); void onFailure(); + + void disableButtons(); + + void enableButtons(); } } diff --git a/app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.java b/app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.java index fb23654e2..950e4cf12 100644 --- a/app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.java @@ -181,6 +181,24 @@ public class ReviewImageFragment extends CommonsDaggerSupportFragment { public void onFailure() { //do nothing } + + /** + * This function is called when an image is being loaded + * to disable the review buttons + */ + @Override + public void disableButtons() { + ReviewImageFragment.this.disableButtons(); + } + + /** + * This function is called when an image has + * been loaded to enable the review buttons. + */ + @Override + public void enableButtons() { + ReviewImageFragment.this.enableButtons(); + } }; }