From 4a5257c2c77e90e70ecfa82009f9c77ec8c0bff0 Mon Sep 17 00:00:00 2001 From: misaochan Date: Sat, 23 Jun 2018 20:07:06 +1000 Subject: [PATCH] Optimize FileProcessor --- .../main/java/fr/free/nrw/commons/upload/FileProcessor.java | 5 ++--- .../main/java/fr/free/nrw/commons/upload/GPSExtractor.java | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/upload/FileProcessor.java b/app/src/main/java/fr/free/nrw/commons/upload/FileProcessor.java index acb29fe29..b29d686f5 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/FileProcessor.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/FileProcessor.java @@ -119,7 +119,7 @@ public class FileProcessor implements SimilarImageDialogFragment.onResponse { if (decimalCoords == null || !imageObj.imageCoordsExists) { //Find other photos taken around the same time which has gps coordinates if (!haveCheckedForOtherImages) - findOtherImages(gpsEnabled);// Do not do repeat the process + findOtherImages();// Do not do repeat the process } else { useImageCoords(); } @@ -137,9 +137,8 @@ public class FileProcessor implements SimilarImageDialogFragment.onResponse { /** * Find other images around the same location that were taken within the last 20 sec * - * @param gpsEnabled True if GPS is enabled */ - private void findOtherImages(boolean gpsEnabled) { + private void findOtherImages() { Timber.d("filePath" + getPathOfMediaOrCopy()); long timeOfCreation = new File(filePath).lastModified();//Time when the original image was created diff --git a/app/src/main/java/fr/free/nrw/commons/upload/GPSExtractor.java b/app/src/main/java/fr/free/nrw/commons/upload/GPSExtractor.java index caadd14b5..e45b31f05 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/GPSExtractor.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/GPSExtractor.java @@ -1,6 +1,5 @@ package fr.free.nrw.commons.upload; -import android.content.SharedPreferences; import android.media.ExifInterface; import android.support.annotation.NonNull; import android.support.annotation.Nullable; @@ -16,7 +15,7 @@ import timber.log.Timber; * is uploaded, extract latitude and longitude from EXIF data of image. */ public class GPSExtractor { - + private ExifInterface exif; private double decLatitude; private double decLongitude;