From 47368c12854d7ee2bbdcb18cce66bde30ab9a38e Mon Sep 17 00:00:00 2001 From: Rohit Verma Date: Mon, 23 Jun 2025 09:34:48 +0530 Subject: [PATCH] refactor: remove logs added for testing --- .../main/java/fr/free/nrw/commons/delete/DeleteHelper.kt | 7 ------- .../main/java/fr/free/nrw/commons/delete/ReasonBuilder.kt | 1 - .../java/fr/free/nrw/commons/media/MediaDetailFragment.kt | 2 -- .../java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt | 3 --- 4 files changed, 13 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.kt b/app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.kt index 9f481d53e..3f9ae47ac 100644 --- a/app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.kt +++ b/app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.kt @@ -53,10 +53,7 @@ class DeleteHelper @Inject constructor( media: Media?, reason: String? ): Single? { - - Timber.d("Making deletion for title: ${media?.displayTitle} with reason: $reason") if(context == null && media == null) { - Timber.e("context or media is null") return null } @@ -68,13 +65,10 @@ class DeleteHelper @Inject constructor( return reason?.let { delete(media!!, it) .flatMapSingle { result -> - Timber.d("Show deletiong notification") Single.just(showDeletionNotification(context, media, result)) } .firstOrError() .onErrorResumeNext { throwable -> - Timber.e("Error while making deletion") - throwable.printStackTrace() if (throwable is InvalidLoginTokenException) { Single.error(throwable) } else { @@ -91,7 +85,6 @@ class DeleteHelper @Inject constructor( * @return */ private fun delete(media: Media, reason: String): Observable { - Timber.d("thread is delete %s", Thread.currentThread().name) val summary = "Nominating ${media.filename} for deletion." val calendar = Calendar.getInstance() val fileDeleteString = """ diff --git a/app/src/main/java/fr/free/nrw/commons/delete/ReasonBuilder.kt b/app/src/main/java/fr/free/nrw/commons/delete/ReasonBuilder.kt index 63845b7ba..c4cd73b8a 100644 --- a/app/src/main/java/fr/free/nrw/commons/delete/ReasonBuilder.kt +++ b/app/src/main/java/fr/free/nrw/commons/delete/ReasonBuilder.kt @@ -39,7 +39,6 @@ class ReasonBuilder @Inject constructor( if (media == null || reason == null) { return Single.just("Not known") } - Timber.d("Fetching article number") return getAndAppendFileUsage(media, reason) } diff --git a/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt b/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt index b54ed2700..f371b733f 100644 --- a/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt +++ b/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt @@ -1695,7 +1695,6 @@ class MediaDetailFragment : CommonsDaggerSupportFragment(), CategoryEditHelper.C val finalReason: String = reason val resultSingle: Single = reasonBuilder.getReason(media, reason) .flatMap { - Timber.d("Reason builder returned: $it") deleteHelper.makeDeletion( context, media, finalReason ) @@ -1729,7 +1728,6 @@ class MediaDetailFragment : CommonsDaggerSupportFragment(), CategoryEditHelper.C } private fun handleDeletionError(throwable: Throwable) { - Timber.e("Error while nominating for deletion: ${throwable.message}") throwable.printStackTrace() disableProgressBar() checkAndClearDeletionFlag() diff --git a/app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt b/app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt index 04460cb28..a2f92c2e6 100644 --- a/app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt +++ b/app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt @@ -258,21 +258,18 @@ class OkHttpJsonApiClient @Inject constructor( fun getAchievements(userName: String?): Single { val suffix = if (isBetaFlavour) "/feedback.py?labs=commonswiki" else "/feedback.py" val fetchAchievementUrlTemplate = wikiMediaToolforgeUrl.toString() + suffix - Timber.d("Url : $fetchAchievementUrlTemplate and User Name : $userName") return Single.fromCallable({ val url = String.format( Locale.ENGLISH, fetchAchievementUrlTemplate, userName ) - Timber.d("Formatted URL: $url") val urlBuilder: HttpUrl.Builder = url.toHttpUrlOrNull()!!.newBuilder() .addQueryParameter("user", userName) val request: Request = Request.Builder() .url(urlBuilder.toString()) .build() val response: Response = okHttpClient.newCall(request).execute() - Timber.d("Response received: $response | Body: ${response.body} | IsSuccessful: ${response.isSuccessful}") if (response.body != null && response.isSuccessful) { var json: String = response.body!!.string() // Extract JSON from response