diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index fb776920e..d56a874b5 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -232,12 +232,6 @@ android:exported="false" android:label="@string/provider_bookmarks" android:syncable="false" /> - adapter.remove(place) diff --git a/app/src/main/java/fr/free/nrw/commons/db/AppDatabase.kt b/app/src/main/java/fr/free/nrw/commons/db/AppDatabase.kt index ee4da8ee7..d51e53dbe 100644 --- a/app/src/main/java/fr/free/nrw/commons/db/AppDatabase.kt +++ b/app/src/main/java/fr/free/nrw/commons/db/AppDatabase.kt @@ -26,7 +26,7 @@ import fr.free.nrw.commons.upload.depicts.DepictsDao */ @Database( entities = [Contribution::class, Depicts::class, UploadedStatus::class, NotForUploadStatus::class, ReviewEntity::class, Place::class, BookmarksCategoryModal::class, BookmarksLocations::class], - version = 19, + version = 20, exportSchema = false, ) @TypeConverters(Converters::class) diff --git a/app/src/main/java/fr/free/nrw/commons/di/CommonsApplicationModule.kt b/app/src/main/java/fr/free/nrw/commons/di/CommonsApplicationModule.kt index 324c8e1e5..b25998ee5 100644 --- a/app/src/main/java/fr/free/nrw/commons/di/CommonsApplicationModule.kt +++ b/app/src/main/java/fr/free/nrw/commons/di/CommonsApplicationModule.kt @@ -111,11 +111,6 @@ open class CommonsApplicationModule(private val applicationContext: Context) { fun provideBookmarkContentProviderClient(context: Context): ContentProviderClient? = context.contentResolver.acquireContentProviderClient(BuildConfig.BOOKMARK_AUTHORITY) - @Provides - @Named("bookmarksLocation") - fun provideBookmarkLocationContentProviderClient(context: Context): ContentProviderClient? = - context.contentResolver.acquireContentProviderClient(BuildConfig.BOOKMARK_LOCATIONS_AUTHORITY) - @Provides @Named("bookmarksItem") fun provideBookmarkItemContentProviderClient(context: Context): ContentProviderClient? = diff --git a/app/src/main/java/fr/free/nrw/commons/di/FragmentBuilderModule.kt b/app/src/main/java/fr/free/nrw/commons/di/FragmentBuilderModule.kt index 9920fef9f..0ef34e355 100644 --- a/app/src/main/java/fr/free/nrw/commons/di/FragmentBuilderModule.kt +++ b/app/src/main/java/fr/free/nrw/commons/di/FragmentBuilderModule.kt @@ -101,9 +101,6 @@ abstract class FragmentBuilderModule { @ContributesAndroidInjector abstract fun bindBookmarkCategoriesListFragment(): BookmarkCategoriesFragment - @ContributesAndroidInjector - abstract fun bindBookmarkLocationsListFragment(): BookmarkLocationsFragment - @ContributesAndroidInjector abstract fun bindReviewOutOfContextFragment(): ReviewImageFragment diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyUtil.kt b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyUtil.kt index d92796101..d844c7c21 100644 --- a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyUtil.kt +++ b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyUtil.kt @@ -1,8 +1,9 @@ package fr.free.nrw.commons.nearby +import android.util.Log import androidx.lifecycle.LifecycleCoroutineScope +import fr.free.nrw.commons.R import fr.free.nrw.commons.bookmarks.locations.BookmarkLocationsDao -import fr.free.nrw.commons.bookmarks.locations.BookmarksLocations import kotlinx.coroutines.launch object NearbyUtil { @@ -10,13 +11,17 @@ object NearbyUtil { fun getBookmarkLocationExists( bookmarksLocationsDao: BookmarkLocationsDao, name: String, - scope: LifecycleCoroutineScope? - ): Boolean { - var isBookmarked = false + scope: LifecycleCoroutineScope?, + bottomSheetAdapter: BottomSheetAdapter, + ) { scope?.launch { - isBookmarked = bookmarksLocationsDao.findBookmarkLocation(name) + val isBookmarked = bookmarksLocationsDao.findBookmarkLocation(name) + Log.d("isBookmarked", isBookmarked.toString()) + if (isBookmarked) { + bottomSheetAdapter.updateBookmarkIcon(R.drawable.ic_round_star_filled_24px) + } else { + bottomSheetAdapter.updateBookmarkIcon(R.drawable.ic_round_star_border_24px) + } } - - return isBookmarked } } \ No newline at end of file diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/presenter/NearbyParentFragmentPresenter.kt b/app/src/main/java/fr/free/nrw/commons/nearby/presenter/NearbyParentFragmentPresenter.kt index 585755d1e..2c473e3de 100644 --- a/app/src/main/java/fr/free/nrw/commons/nearby/presenter/NearbyParentFragmentPresenter.kt +++ b/app/src/main/java/fr/free/nrw/commons/nearby/presenter/NearbyParentFragmentPresenter.kt @@ -142,29 +142,26 @@ class NearbyParentFragmentPresenter scope: LifecycleCoroutineScope? ) { if (place == null) return - var nowBookmarked: Boolean? = null + var nowBookmarked: Boolean scope?.launch { nowBookmarked = bookmarkLocationDao.updateBookmarkLocation(place) - - } - bookmarkChangedPlaces.add(place) - val placeIndex = - NearbyController.markerLabelList.indexOfFirst { it.place.location == place.location } - NearbyController.markerLabelList[placeIndex] = nowBookmarked?.let { - MarkerPlaceGroup( - it, + bookmarkChangedPlaces.add(place) + val placeIndex = + NearbyController.markerLabelList.indexOfFirst { it.place.location == place.location } + NearbyController.markerLabelList[placeIndex] = MarkerPlaceGroup( + nowBookmarked, NearbyController.markerLabelList[placeIndex].place ) + nearbyParentFragmentView.setFilterState() } - nearbyParentFragmentView.setFilterState() } override fun attachView(view: NearbyParentFragmentContract.View) { - this.nearbyParentFragmentView = view + nearbyParentFragmentView = view } override fun detachView() { - this.nearbyParentFragmentView = DUMMY + nearbyParentFragmentView = DUMMY } override fun removeNearbyPreferences(applicationKvStore: JsonKvStore) {