From 43fc4d742716861ed9be1af7ef2a0f1a91efd154 Mon Sep 17 00:00:00 2001 From: misaochan Date: Thu, 8 Dec 2016 19:38:17 +1300 Subject: [PATCH] Add comments --- .../free/nrw/commons/contributions/ContributionController.java | 3 ++- .../main/java/fr/free/nrw/commons/upload/ShareActivity.java | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java index 5e44edf8a..13aaeef07 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java @@ -72,8 +72,9 @@ public class ContributionController { shareIntent.setAction(Intent.ACTION_SEND); switch(requestCode) { case SELECT_FROM_GALLERY: - //FIXME: Handles image picked from gallery (from Google Photos) + //Handles image picked from gallery Uri imageData = data.getData(); + //TODO: Check SHA1 hash of image data here? shareIntent.setType(activity.getContentResolver().getType(imageData)); shareIntent.putExtra(Intent.EXTRA_STREAM, imageData); shareIntent.putExtra(UploadService.EXTRA_SOURCE, fr.free.nrw.commons.contributions.Contribution.SOURCE_GALLERY); diff --git a/app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java b/app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java index 94d87bad3..db5b256df 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java @@ -117,7 +117,7 @@ public class ShareActivity Log.d(TAG, "Cache the categories found"); } - //TODO: Pass in coords here? Need to be in format 37.51136|-77.602615 , which decimalCoords appears to be + //TODO: Check for SHA1 hash of selected file uploadController.startUpload(title, mediaUri, description, mimeType, source, decimalCoords, new UploadController.ContributionUploadProgress() { public void onUploadStarted(Contribution contribution) { ShareActivity.this.contribution = contribution;