mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Refactor focus change listener to improve readability and avoid crashes (#6080)

Browse source
This commit is contained in:
Sonal Yadav 2024-12-26 20:56:08 +05:30 • committed by GitHub
parent 75ca96a526
commit 4244373a5d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

17
app/src/main/java/fr/free/nrw/commons/nearby/PlaceAdapterDelegate.kt
View file

@ -41,15 +41,18 @@ fun placeAdapterDelegate(
showOrHideAndScrollToIfLast() showOrHideAndScrollToIfLast()
onItemClick?.invoke(item) onItemClick?.invoke(item)
} }
root.setOnFocusChangeListener { view1: View?, hasFocus: Boolean -> root.setOnFocusChangeListener { _: View?, hasFocus: Boolean ->
val parentView = root.parent.parent.parent as? RelativeLayout
val bottomSheetBehavior = parentView?.let { BottomSheetBehavior.from(it) }
// Hide button layout if focus is lost, otherwise show it if it's not already visible
if (!hasFocus && nearbyButtonLayout.buttonLayout.isShown) { if (!hasFocus && nearbyButtonLayout.buttonLayout.isShown) {
nearbyButtonLayout.buttonLayout.visibility = GONE nearbyButtonLayout.buttonLayout.visibility = GONE
} else if (hasFocus && !nearbyButtonLayout.buttonLayout.isShown && } else if (hasFocus && !nearbyButtonLayout.buttonLayout.isShown) {
BottomSheetBehavior.from(root.parent.parent.parent as RelativeLayout).state != if (bottomSheetBehavior?.state != BottomSheetBehavior.STATE_HIDDEN) {
BottomSheetBehavior.STATE_HIDDEN showOrHideAndScrollToIfLast()
) { onItemClick?.invoke(item)
showOrHideAndScrollToIfLast() }
onItemClick?.invoke(item)
} }
} }
nearbyButtonLayout.cameraButton.setOnClickListener { onCameraClicked(item, inAppCameraLocationPermissionLauncher, cameraPickLauncherForResult) } nearbyButtonLayout.cameraButton.setOnClickListener { onCameraClicked(item, inAppCameraLocationPermissionLauncher, cameraPickLauncherForResult) }