mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 12:23:58 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Convert BasePresenter to kotlin

Browse source
This commit is contained in:
Paul Hawke 2025-06-29 15:42:58 -05:00
parent 64808ed248
commit 41b41f7021
5 changed files with 13 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

18
app/src/main/java/fr/free/nrw/commons/BasePresenter.java
View file

@ -1,18 +0,0 @@
package fr.free.nrw.commons;
import androidx.annotation.NonNull;
/**
* Base presenter, enforcing contracts to atach and detach view
*/
public interface BasePresenter<T> {
/**
* Until a view is attached, it is open to listen events from the presenter
*/
void onAttachView(@NonNull T view);
/**
* Detaching a view makes sure that the view no more receives events from the presenter
*/
void onDetachView();
}

10
app/src/main/java/fr/free/nrw/commons/BasePresenter.kt Normal file
View file

@ -0,0 +1,10 @@
package fr.free.nrw.commons
/**
* Base presenter, enforcing contracts to attach and detach view
*/
interface BasePresenter<T> {
fun onAttachView(view: T)
fun onDetachView()
}

2
app/src/main/java/fr/free/nrw/commons/campaigns/CampaignsPresenter.kt
View file

@ -26,7 +26,7 @@ class CampaignsPresenter @Inject constructor(
private val okHttpJsonApiClient: OkHttpJsonApiClient?, private val okHttpJsonApiClient: OkHttpJsonApiClient?,
@param:Named(IO_THREAD) private val ioScheduler: Scheduler, @param:Named(IO_THREAD) private val ioScheduler: Scheduler,
@param:Named(MAIN_THREAD) private val mainThreadScheduler: Scheduler @param:Named(MAIN_THREAD) private val mainThreadScheduler: Scheduler
) : BasePresenter<ICampaignsView?> { ) : BasePresenter<ICampaignsView> {
private var view: ICampaignsView? = null private var view: ICampaignsView? = null
private var disposable: Disposable? = null private var disposable: Disposable? = null
private var campaign: Campaign? = null private var campaign: Campaign? = null

2
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListContract.kt
View file

@ -15,7 +15,7 @@ class ContributionsListContract {
fun showNoContributionsUI(shouldShow: Boolean) fun showNoContributionsUI(shouldShow: Boolean)
} }
interface UserActionListener : BasePresenter<View?> { interface UserActionListener : BasePresenter<View> {
fun refreshList(swipeRefreshLayout: SwipeRefreshLayout?) fun refreshList(swipeRefreshLayout: SwipeRefreshLayout?)
} }
} }

2
app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaDetailsContract.kt
View file

@ -54,7 +54,7 @@ interface UploadMediaDetailsContract {
fun showBadImagePopup(errorCode: Int, index: Int, uploadItem: UploadItem) fun showBadImagePopup(errorCode: Int, index: Int, uploadItem: UploadItem)
} }
interface UserActionListener : BasePresenter<View?> { interface UserActionListener : BasePresenter<View> {
fun setupBasicKvStoreFactory(factory: (String) -> BasicKvStore) fun setupBasicKvStoreFactory(factory: (String) -> BasicKvStore)
fun receiveImage( fun receiveImage(