mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 04:43:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

4664: Moved PageableMediaFragment to ViewBinding (#5090)

Browse source
This commit is contained in:
Ankush Bose 2022-10-29 15:03:43 +05:30 • committed by GitHub
parent 4c24b65d2d
commit 3fd63b009a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

23
app/src/main/java/fr/free/nrw/commons/explore/media/PageableMediaFragment.kt
View file

@ -2,17 +2,24 @@ package fr.free.nrw.commons.explore.media
import android.content.Context import android.content.Context
import android.os.Bundle import android.os.Bundle
import android.view.LayoutInflater
import android.view.View import android.view.View
import android.view.ViewGroup
import fr.free.nrw.commons.Media import fr.free.nrw.commons.Media
import fr.free.nrw.commons.R import fr.free.nrw.commons.R
import fr.free.nrw.commons.category.CategoryImagesCallback import fr.free.nrw.commons.category.CategoryImagesCallback
import fr.free.nrw.commons.databinding.FragmentSearchPaginatedBinding
import fr.free.nrw.commons.explore.paging.BasePagingFragment import fr.free.nrw.commons.explore.paging.BasePagingFragment
import fr.free.nrw.commons.media.MediaDetailPagerFragment.MediaDetailProvider import fr.free.nrw.commons.media.MediaDetailPagerFragment.MediaDetailProvider
import kotlinx.android.synthetic.main.fragment_search_paginated.*
abstract class PageableMediaFragment : BasePagingFragment<Media>(), MediaDetailProvider { abstract class PageableMediaFragment : BasePagingFragment<Media>(), MediaDetailProvider {
/**
* ViewBinding
*/
private var _binding: FragmentSearchPaginatedBinding? = null
private val binding get() = _binding
override val pagedListAdapter by lazy { override val pagedListAdapter by lazy {
PagedMediaAdapter(categoryImagesCallback::onMediaClicked) PagedMediaAdapter(categoryImagesCallback::onMediaClicked)
} }
@ -32,6 +39,15 @@ abstract class PageableMediaFragment : BasePagingFragment<Media>(), MediaDetailP
} }
} }
override fun onCreateView(
inflater: LayoutInflater,
container: ViewGroup?,
savedInstanceState: Bundle?
): View? {
_binding = FragmentSearchPaginatedBinding.inflate(inflater, container, false)
return binding?.root
}
private val simpleDataObserver = private val simpleDataObserver =
SimpleDataObserver { categoryImagesCallback.viewPagerNotifyDataSetChanged() } SimpleDataObserver { categoryImagesCallback.viewPagerNotifyDataSetChanged() }
@ -41,6 +57,7 @@ abstract class PageableMediaFragment : BasePagingFragment<Media>(), MediaDetailP
} }
override fun onDestroyView() { override fun onDestroyView() {
_binding = null
super.onDestroyView() super.onDestroyView()
pagedListAdapter.unregisterAdapterDataObserver(simpleDataObserver) pagedListAdapter.unregisterAdapterDataObserver(simpleDataObserver)
} }
@ -49,7 +66,7 @@ abstract class PageableMediaFragment : BasePagingFragment<Media>(), MediaDetailP
pagedListAdapter.currentList?.get(position)?.takeIf { it.filename != null } pagedListAdapter.currentList?.get(position)?.takeIf { it.filename != null }
.also { .also {
pagedListAdapter.currentList?.loadAround(position) pagedListAdapter.currentList?.loadAround(position)
paginatedSearchResultsList.scrollToPosition(position) binding?.paginatedSearchResultsList?.scrollToPosition(position)
} }
override fun getTotalMediaCount(): Int = pagedListAdapter.itemCount override fun getTotalMediaCount(): Int = pagedListAdapter.itemCount