mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 12:53:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixes on Edit button, there is + sign overlayed over letter E #5388 (#5464)

Browse source 
* Fixed Grey empty screen at Upload wizard caption step after denying files permission

* Empty commit

* Fixed loop issue

* Created docs for earlier commits

* Fixed javadoc

* Fixed spaces

* Added added basic features to OSM Maps

* Added search location feature

* Added filter to Open Street Maps

* Fixed chipGroup in Open Street Maps

* Removed mapBox code

* Removed mapBox's code

* Reformat code

* Reformatted code

* Removed rotation feature to map

* Removed rotation files and Fixed Marker click problem

* Ignored failing tests

* Added voice input feature

* Fixed test cases

* Changed caption and description text

* Replaced mapbox to osmdroid in upload activity

* Fixed Unit Tests

* Made selected marker to be fixed on map

* Changed color of map marker

* Fixes #5439 by capitalizing first letter of voice input

* Made UI changes in UploadMediaDetailAdapter

* Added javadoc

---------

Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
This commit is contained in:
Kanahia 2024-01-23 19:33:38 +05:30 • committed by GitHub
parent ab3540312a
commit 3d0e65c92c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
14 changed files with 263 additions and 112 deletions
Download patch file Download diff file Expand all files Collapse all files

12
app/src/test/kotlin/fr/free/nrw/commons/description/DescriptionEditActivityUnitTest.kt
View file

@ -124,18 +124,6 @@ class DescriptionEditActivityUnitTest {
assertEquals(activity.isFinishing, true)
}
@Test
@Throws(Exception::class)
fun testOnButtonAddDescriptionClicked() {
Shadows.shadowOf(Looper.getMainLooper()).idle()
val method: Method = DescriptionEditActivity::class.java.getDeclaredMethod(
"onButtonAddDescriptionClicked", View::class.java
)
method.isAccessible = true
method.invoke(activity, null)
verify(uploadMediaDetailAdapter).addDescription(UploadMediaDetail())
}
@Test
@Throws(Exception::class)
fun testOnBackButtonClicked() {

23
app/src/test/kotlin/fr/free/nrw/commons/upload/mediaDetails/UploadMediaDetailFragmentUnitTest.kt
View file

@ -72,7 +72,9 @@ class UploadMediaDetailFragmentUnitTest {
private lateinit var btnNext: AppCompatButton
private lateinit var btnCopyToSubsequentMedia: AppCompatButton
private lateinit var photoViewBackgroundImage: PhotoView
private lateinit var ibMap: AppCompatImageButton
private lateinit var locationStatusLl: LinearLayout
private lateinit var locationImageView : ImageView
private lateinit var locationTextView : TextView
private lateinit var llContainerMediaDetail: LinearLayout
private lateinit var ibExpandCollapse: AppCompatImageButton
@ -134,7 +136,9 @@ class UploadMediaDetailFragmentUnitTest {
btnNext = view.findViewById(R.id.btn_next)
btnCopyToSubsequentMedia = view.findViewById(R.id.btn_copy_subsequent_media)
photoViewBackgroundImage = view.findViewById(R.id.backgroundImage)
ibMap = view.findViewById(R.id.ib_map)
locationStatusLl = view.findViewById(R.id.ll_location_status)
locationImageView = view.findViewById(R.id.location_image_view)
locationTextView = view.findViewById(R.id.location_text_view)
llContainerMediaDetail = view.findViewById(R.id.ll_container_media_detail)
ibExpandCollapse = view.findViewById(R.id.ib_expand_collapse)
@ -147,7 +151,9 @@ class UploadMediaDetailFragmentUnitTest {
Whitebox.setInternalState(fragment, "btnCopyToSubsequentMedia", btnCopyToSubsequentMedia)
Whitebox.setInternalState(fragment, "photoViewBackgroundImage", photoViewBackgroundImage)
Whitebox.setInternalState(fragment, "uploadMediaDetailAdapter", uploadMediaDetailAdapter)
Whitebox.setInternalState(fragment, "ibMap", ibMap)
Whitebox.setInternalState(fragment, "llLocationStatus", locationStatusLl)
Whitebox.setInternalState(fragment, "locationImageView", locationImageView)
Whitebox.setInternalState(fragment, "locationTextView", locationTextView)
Whitebox.setInternalState(fragment, "llContainerMediaDetail", llContainerMediaDetail)
Whitebox.setInternalState(fragment, "ibExpandCollapse", ibExpandCollapse)
}
@ -245,13 +251,6 @@ class UploadMediaDetailFragmentUnitTest {
fragment.onPreviousButtonClicked()
}
@Test
@Throws(Exception::class)
fun testOnButtonAddDescriptionClicked() {
Shadows.shadowOf(Looper.getMainLooper()).idle()
fragment.onButtonAddDescriptionClicked()
}
@Test
@Throws(Exception::class)
fun testShowSimilarImageFragment() {
@ -429,9 +428,9 @@ class UploadMediaDetailFragmentUnitTest {
@Test
@Throws(Exception::class)
fun testOnRlContainerTitleClicked() {
fun testOnLlContainerTitleClicked() {
Shadows.shadowOf(Looper.getMainLooper()).idle()
fragment.onRlContainerTitleClicked()
fragment.onLlContainerTitleClicked()
}
@Test