mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 04:43:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix #3416 Add snackbar on clicking add/remove from bookmarks (#3419)

Browse source
This commit is contained in:
Yash Khare 2020-02-21 15:31:28 +05:30 • committed by GitHub
parent d423dbb0be
commit 39cb190571
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java
View file

@ -20,6 +20,8 @@ import androidx.fragment.app.FragmentManager;
import androidx.fragment.app.FragmentStatePagerAdapter; import androidx.fragment.app.FragmentStatePagerAdapter;
import androidx.viewpager.widget.ViewPager; import androidx.viewpager.widget.ViewPager;
import com.google.android.material.snackbar.Snackbar;
import javax.inject.Inject; import javax.inject.Inject;
import javax.inject.Named; import javax.inject.Named;
@ -148,7 +150,9 @@ public class MediaDetailPagerFragment extends CommonsDaggerSupportFragment imple
Media m = provider.getMediaAtPosition(pager.getCurrentItem()); Media m = provider.getMediaAtPosition(pager.getCurrentItem());
switch (item.getItemId()) { switch (item.getItemId()) {
case R.id.menu_bookmark_current_image: case R.id.menu_bookmark_current_image:
bookmarkDao.updateBookmark(bookmark); boolean bookmarkExists = bookmarkDao.updateBookmark(bookmark);
Snackbar snackbar = bookmarkExists ? Snackbar.make(getView(), R.string.add_bookmark, Snackbar.LENGTH_LONG) : Snackbar.make(getView(), R.string.remove_bookmark, Snackbar.LENGTH_LONG);
snackbar.show();
updateBookmarkState(item); updateBookmarkState(item);
return true; return true;
case R.id.menu_share_current_image: case R.id.menu_share_current_image:

2
app/src/main/res/values/strings.xml
View file

@ -591,4 +591,6 @@ Upload your first media by tapping on the add button.</string>
<string name="upload_nearby_place_found_title">Nearby Place Found</string> <string name="upload_nearby_place_found_title">Nearby Place Found</string>
<string name="upload_nearby_place_found_description">Is this a photo of Place %1$s?</string> <string name="upload_nearby_place_found_description">Is this a photo of Place %1$s?</string>
<string name="remove_bookmark">Removed from bookmarks</string>
<string name="add_bookmark">Added to bookmarks</string>
</resources> </resources>