diff --git a/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java b/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java index 24ba437e5..65c773387 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java @@ -109,9 +109,7 @@ public class UploadActivity extends BaseActivity implements UploadView, SimilarI @BindView(R.id.license_subtitle) TextView licenseSubtitle; @BindView(R.id.please_wait_text_view) TextView pleaseWaitTextView; - //Right Card - @BindView(R.id.right_card) CardView rightCard; - @BindView(R.id.right_card_expand_button) ImageView rightCardExpandButton; + @BindView(R.id.right_card_map_button) View rightCardMapButton; // Category Search @@ -325,7 +323,7 @@ public class UploadActivity extends BaseActivity implements UploadView, SimilarI @Override public void setRightCardVisibility(boolean visible) { - rightCard.setVisibility(visible ? View.VISIBLE : View.GONE); + rightCardMapButton.setVisibility(visible ? View.VISIBLE : View.GONE); } @Override @@ -358,12 +356,6 @@ public class UploadActivity extends BaseActivity implements UploadView, SimilarI updateCardState(state, bottomCardExpandButton, rvDescriptions, previous, next, bottomCardAddDescription); } - @Override - public void setRightCardState(boolean state) { - rightCardExpandButton.animate().rotation(rightCardExpandButton.getRotation() + (state ? -180 : 180)).start(); - //Add all items in rightCard here - rightCardMapButton.setVisibility(state ? View.VISIBLE : View.GONE); - } @Override public void setBackground(Uri mediaUri) { @@ -530,7 +522,6 @@ public class UploadActivity extends BaseActivity implements UploadView, SimilarI } private void configureRightCard() { - rightCardExpandButton.setOnClickListener(v -> presenter.toggleRightCardState()); rightCardMapButton.setOnClickListener(v -> presenter.openCoordinateMap()); } diff --git a/app/src/main/java/fr/free/nrw/commons/upload/UploadPresenter.java b/app/src/main/java/fr/free/nrw/commons/upload/UploadPresenter.java index ba0e60fed..30bfc037f 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/UploadPresenter.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/UploadPresenter.java @@ -262,14 +262,6 @@ public class UploadPresenter { view.setBottomCardState(uploadModel.isBottomCardState()); } - /** - * Toggles the right card's state between open and closed. - */ - void toggleRightCardState() { - uploadModel.setRightCardState(!uploadModel.isRightCardState()); - view.setRightCardState(uploadModel.isRightCardState()); - } - /** * Sets all the cards' states to closed. */ @@ -280,7 +272,6 @@ public class UploadPresenter { } if (uploadModel.isRightCardState()) { uploadModel.setRightCardState(false); - view.setRightCardState(false); } if (uploadModel.isBottomCardState()) { uploadModel.setBottomCardState(false); diff --git a/app/src/main/java/fr/free/nrw/commons/upload/UploadView.java b/app/src/main/java/fr/free/nrw/commons/upload/UploadView.java index a55e32208..dff659474 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/UploadView.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/UploadView.java @@ -42,8 +42,6 @@ public interface UploadView { void setBottomCardState(boolean state); - void setRightCardState(boolean bottomCardState); - void setBackground(Uri mediaUri); void setTopCardVisibility(boolean visible); diff --git a/app/src/main/res/layout/activity_upload_bottom_card.xml b/app/src/main/res/layout/activity_upload_bottom_card.xml index 0a862f102..f752f9aa2 100644 --- a/app/src/main/res/layout/activity_upload_bottom_card.xml +++ b/app/src/main/res/layout/activity_upload_bottom_card.xml @@ -66,50 +66,8 @@ - - - - - - - - - - - - + + - +