From 3842ba952fdff7e20dbfa42bb4dd2805f96ec857 Mon Sep 17 00:00:00 2001 From: Rohit Verma Date: Wed, 2 Apr 2025 17:07:46 +0530 Subject: [PATCH] refactor: avoid checking fragment is currentSelectedPosition is out of bounds --- .../main/java/fr/free/nrw/commons/upload/UploadActivity.kt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.kt b/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.kt index 8b7e41370..ee0b21210 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.kt +++ b/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.kt @@ -388,7 +388,10 @@ class UploadActivity : BaseActivity(), UploadContract.View, UploadBaseFragment.C fragments!!.removeAt(index) //Remove the corresponding fragment uploadableFiles.removeAt(index) //Remove the files from the list - if(fragments!![currentSelectedPosition] !is UploadMediaDetailFragment) { + val isMediaDetailFragment = fragments!!.getOrNull(currentSelectedPosition)?.let { + it is UploadMediaDetailFragment + } ?: false + if(!isMediaDetailFragment) { // Should hide the top card current fragment is not the media detail fragment showHideTopCard(false) }