From 369fe3183c16b269b3a4fd02e85d5d92aa36cf8c Mon Sep 17 00:00:00 2001
From: Kaartic Sivaraam <sivaraam@users.noreply.github.com>
Date: Sun, 22 Jul 2018 19:26:17 +0530
Subject: [PATCH] Give a useful label for the share intent (#1680)

It's better to give a useful label that would indicate what would
happen when sharing using the app rather than letting it default
to the app name.
---
 app/src/main/AndroidManifest.xml    | 4 ++--
 app/src/main/res/values/strings.xml | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 38fc2e35a..1c7961a48 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -45,7 +45,7 @@
             android:name=".upload.ShareActivity"
             android:icon="@drawable/ic_launcher"
             android:label="@string/app_name">
-            <intent-filter>
+            <intent-filter android:label="@string/intent_share_upload_label">
                 <action android:name="android.intent.action.SEND" />
                 <category android:name="android.intent.category.DEFAULT" />
                 <data android:mimeType="image/*" />
@@ -57,7 +57,7 @@
             android:name=".upload.MultipleShareActivity"
             android:icon="@drawable/ic_launcher"
             android:label="@string/app_name">
-            <intent-filter>
+            <intent-filter android:label="@string/intent_share_upload_label">
                 <action android:name="android.intent.action.SEND_MULTIPLE" />
                 <category android:name="android.intent.category.DEFAULT" />
                 <data android:mimeType="image/*" />
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index eef7b57c1..8b2226610 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -7,6 +7,7 @@
   <string name="app_name">Commons</string>
   <string name="bullet">&#8226;  </string>
   <string name="menu_settings">Settings</string>
+  <string name="intent_share_upload_label">Upload to Commons</string>
   <string name="username">Username</string>
   <string name="password">Password</string>
   <string name="login_credential">Log in to your Commons Beta account</string>