mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 04:43:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Add comments

Browse source
This commit is contained in:
misaochan 2016-07-12 19:10:30 +12:00
parent 619c14857d
commit 350679dc5d
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java
View file

@ -85,7 +85,7 @@ public class ContributionController {
try { try {
activity.startActivity(shareIntent); activity.startActivity(shareIntent);
} catch (SecurityException e) { } catch (SecurityException e) {
//FIXME: Add permission request here //FIXME: Add permission request here. Only startActivity if permission has been granted.
Log.e("ContributionController", "Security Exception", e); Log.e("ContributionController", "Security Exception", e);
} }
} }

3
app/src/main/java/fr/free/nrw/commons/upload/UploadController.java
View file

@ -90,7 +90,7 @@ public class UploadController {
public void startUpload(final Contribution contribution, final ContributionUploadProgress onComplete) { public void startUpload(final Contribution contribution, final ContributionUploadProgress onComplete) {
//FIXME: Add permission request here
SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(activity); SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(activity);
if(TextUtils.isEmpty(contribution.getCreator())) { if(TextUtils.isEmpty(contribution.getCreator())) {
@ -104,6 +104,7 @@ public class UploadController {
String license = prefs.getString(Prefs.DEFAULT_LICENSE, Prefs.Licenses.CC_BY_SA); String license = prefs.getString(Prefs.DEFAULT_LICENSE, Prefs.Licenses.CC_BY_SA);
contribution.setLicense(license); contribution.setLicense(license);
//FIXME: Add permission request here. Only executeAsyncTask if permission has been granted
Utils.executeAsyncTask(new AsyncTask<Void, Void, Contribution>() { Utils.executeAsyncTask(new AsyncTask<Void, Void, Contribution>() {
// Fills up missing information about Contributions // Fills up missing information about Contributions